From: Jens Axboe <axboe@kernel.dk>
To: Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>,
io-uring@vger.kernel.org
Cc: joseph.qi@linux.alibaba.com
Subject: Re: [PATCH v2] io_uring: handle -EFAULT properly in io_uring_setup()
Date: Tue, 5 May 2020 13:18:30 -0600 [thread overview]
Message-ID: <d800138c-4e25-e429-ffe2-5fcf5277185d@kernel.dk> (raw)
In-Reply-To: <20200505082853.28411-1-xiaoguang.wang@linux.alibaba.com>
On 5/5/20 2:28 AM, Xiaoguang Wang wrote:
> If copy_to_user() in io_uring_setup() failed, we'll leak many kernel
> resources, which will be recycled until process terminates. This bug
> can be reproduced by using mprotect to set params to PROT_READ. To fix
> this issue, refactor io_uring_create() a bit to add a new 'struct
> io_uring_params __user *params' parameter and move the copy_to_user()
> in io_uring_setup() to io_uring_setup(), if copy_to_user() failed,
> we can free kernel resource properly.
Applied, thanks!
--
Jens Axboe
prev parent reply other threads:[~2020-05-05 19:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 8:28 [PATCH v2] io_uring: handle -EFAULT properly in io_uring_setup() Xiaoguang Wang
2020-05-05 19:18 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d800138c-4e25-e429-ffe2-5fcf5277185d@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=xiaoguang.wang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.