All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PULL 0/8] QAPI patches patches for 2022-01-27
Date: Thu, 27 Jan 2022 16:55:38 +0300	[thread overview]
Message-ID: <d80654f3-9da9-e3f0-3968-a0658627e6e1@virtuozzo.com> (raw)
In-Reply-To: <CAFEAcA-63VsRor-FbOo7KhR-5R1a2AeBmJc=GzNTZmPoq5kWWQ@mail.gmail.com>

27.01.2022 15:56, Peter Maydell wrote:
> On Thu, 27 Jan 2022 at 11:29, Markus Armbruster <armbru@redhat.com> wrote:
>>
>> The following changes since commit 48302d4eb628ff0bea4d7e92cbf6b726410eb4c3:
>>
>>    Merge remote-tracking branch 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20220126' into staging (2022-01-26 10:59:50 +0000)
>>
>> are available in the Git repository at:
>>
>>    git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2022-01-27
>>
>> for you to fetch changes up to 5161c168b44f3a8fcae8c4f29c81f374ab0af8e1:
>>
>>    qapi: generate trace events by default (2022-01-27 11:28:44 +0100)
>>
>> ----------------------------------------------------------------
>> QAPI patches patches for 2022-01-27
>>
> 
> Fails to build on the CI jobs that build docs, eg:
> https://gitlab.com/qemu-project/qemu/-/jobs/2022584945
> https://gitlab.com/qemu-project/qemu/-/jobs/2022585026
> 
> Warning, treated as error:
> /home/gitlab-runner/builds/CMuZxyfG/0/qemu-project/qemu/docs/devel/qapi-code-gen.rst:1634:undefined
> label: tracing (if the link has no caption the label must precede a
> section header)
> 

Sorry :/ again, me not enabling docs compilation to save my time and waste others one :(

The fix should look like this (squash to "docs/qapi-code-gen: update to cover trace events code generation" patch):

diff --git a/docs/devel/tracing.rst b/docs/devel/tracing.rst
index ba83954899..4290ac42ee 100644
--- a/docs/devel/tracing.rst
+++ b/docs/devel/tracing.rst
@@ -1,3 +1,5 @@
+.. _tracing:
+
  =======
  Tracing
  =======


Than link works. For example, in docs/devel/build-system.rst we have :ref:`kconfig` and docs/devel/kconfig.rst starts with

.. _kconfig:




-- 
Best regards,
Vladimir


  reply	other threads:[~2022-01-27 13:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 11:28 [PULL 0/8] QAPI patches patches for 2022-01-27 Markus Armbruster
2022-01-27 11:28 ` [PULL 1/8] schemas: add missing vim modeline Markus Armbruster
2022-01-27 11:28 ` [PULL 2/8] qapi/gen: Add FOO.trace-events output module Markus Armbruster
2022-01-27 11:28 ` [PULL 3/8] qapi/commands: refactor error handling code Markus Armbruster
2022-01-27 11:28 ` [PULL 4/8] qapi/commands: Optionally generate trace for QMP commands Markus Armbruster
2022-01-27 11:28 ` [PULL 5/8] meson: generate trace events for qmp commands Markus Armbruster
2022-01-27 11:28 ` [PULL 6/8] docs/qapi-code-gen: update to cover trace events code generation Markus Armbruster
2022-01-27 11:28 ` [PULL 7/8] meson: document why we don't generate trace events for tests/ and qga/ Markus Armbruster
2022-01-27 11:28 ` [PULL 8/8] qapi: generate trace events by default Markus Armbruster
2022-01-27 12:56 ` [PULL 0/8] QAPI patches patches for 2022-01-27 Peter Maydell
2022-01-27 13:55   ` Vladimir Sementsov-Ogievskiy [this message]
2022-01-27 14:19     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d80654f3-9da9-e3f0-3968-a0658627e6e1@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.