From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B874EC433EF for ; Tue, 16 Nov 2021 12:08:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4354B61414 for ; Tue, 16 Nov 2021 12:08:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4354B61414 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:36380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmxG4-0006ZR-F1 for qemu-devel@archiver.kernel.org; Tue, 16 Nov 2021 07:08:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmxEh-00054Q-Rf for qemu-devel@nongnu.org; Tue, 16 Nov 2021 07:06:52 -0500 Received: from [2a00:1450:4864:20::335] (port=54966 helo=mail-wm1-x335.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmxEe-0005iW-GP for qemu-devel@nongnu.org; Tue, 16 Nov 2021 07:06:51 -0500 Received: by mail-wm1-x335.google.com with SMTP id i12so15864296wmq.4 for ; Tue, 16 Nov 2021 04:06:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ln+mu+GjaKuv6wgpEzsz1KfTn8Re8Ycce0GWgoei4mU=; b=XO2NsknCUyB64M5T7151NFm3IoERd2JJ7sj5W1JKiKWDD68naKiy7iebJeJ2SgTFaF LPi7oXTz8vMMP2+M03BJTAwUFYFWxAfjWq17TSFKNvPLvJezgXW69de3P1IeUUl42jTx dXd+MJgvi9p5eLmm17iTRJh/Y6S0ORuuJ1vL1lLqwD+vEONDx02OQNU/pABlt/e1UZjd nVJOnlIpXGGyvZPFDkQiGXgVHVesE3PLtAkeflcBWxXtKjn19FFIirtY5zhZkL0HM9nv kl1nhn/tLY9JGeRbsH4gXEqos7YDzypi2fwgh09EmKCBFE3Ttx1udFO2rbUPv47zrG60 RQPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ln+mu+GjaKuv6wgpEzsz1KfTn8Re8Ycce0GWgoei4mU=; b=jt+YmOmJSI1BoUkbMXpGAngRxKR/9eqX9u+TGdrLF7TQd9TvOzKYRXC8+aE2nl+wZS Co+H6j7eIWV6oKpdXRCdbm4ETCIxGVF4ZBhJecxAB7QXGVkqH+f/VTdxFwYtuqYbvCXH XGSw0hqsEVTJ94Vlb+6X7q0pOOFStf8OQy93SyilTOa92F2m1VxrZjo0zl53x+ZiGWXt t4zr5LqAHDV/oMyMh9OlkfabQdA/Cf8e2PPVsuQeHO1Oj7HASmqGERxIeHqwVpuINP0C c87r2XC/nqQvCPgHI+fEbsvCVyxiJk9L+YDZr3v37ynvsSZs4ImV+7dfTUfhNABnHTPr Ibng== X-Gm-Message-State: AOAM533HR2aB3HZrEZAlm3o67uavnUpRnHAi0ZzlQk6sDcp4dnPbPUws JtpYf+YgM3iBpr561y+zrtpGUg== X-Google-Smtp-Source: ABdhPJzQXfLbsI3s9o9t9QiqZvtqX09XbbjszgXuaEvlOy9MB+PG2tKGZstb+/dKNQfqT9EhNqKFbw== X-Received: by 2002:a7b:c04b:: with SMTP id u11mr68378139wmc.127.1637064406261; Tue, 16 Nov 2021 04:06:46 -0800 (PST) Received: from [192.168.8.105] (145.red-37-158-173.dynamicip.rima-tde.net. [37.158.173.145]) by smtp.gmail.com with ESMTPSA id g5sm26089333wri.45.2021.11.16.04.06.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Nov 2021 04:06:45 -0800 (PST) Subject: Re: [PATCH-for-7.0 v4 05/11] tests/unit/test-smp-parse: Split the 'generic' test in valid / invalid To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20211115145900.2531865-1-philmd@redhat.com> <20211115145900.2531865-6-philmd@redhat.com> From: Richard Henderson Message-ID: Date: Tue, 16 Nov 2021 13:06:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211115145900.2531865-6-philmd@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::335 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.446, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yanan Wang , Andrew Jones , Eduardo Habkost , Thomas Huth , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/15/21 3:58 PM, Philippe Mathieu-Daudé wrote: > Split the 'generic' test in two tests: 'valid' and 'invalid'. > This will allow us to remove the hack which modifies the > MachineClass internal state. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/unit/test-smp-parse.c | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~