From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4936AC433F5 for ; Tue, 9 Nov 2021 08:29:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B0876115A for ; Tue, 9 Nov 2021 08:29:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239066AbhKIIcO (ORCPT ); Tue, 9 Nov 2021 03:32:14 -0500 Received: from foss.arm.com ([217.140.110.172]:58328 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241549AbhKIIcO (ORCPT ); Tue, 9 Nov 2021 03:32:14 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57ED02B; Tue, 9 Nov 2021 00:29:28 -0800 (PST) Received: from [10.57.26.224] (unknown [10.57.26.224]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 718EB3F5A1; Tue, 9 Nov 2021 00:29:24 -0800 (PST) Subject: Re: [PATCH v3 0/5] Refactor thermal pressure update to avoid code duplication To: Steev Klimaszewski Cc: Thara Gopinath , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com, linux@armlinux.org.uk, gregkh@linuxfoundation.org, rafael@kernel.org, viresh.kumar@linaro.org, amitk@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, bjorn.andersson@linaro.org, agross@kernel.org References: <20211103161020.26714-1-lukasz.luba@arm.com> <3cba148a-7077-7b6b-f131-dc65045aa348@arm.com> <9d533b6e-a81c-e823-fa6f-61fdea92fa65@kali.org> <74ea027b-b213-42b8-0f7d-275f3b84712e@linaro.org> <74603569-2ff1-999e-9618-79261fdb0ee4@kali.org> <59054c90-c1cd-85bf-406e-579df668d7b4@linaro.org> <2c54dbbd-2ecb-fb76-fa9f-9752f429c20e@linaro.org> <97e93876-d654-0a89-dce1-6fe1189345e2@kali.org> From: Lukasz Luba Message-ID: Date: Tue, 9 Nov 2021 08:29:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <97e93876-d654-0a89-dce1-6fe1189345e2@kali.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Steev, That's interesting what you've done with Rockchip RK3399. I would like to reproduce your experiment on my RockPI 4B v1.3. Could you tell me how you to add this boost frequency that you have mentioned in some previous emails? I want to have similar setup to yours and I'll check all the subsystems involved in the decision making process for triggering this boost freq. On 11/8/21 11:21 PM, Steev Klimaszewski wrote: > Hi Thara, >> Hi Steev, >> >> IIUC, PineBook Pro has Rockchip RK3399 which has 2 Cortex A-72 and 4 >> Cortex A-52 where as C630 has Qualcomm sdm845 which has 4 Cortex A-75 >> and 4 Cortex A-55. Task placements and subsequently cpu load will be >> different for both the platforms. With the same workload, I will >> expect Rockchip to system to be more loaded than sdm845. Having said >> that, what cpu-freq governor are you using on both the systems. >> > I'm using sched-util on both of the systems. > > I've tried a number of different ways of forcing builds only on the A-75 > cores, and I simply cannot get the load to be "enough" to kick in the > boost frequency. > > An example being > > git clone https://github.com/zellij-org/zellij.git > > cd zellij > > taskset --cpu-list 4-7 cargo build --release > > git clean -fdx > > taskset --cpu-list 6-7 cargo build --release Thanks for the pointers, I'll give it a try when I sort out this Rockchip boost setup. > > > On my C630, it never goes higher than 85C with the 4 cores being used, > and with 2, it never goes about 65C and I do not get any 2.96GHz.  It's > currently sitting at "6" in the time_in_state for 2965800. > > > --steev > Thank you for your support. Regards, Lukasz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B80C6C433F5 for ; Tue, 9 Nov 2021 08:31:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8181C6115A for ; Tue, 9 Nov 2021 08:31:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8181C6115A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AbLQtocBAAO022mqNmDKha1dUIurwyNOigdZkXztsss=; b=dr8C4uV6DZDLV9fJM/KrUHWpMJ nth6xtA3uANzmrFmQJDITMvXd080dRfWxzAh4xDmbIsoNED8it2ULTi3AK25RdjpedlLbWzpX0nMh yciauaKhXA7WOXc93mcFPEWJz7bDCrD9k6uDpPgrshCa6Jqy7GrtuVhxqDLfHpC6swyNw3ymh4r4Q FOfwpUqsA4Kbd2a236hdVFy26Vi0yo9aRQbvQz82qSGf0bVQ9tgeJn72+iFqPNOncSy9mYkUvAJ76 GUKDqR1tt3W72Vkq8bDRTtTbI8D9tqRBwLJS2Rhy2op0841ZAC6r6AzJ3Nuc/PS8es1VNEV3Zk/PZ auAyxVng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkMVd-0010Ur-NH; Tue, 09 Nov 2021 08:29:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkMVW-0010TY-1C for linux-arm-kernel@lists.infradead.org; Tue, 09 Nov 2021 08:29:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57ED02B; Tue, 9 Nov 2021 00:29:28 -0800 (PST) Received: from [10.57.26.224] (unknown [10.57.26.224]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 718EB3F5A1; Tue, 9 Nov 2021 00:29:24 -0800 (PST) Subject: Re: [PATCH v3 0/5] Refactor thermal pressure update to avoid code duplication To: Steev Klimaszewski Cc: Thara Gopinath , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com, linux@armlinux.org.uk, gregkh@linuxfoundation.org, rafael@kernel.org, viresh.kumar@linaro.org, amitk@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, bjorn.andersson@linaro.org, agross@kernel.org References: <20211103161020.26714-1-lukasz.luba@arm.com> <3cba148a-7077-7b6b-f131-dc65045aa348@arm.com> <9d533b6e-a81c-e823-fa6f-61fdea92fa65@kali.org> <74ea027b-b213-42b8-0f7d-275f3b84712e@linaro.org> <74603569-2ff1-999e-9618-79261fdb0ee4@kali.org> <59054c90-c1cd-85bf-406e-579df668d7b4@linaro.org> <2c54dbbd-2ecb-fb76-fa9f-9752f429c20e@linaro.org> <97e93876-d654-0a89-dce1-6fe1189345e2@kali.org> From: Lukasz Luba Message-ID: Date: Tue, 9 Nov 2021 08:29:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <97e93876-d654-0a89-dce1-6fe1189345e2@kali.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211109_002930_159393_84863F77 X-CRM114-Status: GOOD ( 17.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU3RlZXYsCgpUaGF0J3MgaW50ZXJlc3Rpbmcgd2hhdCB5b3UndmUgZG9uZSB3aXRoIFJvY2tj aGlwIFJLMzM5OS4KSSB3b3VsZCBsaWtlIHRvIHJlcHJvZHVjZSB5b3VyIGV4cGVyaW1lbnQgb24g bXkgUm9ja1BJIDRCIHYxLjMuCkNvdWxkIHlvdSB0ZWxsIG1lIGhvdyB5b3UgdG8gYWRkIHRoaXMg Ym9vc3QgZnJlcXVlbmN5IHRoYXQgeW91IGhhdmUKbWVudGlvbmVkIGluIHNvbWUgcHJldmlvdXMg ZW1haWxzPwoKSSB3YW50IHRvIGhhdmUgc2ltaWxhciBzZXR1cCB0byB5b3VycyBhbmQgSSdsbCBj aGVjayBhbGwgdGhlIHN1YnN5c3RlbXMKaW52b2x2ZWQgaW4gdGhlIGRlY2lzaW9uIG1ha2luZyBw cm9jZXNzIGZvciB0cmlnZ2VyaW5nIHRoaXMgYm9vc3QgZnJlcS4KCk9uIDExLzgvMjEgMTE6MjEg UE0sIFN0ZWV2IEtsaW1hc3pld3NraSB3cm90ZToKPiBIaSBUaGFyYSwKPj4gSGkgU3RlZXYsCj4+ Cj4+IElJVUMsIFBpbmVCb29rIFBybyBoYXMgUm9ja2NoaXAgUkszMzk5IHdoaWNoIGhhcyAyIENv cnRleCBBLTcyIGFuZCA0IAo+PiBDb3J0ZXggQS01MiB3aGVyZSBhcyBDNjMwIGhhcyBRdWFsY29t bSBzZG04NDUgd2hpY2ggaGFzIDQgQ29ydGV4IEEtNzUgCj4+IGFuZCA0IENvcnRleCBBLTU1LiBU YXNrIHBsYWNlbWVudHMgYW5kIHN1YnNlcXVlbnRseSBjcHUgbG9hZCB3aWxsIGJlIAo+PiBkaWZm ZXJlbnQgZm9yIGJvdGggdGhlIHBsYXRmb3Jtcy4gV2l0aCB0aGUgc2FtZSB3b3JrbG9hZCwgSSB3 aWxsIAo+PiBleHBlY3QgUm9ja2NoaXAgdG8gc3lzdGVtIHRvIGJlIG1vcmUgbG9hZGVkIHRoYW4g c2RtODQ1LiBIYXZpbmcgc2FpZCAKPj4gdGhhdCwgd2hhdCBjcHUtZnJlcSBnb3Zlcm5vciBhcmUg eW91IHVzaW5nIG9uIGJvdGggdGhlIHN5c3RlbXMuCj4+Cj4gSSdtIHVzaW5nIHNjaGVkLXV0aWwg b24gYm90aCBvZiB0aGUgc3lzdGVtcy4KPiAKPiBJJ3ZlIHRyaWVkIGEgbnVtYmVyIG9mIGRpZmZl cmVudCB3YXlzIG9mIGZvcmNpbmcgYnVpbGRzIG9ubHkgb24gdGhlIEEtNzUgCj4gY29yZXMsIGFu ZCBJIHNpbXBseSBjYW5ub3QgZ2V0IHRoZSBsb2FkIHRvIGJlICJlbm91Z2giIHRvIGtpY2sgaW4g dGhlIAo+IGJvb3N0IGZyZXF1ZW5jeS4KPiAKPiBBbiBleGFtcGxlIGJlaW5nCj4gCj4gZ2l0IGNs b25lIGh0dHBzOi8vZ2l0aHViLmNvbS96ZWxsaWotb3JnL3plbGxpai5naXQKPiAKPiBjZCB6ZWxs aWoKPiAKPiB0YXNrc2V0IC0tY3B1LWxpc3QgNC03IGNhcmdvIGJ1aWxkIC0tcmVsZWFzZQo+IAo+ IGdpdCBjbGVhbiAtZmR4Cj4gCj4gdGFza3NldCAtLWNwdS1saXN0IDYtNyBjYXJnbyBidWlsZCAt LXJlbGVhc2UKClRoYW5rcyBmb3IgdGhlIHBvaW50ZXJzLCBJJ2xsIGdpdmUgaXQgYSB0cnkgd2hl biBJIHNvcnQgb3V0IHRoaXMKUm9ja2NoaXAgYm9vc3Qgc2V0dXAuCgo+IAo+IAo+IE9uIG15IEM2 MzAsIGl0IG5ldmVyIGdvZXMgaGlnaGVyIHRoYW4gODVDIHdpdGggdGhlIDQgY29yZXMgYmVpbmcg dXNlZCwgCj4gYW5kIHdpdGggMiwgaXQgbmV2ZXIgZ29lcyBhYm91dCA2NUMgYW5kIEkgZG8gbm90 IGdldCBhbnkgMi45NkdIei7CoCBJdCdzIAo+IGN1cnJlbnRseSBzaXR0aW5nIGF0ICI2IiBpbiB0 aGUgdGltZV9pbl9zdGF0ZSBmb3IgMjk2NTgwMC4KPiAKPiAKPiAtLXN0ZWV2Cj4gCgpUaGFuayB5 b3UgZm9yIHlvdXIgc3VwcG9ydC4KClJlZ2FyZHMsCkx1a2FzegoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=