From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 390DD2C9D for ; Wed, 12 Jan 2022 11:31:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641987074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C66zPnUJeDWEIlSEzKy00mOLRxBuQ1dDqv+Z3TGt8nE=; b=Olw/oYaxvl13I6FA3QJpZCybdhGnaS1KFy6Yi6LBP6hDfJNtJSTXT6TQtbQKJU3C/bTPwl Jy3S73axQGKf/88MJg0OodDoZHeTAtYV9IjLD38rEGeAau3hUzEGMJMDj1SVTGry1wxZTD vuj1D+A49N4NJHqc1tkCYQWeFUc/sSo= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-638-X2W0PIxZMz-PiQ6pZc2w4w-1; Wed, 12 Jan 2022 06:31:12 -0500 X-MC-Unique: X2W0PIxZMz-PiQ6pZc2w4w-1 Received: by mail-ed1-f72.google.com with SMTP id z10-20020a05640235ca00b003f8efab3342so2025675edc.2 for ; Wed, 12 Jan 2022 03:31:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=C66zPnUJeDWEIlSEzKy00mOLRxBuQ1dDqv+Z3TGt8nE=; b=DTl+vCKC7LPT8t1NGi0ycWazhf/T4O8sMbGvLumsLrP0feEdjz4Rlnwm0MJK0Vm1oN Hmosb4S9zRH8Uxxc9U9gPtJiuC+WeaRgl1eLapHJf8m+kCSd539hwO8JlbkwgbbD2LzZ UAXOTjGiH+oLDzEHlz/bFjTu4wG5ylDg/pjUbUQqb19mYlFzlgYEFqYkfy9pnLYm2CWx trws97YTmAaGRyGfhQFIMYkJoTd63giBCU91m8RZU1MbIXHlxZc7Ln/rZwliGTXTJkpR +CsqxU7WgN2KyhSvYZT52MEUYc35FBN1KGtMpD1Y+bVJqaULOuxR/LlSyGizi9eMcyRo NVDw== X-Gm-Message-State: AOAM53142uxNdhZlbUYVlNDs82vkiGMHm7HJYczW3h6r3kyNNcVBCZ+1 ywxfI/n6VxqU9/8xFPBmyu3gzxiRXjZJ4E/AAsq4/qdkvqD3zRhOw+XIJ3XBRP1xjllalPFck+q 5JGgQPz2gf4pBh0ASbFoCrQ== X-Received: by 2002:a17:906:f243:: with SMTP id gy3mr7322351ejb.432.1641987071760; Wed, 12 Jan 2022 03:31:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzsE7p0G+4kzPLfTKaUz/IaDx53eZn3tKCrLaSx+D5x62EAUjJVBrepv4kYr8O17+iEwsPgQQ== X-Received: by 2002:a17:906:f243:: with SMTP id gy3mr7322324ejb.432.1641987071547; Wed, 12 Jan 2022 03:31:11 -0800 (PST) Received: from ?IPV6:2003:cb:c702:4700:e25f:39eb:3cb8:1dec? (p200300cbc7024700e25f39eb3cb81dec.dip0.t-ipconnect.de. [2003:cb:c702:4700:e25f:39eb:3cb8:1dec]) by smtp.gmail.com with ESMTPSA id r17sm409452edw.70.2022.01.12.03.31.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 03:31:11 -0800 (PST) Message-ID: Date: Wed, 12 Jan 2022 12:31:10 +0100 Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 To: Dave Hansen , "Kirill A. Shutemov" , Borislav Petkov , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel Cc: Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220111113314.27173-1-kirill.shutemov@linux.intel.com> <20220111113314.27173-2-kirill.shutemov@linux.intel.com> <3a68fabd-eaff-2164-5609-3a71fd4a7257@intel.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCHv2 1/7] mm: Add support for unaccepted memory In-Reply-To: <3a68fabd-eaff-2164-5609-3a71fd4a7257@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit > > Looking at stuff like this, I can't help but think that a: > > #define PageOffline PageUnaccepted > > and some other renaming would be a fine idea. I get that the Offline > bit can be reused, but I'm not sure that the "Offline" *naming* should > be reused. What you're doing here is logically distinct from existing > offlining. Yes, or using a new pagetype bit to make the distinction clearer. Especially the function names like maybe_set_page_offline() et. Al are confusing IMHO. They are all about accepting unaccepted memory ... and should express that. I assume PageOffline() will be set only on the first sub-page of a high-order PageBuddy() page, correct? Then we'll have to monitor all PageOffline() users such that they can actually deal with PageBuddy() pages spanning *multiple* base pages for a PageBuddy() page. For now it's clear that if a page is PageOffline(), it cannot be PageBuddy() and cannot span more than one base page. E.g., fs/proc/kcore.c:read_kcore() assumes that PageOffline() is set on individual base pages. -- Thanks, David / dhildenb