All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Hannes Reinecke <hare@suse.de>,
	emilne@redhat.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist
Date: Mon, 6 Jun 2016 11:47:43 -0400	[thread overview]
Message-ID: <d84ec540-bfcb-8ce3-8615-bcfeb0271270@redhat.com> (raw)
In-Reply-To: <92aeeb5e-9b36-339e-8e44-afb78adeac6e@redhat.com>



On 06/06/2016 11:43 AM, Paolo Bonzini wrote:
> 
> 
> On 06/06/2016 17:41, John Snow wrote:
>> On 06/06/2016 11:05 AM, Paolo Bonzini wrote:
>>> For ATAPI, you have to blacklist all versions up to 2.2 inclusive.
>>>
>>> This gives:
>>>
>>> - QEMU / QEMU CD-ROM / 0.8.    (this is IDE and SCSI)
>>> - QEMU / QEMU CD-ROM / 0.9.    (this is IDE and SCSI)
>>> - QEMU / QEMU CD-ROM / 0.10    (this is SCSI only)
>>> - QEMU / QEMU CD-ROM / 0.11    (this is SCSI only)
>>> - QEMU / QEMU DVD-ROM / 0.8.   (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 0.9.   (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 0.10   (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 0.11   (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 0.12   (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 0.13   (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 0.14   (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 0.15   (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 1.0    (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 1.1    (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 1.2    (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 1.3    (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 1.4    (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 1.5    (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 1.6    (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 1.7    (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 2.0    (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 2.1    (this is IDE only)
>>> - QEMU / QEMU DVD-ROM / 2.2    (this is IDE only)
>>>
>>
>> If this bug is caused by a missing VPD response, Paolo's version history
>> here is correct.... for upstream versions.
>>
>> Various downstreams may have backported the VPD fix to older versions,
>> we need to be careful not to block those, too ... so targeting the core
>> behavior seems like the more strictly correct, easily maintainable solution.
> 
> I think this is not practical.  I'm okay with the big hammer if an
> algorithmic fix is not feasible; but otherwise it does seem a better
> idea than blacklisting based on inquiry data...
> 
> Thanks,
> 
> Paolo
> 

You think the more practical solution is a SCSI driver that can hang
because of an incorrect/missing response and to maintain a carefully
curated blacklist to work around this behavior?

>> Why not just dynamically blacklist devices that fail to respond to VPD
>> inquiries?
> 

  reply	other threads:[~2016-06-06 15:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 13:42 [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist Ewan D. Milne
2016-05-31 13:43 ` Johannes Thumshirn
2016-06-03  3:19   ` Tom Yan
     [not found]   ` <CAGnHSEmS7NzEFK7uD357r6Y=xU5o1O0i+AU5qhmqcqjmp_K0Lw@mail.gmail.com>
2016-06-03 14:36     ` Ewan D. Milne
2016-06-03 19:14       ` Tom Yan
2016-06-03 19:19         ` Ewan D. Milne
2016-06-03 21:14 ` Bart Van Assche
2016-06-06  7:34 ` Hannes Reinecke
2016-06-06 14:11   ` Ewan D. Milne
2016-06-06 14:22     ` Hannes Reinecke
2016-06-06 15:05       ` Paolo Bonzini
2016-06-06 15:41         ` John Snow
2016-06-06 15:43           ` Paolo Bonzini
2016-06-06 15:47             ` John Snow [this message]
2016-06-06 16:03               ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d84ec540-bfcb-8ce3-8615-bcfeb0271270@redhat.com \
    --to=jsnow@redhat.com \
    --cc=emilne@redhat.com \
    --cc=hare@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.