From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBouTIaoiZAUi497ADXQcUy+cTneAj7ocdnTvYd/+oIkxXUHMhMGYYshyDg5NnqMIjF4MMT9V ARC-Seal: i=1; a=rsa-sha256; t=1516371563; cv=none; d=google.com; s=arc-20160816; b=bLlu1LJyl/fm0cFiWp+EERnl0GQCTjWYrFi3X8L/aK4YAx8YHxnkVmAbYU5Pq6BHmd Wjxmqope9lRO0wgalR8lzZ81BFGrT8Ji4SorpYDGSqi2NgbKgZNJ5zYxTDYz7w1PlDaT u54uA/T2ZmcN9pCdhWoW4YzNa/RYcHrruRiYhsTKk5NZoR8++ocZTskAltrMFucL9e25 X8oAUO1FOBx0MMynNwxwU5higHdjeaFoePxsleShIen4OKfES3eWr6iQeI9dcOsDkD7Y iiGNfTS2yEKQgKLBnXxHoDoKZvFTv2dwAhIbEKjRBs4VAgHEnqW2r/OLykpXozVk2vYK ECbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:to:subject :arc-authentication-results; bh=AzE3UQ71Nw4VKqg9NcfHU7NgzjASYQQPbi/5N1eLnHY=; b=f9czuJb6pS5dFoCWaAOpxr5berIZKtnXv6unom/x2DseYj5eiXPnNoQzveQPIJ6Muo E7aJBzpzZvRJY4Py8Bk1lNSuMCY53NP+fPVDC5k+YH/MAPR9kY7FFLM5MN/a9koevnTk wMSNXWrmKMjkHNpU81cT0/bqTrEnUo5chQp8hhCS74BYVqf4HgVGG0G6bNKt5LlswQXu 7jP0fc+KIalmJ2ZQS9CrnWGGAcgBLfHmTtLeti5tcnxJlt57QjXzalQGkkDudZS8jft0 Nyy55mfRknqXNv71VxABnrrkqjuBm0HDK+wpfAurMifOyUh3HqPpoRAuqnJQwSDJCGm5 j9qA== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 80.241.60.215 is neither permitted nor denied by best guess record for domain of sr@denx.de) smtp.mailfrom=sr@denx.de Authentication-Results: mx.google.com; spf=neutral (google.com: 80.241.60.215 is neither permitted nor denied by best guess record for domain of sr@denx.de) smtp.mailfrom=sr@denx.de Subject: Re: [PATCH v6 7/7] PCI: Unify wait for link active into generic pci To: Oza Pawandeep , Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi References: <1516360204-1586-1-git-send-email-poza@codeaurora.org> <1516360204-1586-8-git-send-email-poza@codeaurora.org> From: Stefan Roese Message-ID: Date: Fri, 19 Jan 2018 15:19:09 +0100 MIME-Version: 1.0 In-Reply-To: <1516360204-1586-8-git-send-email-poza@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590018961580197637?= X-GMAIL-MSGID: =?utf-8?q?1590030828781146492?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 19.01.2018 12:10, Oza Pawandeep wrote: > Clients such as pciehp, dpc are using pcie_wait_link_active, which waits > till the link becomes active or inactive. > > Made generic function and moved it to drivers/pci/pci.c > > Signed-off-by: Oza Pawandeep > > diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c > index 7bab060..26afeff 100644 > --- a/drivers/pci/hotplug/pciehp_hpc.c > +++ b/drivers/pci/hotplug/pciehp_hpc.c > @@ -245,25 +245,12 @@ bool pciehp_check_link_active(struct controller *ctrl) > return ret; > } > > -static void __pcie_wait_link_active(struct controller *ctrl, bool active) > +static bool pcie_wait_link_active(struct controller *ctrl) > { > - int timeout = 1000; > - > - if (pciehp_check_link_active(ctrl) == active) > - return; > - while (timeout > 0) { > - msleep(10); > - timeout -= 10; > - if (pciehp_check_link_active(ctrl) == active) > - return; > - } > - ctrl_dbg(ctrl, "Data Link Layer Link Active not %s in 1000 msec\n", > - active ? "set" : "cleared"); > -} > + struct pci_dev *pdev = ctrl_dev(ctrl); > + bool active = true; > > -static void pcie_wait_link_active(struct controller *ctrl) > -{ > - __pcie_wait_link_active(ctrl, true); > + return pci_wait_for_link(pdev, active); > } > > static bool pci_bus_check_dev(struct pci_bus *bus, int devfn) > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 4a7c686..0de83ea 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -2805,7 +2805,7 @@ static void pci_std_enable_acs(struct pci_dev *dev) > pci_read_config_word(dev, pos + PCI_ACS_CTRL, &ctrl); > > /* Source Validation */ > - ctrl |= (cap & PCI_ACS_SV); > +// ctrl |= (cap & PCI_ACS_SV); Could it be, that you missed to fix / clean something up here? Thanks, Stefan