From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andre Przywara <andre.przywara@arm.com>
Date: Thu, 6 Jul 2017 11:13:05 +0100
Subject: [U-Boot] [linux-sunxi] [PATCH 4/4] sunxi: enable EMAC for
 Banana Pi M3 board
In-Reply-To: <20170702070244.10539-5-icenowy@aosc.io>
References: <20170702070244.10539-1-icenowy@aosc.io>
 <20170702070244.10539-5-icenowy@aosc.io>
Message-ID: <d86480ab-2a6d-4d08-3495-2ac86ebf2473@arm.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

when using the new binding support [1] (this time the link is for real
;-), you could/should adjust the binding to be Linux compatible:

On 02/07/17 08:02, Icenowy Zheng wrote:
> Banana Pi M3 board comes with the A83T EMAC connected to a Realtek
> RTL8211E PHY, with a TX delay of 600ps.
> 
> Add the necessary DT parts and enable sun8i_emac in the defconfig.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  arch/arm/dts/sun8i-a83t-sinovoip-bpi-m3.dts | 13 +++++++++++++
>  configs/Sinovoip_BPI_M3_defconfig           |  1 +
>  2 files changed, 14 insertions(+)
> 
> diff --git a/arch/arm/dts/sun8i-a83t-sinovoip-bpi-m3.dts b/arch/arm/dts/sun8i-a83t-sinovoip-bpi-m3.dts
> index dfc16a0272..8e74227ad6 100644
> --- a/arch/arm/dts/sun8i-a83t-sinovoip-bpi-m3.dts
> +++ b/arch/arm/dts/sun8i-a83t-sinovoip-bpi-m3.dts
> @@ -61,6 +61,19 @@
>  	status = "okay";
>  };
>  
> +&emac {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&emac_rgmii_pins>;
> +	phy-mode = "rgmii";
> +	phy = <&phy1>;

This is called phy-handle in Linux.

> +	allwinner,tx-delay-ps = <600>;
> +	status = "okay";
> +
> +	phy1: ethernet-phy at 1 {
> +		reg = <1>;
> +	};

This should be a child of the mdio node.

Cheers,
Andre.

[1] https://lists.denx.de/pipermail/u-boot/2017-July/296929.html

> +};
> +

>  &uart0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0_pins_b>;
> diff --git a/configs/Sinovoip_BPI_M3_defconfig b/configs/Sinovoip_BPI_M3_defconfig
> index 45eadcb443..ff068900a5 100644
> --- a/configs/Sinovoip_BPI_M3_defconfig
> +++ b/configs/Sinovoip_BPI_M3_defconfig
> @@ -22,6 +22,7 @@ CONFIG_SPL=y
>  # CONFIG_SPL_DOS_PARTITION is not set
>  # CONFIG_SPL_ISO_PARTITION is not set
>  # CONFIG_SPL_EFI_PARTITION is not set
> +CONFIG_SUN8I_EMAC=y
>  CONFIG_AXP_DCDC5_VOLT=1200
>  CONFIG_AXP_DLDO3_VOLT=2500
>  CONFIG_AXP_SW_ON=y
>