Re: [PATCH] hwrng: exynos: Use pm_runtime_resume_and_get() to replace open coding

From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Tian Tao <tiantao6@hisilicon.com>, l.stelmach@samsung.com
Cc: linux-samsung-soc@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH] hwrng: exynos: Use pm_runtime_resume_and_get() to replace open coding
Date: Fri, 21 May 2021 07:24:05 -0400	[thread overview]
Message-ID: <d871c39a-2592-d50d-9a8d-69dc54b3fd55@canonical.com> (raw)
In-Reply-To: <1621569489-20554-1-git-send-email-tiantao6@hisilicon.com>

On 20/05/2021 23:58, Tian Tao wrote:
> use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. this change is just to simplify the code, no
> actual functional changes.
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
>  drivers/char/hw_random/exynos-trng.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c
> index 8e1fe3f..d71ef3c 100644
> --- a/drivers/char/hw_random/exynos-trng.c
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -196,10 +196,9 @@ static int __maybe_unused exynos_trng_resume(struct device *dev)
>  {
>  	int ret;
>  
> -	ret = pm_runtime_get_sync(dev);
> -	if (ret < 0) {
> +	ret = pm_runtime_resume_and_get(dev);
> +	if (ret) {
>  		dev_err(dev, "Could not get runtime PM.\n");
> -		pm_runtime_put_noidle(dev);
>  		return ret;

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof