From: Shoaib Rao <rao.shoaib@oracle.com>
To: "Pearson, Robert B" <robert.pearson2@hpe.com>,
Jason Gunthorpe <jgg@ziepe.ca>
Cc: Zhu Yanjun <zyjzyj2000@gmail.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH v3 0/1] RDMA/rxe: Bump up default maximum values used via uverbs
Date: Wed, 4 Aug 2021 23:11:15 -0700 [thread overview]
Message-ID: <d89b2a2d-e72b-4942-28d6-c2a528053416@oracle.com> (raw)
In-Reply-To: <DF4PR8401MB1081385A8812159BA8E96A03BCEB9@DF4PR8401MB1081.NAMPRD84.PROD.OUTLOOK.COM>
Bob,
Your third patch has an issue.
In rxe_cq_post()
addr = producer_addr(cq->queue, QUEUE_TYPE_TO_CLIENT);
It should be
addr = producer_addr(cq->queue, QUEUE_TYPE_FROM_CLIENT);
After making this change, I have tested my patch and rping works.
Bob can you please point me to the discussion which lead to the current
changes, particularly the need for user barrier.
Zhu can you apply Bob's 3 patches + the change above + my patch and
report back. In my testing it works.
Regards,
Shoaib
On 7/29/21 4:08 PM, Pearson, Robert B wrote:
> I found another rxe bug (for SRQ) and sent three bug fixes in a set including the one you mention. They should all be applied.
>
> -----Original Message-----
> From: Jason Gunthorpe <jgg@ziepe.ca>
> Sent: Thursday, July 29, 2021 2:51 PM
> To: Shoaib Rao <rao.shoaib@oracle.com>
> Cc: Zhu Yanjun <zyjzyj2000@gmail.com>; RDMA mailing list <linux-rdma@vger.kernel.org>
> Subject: Re: [PATCH v3 0/1] RDMA/rxe: Bump up default maximum values used via uverbs
>
> On Thu, Jul 29, 2021 at 12:33:14PM -0700, Shoaib Rao wrote:
>
>> Can we please accept my initial patch where I bumped up the values of
>> a few parameters. We have extensively tested with those values. I will
>> try to resolve CRC errors and panic and make changes to other tuneables later?
> I think Bob posted something for the icrc issues already
>
> Please try to work in a sane fashion, rxe shouldn't be left broken with so many people apparently interested in it??
>
> Jason
next prev parent reply other threads:[~2021-08-05 6:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 22:59 [PATCH v3 0/1] RDMA/rxe: Bump up default maximum values used via uverbs Rao Shoaib
2021-07-18 22:59 ` [PATCH v3 1/1] " Rao Shoaib
2021-07-27 16:15 ` [PATCH v3 0/1] " Shoaib Rao
2021-07-27 17:41 ` Jason Gunthorpe
2021-07-29 6:42 ` Zhu Yanjun
2021-07-29 6:52 ` Shoaib Rao
2021-07-29 7:57 ` Zhu Yanjun
2021-07-29 19:33 ` Shoaib Rao
2021-07-29 19:50 ` Jason Gunthorpe
2021-07-29 20:33 ` Shoaib Rao
2021-07-29 23:08 ` Pearson, Robert B
2021-07-30 0:34 ` Shoaib Rao
2021-08-03 23:53 ` Shoaib Rao
2021-08-04 0:51 ` Zhu Yanjun
2021-08-04 1:51 ` Shoaib Rao
2021-08-04 2:21 ` Zhu Yanjun
2021-08-05 4:10 ` Shoaib Rao
2021-08-05 6:56 ` Leon Romanovsky
2021-08-05 6:11 ` Shoaib Rao [this message]
2021-08-06 13:49 ` Jason Gunthorpe
2021-09-13 0:50 ` Shoaib Rao
2021-09-13 3:34 ` Pearson, Robert B
2021-09-14 16:14 ` Bob Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d89b2a2d-e72b-4942-28d6-c2a528053416@oracle.com \
--to=rao.shoaib@oracle.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=robert.pearson2@hpe.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.