From: "Christian König" <deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
To: Alex Deucher
<alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
Andrey Grodzovsky
<Andrey.Grodzovsky-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 2/2] drm/amdgpu: Refactor flip into prepare submit and submit. (v2)
Date: Sat, 14 Jan 2017 08:36:12 +0100 [thread overview]
Message-ID: <d8aa133c-f3fd-9b0f-03da-e52f410c99d3@vodafone.de> (raw)
In-Reply-To: <1484332005-12910-2-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
Am 13.01.2017 um 19:26 schrieb Alex Deucher:
> From: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
>
> Make pflip atomic friendly. Split the fuinction into
> whatever can fail part and the actual flip submit part.
> Call the pre-submit function before atomic states
> are swapped so in case of error we can fail the
> IOCTL.
>
> v2:
> Update due to target_vblank code change.
> Fix identetation.
> Change return type for amdgpu_crtc_submit_flip to void
>
> Signed-off-by: Andrey Grodzovsky <Andrey.Grodzovsky@amd.com>
> Reviewed-by Harry Wentland <harry.wentland@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
The coding style on a couple of functions headers is incorrect, here for
example:
> void amdgpu_crtc_cleanup_flip_ctx(
> struct amdgpu_flip_work *work,
> struct amdgpu_bo *new_abo)
That should look like:
> void amdgpu_crtc_cleanup_flip_ctx(struct amdgpu_flip_work *work,
> struct amdgpu_bo *new_abo)
Regards,
Christian.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2017-01-14 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 18:26 [PATCH 1/2] drm/amdgpu: Switch error code when bo pin fails. (v3) Alex Deucher
[not found] ` <1484332005-12910-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-01-13 18:26 ` [PATCH 2/2] drm/amdgpu: Refactor flip into prepare submit and submit. (v2) Alex Deucher
[not found] ` <1484332005-12910-2-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-01-14 7:36 ` Christian König [this message]
2017-01-14 7:37 ` [PATCH 1/2] drm/amdgpu: Switch error code when bo pin fails. (v3) Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8aa133c-f3fd-9b0f-03da-e52f410c99d3@vodafone.de \
--to=deathsimple-antagkrnahcb1svskn2v4q@public.gmane.org \
--cc=Andrey.Grodzovsky-5C7GfCeVMHo@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.