From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD62C33C9E for ; Tue, 28 Jan 2020 10:58:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FB6A2467E for ; Tue, 28 Jan 2020 10:58:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580209113; bh=fPIGD7bZiuPsICx66b+4r7EJxaT51+ZFDK7Fnb9seEk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=VgGmOo350CpHC5Dq+ljMUnjIOTfFrXoLnDQaZckohBK51qp7r6oSrAgnAyHnQ2/CR VSwMPcXrI3KMeTDw2tR5hK0vioKyvy8ZtroLT/vkHYhBMtd6OmVV4eNfGfXVlJ0TpS 2O6G8hyQBIQbBuM1Z/RYqYahWv9zJtazgbvUTnbQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725903AbgA1K6c (ORCPT ); Tue, 28 Jan 2020 05:58:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:35148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725901AbgA1K6c (ORCPT ); Tue, 28 Jan 2020 05:58:32 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 022272467B; Tue, 28 Jan 2020 10:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580209111; bh=fPIGD7bZiuPsICx66b+4r7EJxaT51+ZFDK7Fnb9seEk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1ctD0lburdWt3ZOtVj5XjYkEhuGI8R5O7+QvVol5aKA4A/kVC5guTaNEXrw4S+q7C ROcM5bCZuKIpf1xHbcixgP2r6MHVi4yBvKGo9D46PITetF2dNVQ29fOpZ1T4os+5tm 1AAyEH+The9/aovJDctEl2W6zefngSGCDwPsxEhU= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iwOZh-001naq-9h; Tue, 28 Jan 2020 10:58:29 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 28 Jan 2020 10:58:29 +0000 From: Marc Zyngier To: Makarand Pawagi Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux@armlinux.org.uk, jon@solid-run.com, cristian.sovaiala@nxp.com, laurentiu.tudor@nxp.com, ioana.ciornei@nxp.com, V.Sethi@nxp.com, calvin.johnson@nxp.com, pankaj.bansal@nxp.com, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, sudeep.holla@arm.com, rjw@rjwysocki.net, lenb@kernel.org, stuyoder@gmail.com, tglx@linutronix.de, jason@lakedaemon.net, shameerali.kolothum.thodi@huawei.com, will@kernel.org, robin.murphy@arm.com, nleeder@codeaurora.org Subject: Re: [PATCH] bus: fsl-mc: Add ACPI support for fsl-mc In-Reply-To: <1580198925-50411-1-git-send-email-makarand.pawagi@nxp.com> References: <1580198925-50411-1-git-send-email-makarand.pawagi@nxp.com> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.8 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: makarand.pawagi@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux@armlinux.org.uk, jon@solid-run.com, cristian.sovaiala@nxp.com, laurentiu.tudor@nxp.com, ioana.ciornei@nxp.com, V.Sethi@nxp.com, calvin.johnson@nxp.com, pankaj.bansal@nxp.com, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, sudeep.holla@arm.com, rjw@rjwysocki.net, lenb@kernel.org, stuyoder@gmail.com, tglx@linutronix.de, jason@lakedaemon.net, shameerali.kolothum.thodi@huawei.com, will@kernel.org, robin.murphy@arm.com, nleeder@codeaurora.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 2020-01-28 08:08, Makarand Pawagi wrote: > ACPI support is added in the fsl-mc driver. Driver will parse > MC DSDT table to extract memory and other resorces. > > Interrupt (GIC ITS) information will be extracted from MADT table > by drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c. > > IORT table will be parsed to configure DMA. > > Signed-off-by: Makarand Pawagi > --- > drivers/acpi/arm64/iort.c | 53 +++++++++++++++++++++ > drivers/bus/fsl-mc/dprc-driver.c | 3 +- > drivers/bus/fsl-mc/fsl-mc-bus.c | 48 +++++++++++++------ > drivers/bus/fsl-mc/fsl-mc-msi.c | 10 +++- > drivers/bus/fsl-mc/fsl-mc-private.h | 4 +- > drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c | 71 > ++++++++++++++++++++++++++++- > include/linux/acpi_iort.h | 5 ++ > 7 files changed, 174 insertions(+), 20 deletions(-) A general comment when you do this kind of work: Do not write a single patch that impacts at least three different subsystems. As it is, it is unmergeable. Now the real question is *WHY* we need this kind of monstruosity? ACPI deals with PCI, not with exotic busses and whatnot. If you want to be creative, DT is your space. ACPI is designed to be plain and boring, and that's how we like it. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 440B2C33C9E for ; Tue, 28 Jan 2020 10:58:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14E2A2467E for ; Tue, 28 Jan 2020 10:58:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GreG5BRL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1ctD0lbu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14E2A2467E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CO2JG8N9D23HIOo5U+rFJ52rnB9AyFkUkw9lu9uxHZM=; b=GreG5BRLmAdxIRG1wuDEhW8UK CL2tgsf2xRrD2a9Ux3QTSRq03jRhIT9ujF14pQ1oLPekG4NH43+w+KQEjprTQhxnVPQho9NOoeSxv ZGtqdyv/Lr5UJu7LoxYh7GZFXO4/mH0Fso0qH0lnj/4X+7JahoAzJUxIAcMDwHSas9EvBhm3ouRM8 q7LEBhZJ7+/5oc67te2WOVam+bLpI7BGXt+EamJLkbWyRq/aITekT/m5LgrRQr6nzR53GKdbmK2+X 04iMsTOWM8OK5hdMbBGGE1StywBhYELtRoVubwPcbfcab4eMTMIB/gXd/+1StmIhfSIUhdmcgyM8Z dyqVAefRA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwOZn-00042Y-9r; Tue, 28 Jan 2020 10:58:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iwOZj-00042A-Th for linux-arm-kernel@lists.infradead.org; Tue, 28 Jan 2020 10:58:33 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 022272467B; Tue, 28 Jan 2020 10:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580209111; bh=fPIGD7bZiuPsICx66b+4r7EJxaT51+ZFDK7Fnb9seEk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1ctD0lburdWt3ZOtVj5XjYkEhuGI8R5O7+QvVol5aKA4A/kVC5guTaNEXrw4S+q7C ROcM5bCZuKIpf1xHbcixgP2r6MHVi4yBvKGo9D46PITetF2dNVQ29fOpZ1T4os+5tm 1AAyEH+The9/aovJDctEl2W6zefngSGCDwPsxEhU= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iwOZh-001naq-9h; Tue, 28 Jan 2020 10:58:29 +0000 MIME-Version: 1.0 Date: Tue, 28 Jan 2020 10:58:29 +0000 From: Marc Zyngier To: Makarand Pawagi Subject: Re: [PATCH] bus: fsl-mc: Add ACPI support for fsl-mc In-Reply-To: <1580198925-50411-1-git-send-email-makarand.pawagi@nxp.com> References: <1580198925-50411-1-git-send-email-makarand.pawagi@nxp.com> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/1.3.8 X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: makarand.pawagi@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux@armlinux.org.uk, jon@solid-run.com, cristian.sovaiala@nxp.com, laurentiu.tudor@nxp.com, ioana.ciornei@nxp.com, V.Sethi@nxp.com, calvin.johnson@nxp.com, pankaj.bansal@nxp.com, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, sudeep.holla@arm.com, rjw@rjwysocki.net, lenb@kernel.org, stuyoder@gmail.com, tglx@linutronix.de, jason@lakedaemon.net, shameerali.kolothum.thodi@huawei.com, will@kernel.org, robin.murphy@arm.com, nleeder@codeaurora.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200128_025832_000430_D5EC4800 X-CRM114-Status: GOOD ( 11.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: calvin.johnson@nxp.com, stuyoder@gmail.com, nleeder@codeaurora.org, ioana.ciornei@nxp.com, cristian.sovaiala@nxp.com, guohanjun@huawei.com, will@kernel.org, lorenzo.pieralisi@arm.com, pankaj.bansal@nxp.com, jon@solid-run.com, linux@armlinux.org.uk, linux-acpi@vger.kernel.org, lenb@kernel.org, jason@lakedaemon.net, V.Sethi@nxp.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, laurentiu.tudor@nxp.com, netdev@vger.kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, shameerali.kolothum.thodi@huawei.com, sudeep.holla@arm.com, robin.murphy@arm.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-01-28 08:08, Makarand Pawagi wrote: > ACPI support is added in the fsl-mc driver. Driver will parse > MC DSDT table to extract memory and other resorces. > > Interrupt (GIC ITS) information will be extracted from MADT table > by drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c. > > IORT table will be parsed to configure DMA. > > Signed-off-by: Makarand Pawagi > --- > drivers/acpi/arm64/iort.c | 53 +++++++++++++++++++++ > drivers/bus/fsl-mc/dprc-driver.c | 3 +- > drivers/bus/fsl-mc/fsl-mc-bus.c | 48 +++++++++++++------ > drivers/bus/fsl-mc/fsl-mc-msi.c | 10 +++- > drivers/bus/fsl-mc/fsl-mc-private.h | 4 +- > drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c | 71 > ++++++++++++++++++++++++++++- > include/linux/acpi_iort.h | 5 ++ > 7 files changed, 174 insertions(+), 20 deletions(-) A general comment when you do this kind of work: Do not write a single patch that impacts at least three different subsystems. As it is, it is unmergeable. Now the real question is *WHY* we need this kind of monstruosity? ACPI deals with PCI, not with exotic busses and whatnot. If you want to be creative, DT is your space. ACPI is designed to be plain and boring, and that's how we like it. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel