From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B532DC433EF for ; Mon, 13 Sep 2021 10:53:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4364C60E94 for ; Mon, 13 Sep 2021 10:53:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4364C60E94 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:50894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPjaX-0000qO-0M for qemu-devel@archiver.kernel.org; Mon, 13 Sep 2021 06:53:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPjWu-0005Vu-8H for qemu-devel@nongnu.org; Mon, 13 Sep 2021 06:49:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37150) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPjWr-0005u5-Gf for qemu-devel@nongnu.org; Mon, 13 Sep 2021 06:49:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631530176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I1AhIPlN7WObGHPi6a9hgo1HyBDCBGAv4fjr2k9jCY8=; b=PuoVDvVdA/EL8GaRqOvZVDLjnhSXJ2KzIZwnoIVQrjaxR5CJwiMhIaNQIOI4S4nFpkA69M QrXC0NxB1RtBhq5FK/M1yTl8VLCUbLQTNpKN1hWBR/5Do0lqtWMsBf2itgixcgeEdRHiUo H5HFUkC5Dg0nXyzGf8/7G/P3QrwgB/E= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590-W37t58yfMdqdnxSCBAeung-1; Mon, 13 Sep 2021 06:49:35 -0400 X-MC-Unique: W37t58yfMdqdnxSCBAeung-1 Received: by mail-wm1-f70.google.com with SMTP id y23-20020a05600c365700b003015b277f98so1200899wmq.2 for ; Mon, 13 Sep 2021 03:49:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=I1AhIPlN7WObGHPi6a9hgo1HyBDCBGAv4fjr2k9jCY8=; b=EQno7ox7Ioe97hIb8tIR0S/KmUHVIueFmBTZxCO80FLWvN8r3ccjdvl2U3VxfKCB+9 4UGdDnMpbRKkv/hPxcpFEei3drLX9bdk/qT54Khiu02hxH5QO0ZjIRdb3p4jN3H/WCpV E6BKtfjevIke2ypicIGDNWlWsNqY3Ms+qskccDd/etuXWW+zuK5Jq32kMmeDpIm3P2T5 9KuyTD+tcklPEeeS5E+4vfjpySAC+16iIxofaf3pkwpIML384yP3cDR+9iTyKNSq+Q+9 +GNbL4HdmpL+5E/OSjzTH1ZADd/fF6boHp/GvUo0Tce8jH5c2TVthZfuzK6f/sBa5Kgn LiSw== X-Gm-Message-State: AOAM533kKEgl6Thga8J45ANEzwU/9SENUs0guIUBEcucNtBloXc/0NEc ps7T2ZgnhTGhHCDcJs3yZ/8g9TdRKJ+t1JZpy+iAZs9plFm1FWVc9VFP2L8Wioep3E7zvz7JRiG JvSRns9kvkwkVHpw= X-Received: by 2002:a05:600c:1c9a:: with SMTP id k26mr1447172wms.106.1631530174284; Mon, 13 Sep 2021 03:49:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAgbOMMm6Lb/qvfRP1QYo8SitdNpzB4HjXq5wRXjr8GWQYf0+dFg4JFihjwy9+u8h6LzmmcA== X-Received: by 2002:a05:600c:1c9a:: with SMTP id k26mr1447155wms.106.1631530174114; Mon, 13 Sep 2021 03:49:34 -0700 (PDT) Received: from dresden.str.redhat.com ([2a02:908:1e42:9e20:fd73:7ee2:9975:24d9]) by smtp.gmail.com with ESMTPSA id q7sm1398313wru.56.2021.09.13.03.49.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Sep 2021 03:49:33 -0700 (PDT) Subject: Re: [PATCH v2 03/17] iotests: drop qemu_img_verbose() helper To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org References: <20210720113832.586428-1-vsementsov@virtuozzo.com> <20210720113832.586428-4-vsementsov@virtuozzo.com> From: Hanna Reitz Message-ID: Date: Mon, 13 Sep 2021 12:49:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210720113832.586428-4-vsementsov@virtuozzo.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=170.10.133.124; envelope-from=hreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -51 X-Spam_score: -5.2 X-Spam_bar: ----- X-Spam_report: (-5.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.969, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 20.07.21 13:38, Vladimir Sementsov-Ogievskiy wrote: > qemu_img_verbose() has a drawback of not going through generic > qemu_img_pipe_and_status(). qemu_img_verbose() is not very popular, so > update the only two users to qemu_img_log() and drop qemu_img_verbose() > at all. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > tests/qemu-iotests/044 | 5 +++-- > tests/qemu-iotests/044.out | 1 + > tests/qemu-iotests/209 | 7 ++++--- > tests/qemu-iotests/209.out | 2 ++ > tests/qemu-iotests/iotests.py | 8 -------- > 5 files changed, 10 insertions(+), 13 deletions(-) Reviewed-by: Hanna Reitz