From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F858C433F5 for ; Fri, 8 Oct 2021 06:44:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03FC261042 for ; Fri, 8 Oct 2021 06:44:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 03FC261042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9FFCE835EE; Fri, 8 Oct 2021 08:44:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="zxmofnn9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6A275835FE; Fri, 8 Oct 2021 08:44:16 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0EF3983601 for ; Fri, 8 Oct 2021 08:44:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=4915a58762=patrice.chotard@foss.st.com Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1984ZJAa016872; Fri, 8 Oct 2021 08:44:02 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=12aGcmsgypHwBtBhFWqxi1z9pvI9U82Lh1suOA89TBA=; b=zxmofnn9qxmIeov+HVF77rLqpWOls174vx/yJzYqA095ZjBR56bQLyhNltTZGNw5czT8 jHzpGUMI+tqBEGaWULB75Wzw8w3LN4z7dzDAxFlQkygYUamvAk+YJp3ip4d3KD0BYESi vHTvxJhXyiGar372wE4AbMKRVMc60JmOy3gIVyWxUPI6GqaKjIzIGOPx4LaHN2hq+A2H YysdOEF+TZJhVNzLOGuZPpupMrLQ5tY+5EMVQnPn9Zn3wA7zl4cQhouxxeeQs0Rwzox6 9EKV1qiiGvzaQHemoduDAoBk8RX3xaF0jX1GjYVsXkKLrW/q5ievR+XcojrIcBPu8ieS Fg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3bjdun90qf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Oct 2021 08:44:02 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3491910002A; Fri, 8 Oct 2021 08:44:02 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 2D558214D26; Fri, 8 Oct 2021 08:44:02 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.47) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 8 Oct 2021 08:44:01 +0200 Subject: Re: [PATCH v1 5/7] i2c: stm32f7: fix configuration of the digital filter To: CC: Patrick DELAUNAY , U-Boot STM32 , Heiko Schocher References: <20210803100515.29383-1-patrice.chotard@foss.st.com> <20210803100515.29383-6-patrice.chotard@foss.st.com> From: Patrice CHOTARD Message-ID: Date: Fri, 8 Oct 2021 08:44:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210803100515.29383-6-patrice.chotard@foss.st.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-08_02,2021-10-07_02,2020-04-07_01 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean HI On 8/3/21 12:05 PM, Patrice Chotard wrote: > From: Patrick Delaunay > > The digital filter related computation are present in the driver > however the programming of the filter within the IP is missing. > The maximum value for the DNF is wrong and should be 15 instead of 16. > > Signed-off-by: Patrick Delaunay > Signed-off-by: Patrice Chotard > --- > > drivers/i2c/stm32f7_i2c.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c > index e71a0e0aa3..7e6c65fadc 100644 > --- a/drivers/i2c/stm32f7_i2c.c > +++ b/drivers/i2c/stm32f7_i2c.c > @@ -45,6 +45,8 @@ struct stm32_i2c_regs { > > /* STM32 I2C control 1 */ > #define STM32_I2C_CR1_ANFOFF BIT(12) > +#define STM32_I2C_CR1_DNF_MASK GENMASK(11, 8) > +#define STM32_I2C_CR1_DNF(n) (((n) & 0xf) << 8) > #define STM32_I2C_CR1_ERRIE BIT(7) > #define STM32_I2C_CR1_TCIE BIT(6) > #define STM32_I2C_CR1_STOPIE BIT(5) > @@ -106,7 +108,7 @@ struct stm32_i2c_regs { > #define STM32_I2C_MAX_LEN 0xff > > #define STM32_I2C_DNF_DEFAULT 0 > -#define STM32_I2C_DNF_MAX 16 > +#define STM32_I2C_DNF_MAX 15 > > #define STM32_I2C_ANALOG_FILTER_DELAY_MIN 50 /* ns */ > #define STM32_I2C_ANALOG_FILTER_DELAY_MAX 260 /* ns */ > @@ -155,7 +157,7 @@ struct stm32_i2c_spec { > * @clock_src: I2C clock source frequency (Hz) > * @rise_time: Rise time (ns) > * @fall_time: Fall time (ns) > - * @dnf: Digital filter coefficient (0-16) > + * @dnf: value of digital filter to apply > * @analog_filter: Analog filter delay (On/Off) > */ > struct stm32_i2c_setup { > @@ -842,6 +844,10 @@ static int stm32_i2c_hw_config(struct stm32_i2c_priv *i2c_priv) > else > setbits_le32(®s->cr1, STM32_I2C_CR1_ANFOFF); > > + /* Program the Digital Filter */ > + clrsetbits_le32(®s->cr1, STM32_I2C_CR1_DNF_MASK, > + STM32_I2C_CR1_DNF(i2c_priv->setup.dnf)); > + > setbits_le32(®s->cr1, STM32_I2C_CR1_PE); > > return 0; > Applied on u-boot-stm32 for next Thanks Patrice