From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yishai Hadas Subject: Re: [PATCH rdma-core 1/2] mlx5: Use non-cached mapping when Blueflame is not used Date: Mon, 30 Oct 2017 18:31:12 +0200 Message-ID: References: <1509282070-1391-1-git-send-email-yishaih@mellanox.com> <1509282070-1391-2-git-send-email-yishaih@mellanox.com> <20171029173344.GA4488@ziepe.ca> <6531033a-9d61-bbca-ac14-46b05973610c@dev.mellanox.co.il> <20171030145726.GB12392@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171030145726.GB12392-uk2M96/98Pc@public.gmane.org> Content-Language: en-US Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Yishai Hadas , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lariel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 10/30/2017 4:57 PM, Jason Gunthorpe wrote: > On Sun, Oct 29, 2017 at 11:26:04PM +0200, Yishai Hadas wrote: >>>> @@ -632,6 +632,11 @@ enum mlx5dv_set_ctx_attr_type { >>>> MLX5DV_CTX_ATTR_BUF_ALLOCATORS = 1, >>>> }; >>>> +enum { >>>> + MLX5_MMAP_GET_REGULAR_PAGES_CMD = 0, >>>> + MLX5_MMAP_GET_NC_PAGES_CMD = 3, >>>> +}; >>>> + >>> >>> These are added to a public header, but I couldn't see where they >>> would get used by a DV user?? >> >> A DV user already had access to the mlx5 mmap command before this series by >> using the mlx5dv_get_qp() API: >> qp_out->uar_mmap_offset = mqp->bf->uar_mmap_offset; > > Okay. > > As long as existing users can reasonably be expected to handle this > new value in the uar_mmap_offset output field... > Yes, we expect existing users to work properly. This output field was exposed by the DV API to enable re-mmap of the UAR address by a secondary process by using the same 'uar_mmap_offset' regardless its internal command value. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html