From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 12 Nov 2018 12:57:44 +0100 Subject: [U-Boot] [PATCH v1 2/2] imx: mkimage: add size check to the u-boot.imx make target In-Reply-To: <1541774132.6873.30.camel@toradex.com> References: <20181107223947.31783-1-marcel@ziswiler.com> <20181107223947.31783-2-marcel@ziswiler.com> <2db259f4-4e40-cbdc-8b6d-f0f571659eb9@denx.de> <1541774132.6873.30.camel@toradex.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/11/18 15:35, Marcel Ziswiler wrote: > Hi Stefano > > On Thu, 2018-11-08 at 15:07 +0100, Stefano Babic wrote: >> Hi Marcel, >> >> On 08/11/18 02:55, Fabio Estevam wrote: >>> [Adding Stefano] >>> >>> On Wed, Nov 7, 2018 at 8:41 PM Marcel Ziswiler >>> wrote: >>>> >>>> From: Marcel Ziswiler >>>> >>>> The make macro to check if the binary exceeds the board size >>>> limit is >>>> taken straight from the root Makefile. >>>> >>>> Without this and e.g. enabled EFI Vybrid fails booting as the >>>> regular >>>> size limit check does not take the final u-boot.imx binary size >>>> into >>>> account which is bigger due to alignment as well as IMX header >>>> stuff. >>>> >>>> Signed-off-by: Marcel Ziswiler >>> >>> Reviewed-by: Fabio Estevam >>> >>> Hi Stefano, maybe this could be material for 2018.11? >>> >> >> Added both patches to u-boot-imx, check is effective, now size is too >> much and build fails: >> >> >> Building current source for 1 boards (1 thread, 8 jobs per thread) >> arm: + colibri_vf >> +u-boot.imx exceeds file size limit: >> + limit: 520192 bytes >> + actual: 526104 bytes >> + excess: 5912 bytes >> +make[2]: *** [u-boot.imx] Error 1 >> +make[1]: *** [u-boot.imx] Error 2 >> +make: *** [sub-make] Error 2 >> 0 0 1 /1 colibri_vf >> >> Can you take a look ? > > I sent a v2 additionally dropping CONFIG_CMDLINE_EDITING and SPI > support saving another 8 Kb which for me makes it work right back to > GCC 6.1.1 which I believe is anyway about as far back as one can go > even compiling U-Boot. Can you please give that another go? Merged the patchset, it works in my build. I will send PR to Tom. Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================