All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 1/3] meson: Only build virtfs-proxy-helper if all requisites are found
Date: Tue, 25 May 2021 16:19:29 -0700	[thread overview]
Message-ID: <d8f7c01c-7dc8-1ba2-d29c-6babf75f137e@linaro.org> (raw)
In-Reply-To: <20210525104648.4060904-2-philmd@redhat.com>

On 5/25/21 3:46 AM, Philippe Mathieu-Daudé wrote:
> We first set have_virtfs_proxy_helper depending on have_virtfs,
> then update have_virtfs... While this might work, it is not clear
> when looking at the code logic. Move the have_virtfs_proxy_helper
> assignation*after*  updating have_virtfs to make it obvious.
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@redhat.com>
> ---
>   meson.build | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2021-05-25 23:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25 10:46 [PATCH 0/3] meson: Minor improvements Philippe Mathieu-Daudé
2021-05-25 10:46 ` [PATCH 1/3] meson: Only build virtfs-proxy-helper if all requisites are found Philippe Mathieu-Daudé
2021-05-25 23:19   ` Richard Henderson [this message]
2021-05-25 10:46 ` [PATCH 2/3] meson: List if X11 dependency is detected Philippe Mathieu-Daudé
2021-05-25 23:19   ` Richard Henderson
2021-05-25 10:46 ` [PATCH 3/3] meson: List modules built in summary Philippe Mathieu-Daudé
2021-05-26  7:29   ` Philippe Mathieu-Daudé
2021-05-27 20:08   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8f7c01c-7dc8-1ba2-d29c-6babf75f137e@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.