All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <yujie.liu@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] clk: expand clk_ignore_unused mechanism to keep only a few clks on
Date: Thu, 19 Aug 2021 16:05:43 +0800	[thread overview]
Message-ID: <d8fc2606-5dd3-62b4-32c0-fe2f8ebcd0ad@intel.com> (raw)
In-Reply-To: <20210818160457.320598-1-u.kleine-koenig@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 3843 bytes --]

Hi Uwe,

I love your patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on linux/master linus/master v5.14-rc6 
next-20210818]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: 
https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/clk-expand-clk_ignore_unused-mechanism-to-keep-only-a-few-clks-on/20210819-000800
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git 
clk-next
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
compiler: xtensa-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

 >> drivers/clk/clk.c:1315:12: warning: Expression is always false 
because 'else if' condition matches previous condition at line 1312. 
[multiCondition]
     } else if (clk_ignore_unused) {
               ^

vim +1315 drivers/clk/clk.c

7ec986efed0208c Dong Aisheng     2016-06-30  1307
564f86d384755e3 Rasmus Villemoes 2019-10-04  1308  static int __init 
clk_disable_unused(void)
7ec986efed0208c Dong Aisheng     2016-06-30  1309  {
7ec986efed0208c Dong Aisheng     2016-06-30  1310  	struct clk_core *core;
7ec986efed0208c Dong Aisheng     2016-06-30  1311
7ec986efed0208c Dong Aisheng     2016-06-30 @1312  	if (clk_ignore_unused) {
7ec986efed0208c Dong Aisheng     2016-06-30  1313  		pr_warn("clk: Not 
disabling unused clocks\n");
7ec986efed0208c Dong Aisheng     2016-06-30  1314  		return 0;
bef2d694904f8db Uwe Kleine-König 2021-08-18 @1315  	} else if 
(clk_ignore_unused) {
bef2d694904f8db Uwe Kleine-König 2021-08-18  1316  		pr_warn("clk: Not 
disabling %u unused clocks\n", clk_ignore_unused);
7ec986efed0208c Dong Aisheng     2016-06-30  1317  	}
7ec986efed0208c Dong Aisheng     2016-06-30  1318
7ec986efed0208c Dong Aisheng     2016-06-30  1319  	clk_prepare_lock();
7ec986efed0208c Dong Aisheng     2016-06-30  1320
7ec986efed0208c Dong Aisheng     2016-06-30  1321 
hlist_for_each_entry(core, &clk_root_list, child_node)
7ec986efed0208c Dong Aisheng     2016-06-30  1322  	 
clk_disable_unused_subtree(core);
7ec986efed0208c Dong Aisheng     2016-06-30  1323
7ec986efed0208c Dong Aisheng     2016-06-30  1324 
hlist_for_each_entry(core, &clk_orphan_list, child_node)
7ec986efed0208c Dong Aisheng     2016-06-30  1325  	 
clk_disable_unused_subtree(core);
7ec986efed0208c Dong Aisheng     2016-06-30  1326
7ec986efed0208c Dong Aisheng     2016-06-30  1327 
hlist_for_each_entry(core, &clk_root_list, child_node)
7ec986efed0208c Dong Aisheng     2016-06-30  1328  	 
clk_unprepare_unused_subtree(core);
7ec986efed0208c Dong Aisheng     2016-06-30  1329
7ec986efed0208c Dong Aisheng     2016-06-30  1330 
hlist_for_each_entry(core, &clk_orphan_list, child_node)
7ec986efed0208c Dong Aisheng     2016-06-30  1331  	 
clk_unprepare_unused_subtree(core);
7ec986efed0208c Dong Aisheng     2016-06-30  1332
7ec986efed0208c Dong Aisheng     2016-06-30  1333  	clk_prepare_unlock();
7ec986efed0208c Dong Aisheng     2016-06-30  1334
7ec986efed0208c Dong Aisheng     2016-06-30  1335  	return 0;
7ec986efed0208c Dong Aisheng     2016-06-30  1336  }
7ec986efed0208c Dong Aisheng     2016-06-30  1337 
late_initcall_sync(clk_disable_unused);
7ec986efed0208c Dong Aisheng     2016-06-30  1338

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org

  reply	other threads:[~2021-08-19  8:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 16:04 [PATCH] clk: expand clk_ignore_unused mechanism to keep only a few clks on Uwe Kleine-König
2021-08-19  8:05 ` kernel test robot [this message]
2021-08-18 23:27 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8fc2606-5dd3-62b4-32c0-fe2f8ebcd0ad@intel.com \
    --to=yujie.liu@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.