From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2906BC54E5D for ; Thu, 14 Mar 2024 18:16:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55A70800D7; Thu, 14 Mar 2024 14:16:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50881800B4; Thu, 14 Mar 2024 14:16:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35B84800D7; Thu, 14 Mar 2024 14:16:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 22797800B4 for ; Thu, 14 Mar 2024 14:16:17 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 856031C05FE for ; Thu, 14 Mar 2024 18:16:16 +0000 (UTC) X-FDA: 81896449152.23.E4D3536 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf03.hostedemail.com (Postfix) with ESMTP id 5157820015 for ; Thu, 14 Mar 2024 18:16:13 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=cv8cl9Ez; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=kvBLVfcm; spf=pass (imf03.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1710440173; a=rsa-sha256; cv=pass; b=zlS7UWojVYvW0tIv9zYTvh56/3SbNshr15C0+AThTfG1vpfeOxdu3oN1vpA9rofMQ6tGNY Vx5KTHNq76g4RbeuEQrk3rGhC/EnJucsOKGhmusaHT+GWmEsLqms84xiF5b7xRWQRTfTNE WkjF1zMObCxD+FMxlEcu6nYDHLcrKgo= ARC-Authentication-Results: i=2; imf03.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=cv8cl9Ez; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=kvBLVfcm; spf=pass (imf03.hostedemail.com: domain of jane.chu@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=jane.chu@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710440173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cH6BOUyMtfM8o5dNMDEDXQIwt+ByT1erXGrzxpDcRVA=; b=l7OMwHUIreX8KB64hXhwibavW3fUG/kBXmE1fKPOyfk/opZok1SHtNizJ5Ze1rPn10CXev ZzXSGZjdLJTRz0yWnL72+e1NU/8/JM8BHMCtuO8TbhEh8koGfQwcKCVQkl0dCWcbzfOJbD /5Gnef2Vg6/o7CzwQV9Gco4Q6/c/JcM= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42ECLwcK009397; Thu, 14 Mar 2024 18:16:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=cH6BOUyMtfM8o5dNMDEDXQIwt+ByT1erXGrzxpDcRVA=; b=cv8cl9EzXPCmEv2pB3YEChaEtYn8puBVB6vkm6QpOqKJ0/4K1TnP3XrC/n9XupUHClKv DGLFgfqfVPEKYX0em7xfDfzUp40XgzE7NyWlxndAfpCckeTjmnrBgSLXkAOWda67aVPb ean6iVO1+gmRNRl9Lv7lbg4AaY6SY9h6mjvKtZNihriea9UFyv3XRq3Qy0ODvL+jCBLX OXMz6amQGgIMaazCW5oCA4aXj5wx41iLp9+OsXvry14PcRCIhIwFnUPFA3a2mkB+QKGl dHxK+0B1gmXniqOhS6tBtbgTmOwvN1bJgI2Ke9t/g395VH8QHLKGXEeXC0JBHaRZ8mpe Eg== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wv0ac0y36-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Mar 2024 18:16:01 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 42EHAfPu004803; Thu, 14 Mar 2024 18:16:00 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2169.outbound.protection.outlook.com [104.47.55.169]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3wre7b5f12-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Mar 2024 18:16:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=myWhNwndYNhQNQkx5ABLym+X/Ao7xlDd01BCCdl2AHhnTGbX4iYpBZmTqtF00FYd+84LzmbHlgJ73DZ0e2nGqKQlOEi8XvBQj/hvXDToeKppHDUquwnBnVLJCgUhcB6kuGL+gt3H9WPKcai6EUqS+DKCVz8DGzN41QwWgN6x9pRbqEW5nXeVyfDeD4ZPAtOgvEBoJ60x6a7pog+7M700+GVVAQpVGy4gdPOZNoZtnvK3JxNwweOXgkJFWrMCvNvTnRL7R01TtoU6E+ee5kTRA58U5Qymp+SFs3W3ZxguWhOCMwPGl3fu4SaRqA4C/tonnOQ3X9zUi5NekgkYlYRJNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cH6BOUyMtfM8o5dNMDEDXQIwt+ByT1erXGrzxpDcRVA=; b=NbXvdsWduuHTH4blX+QFS0EAbYaQZ98uCGIUy65sG4TqxrWfdWBSudPzn2aZ69E2abUp4awqIQdKnJYz7q779Yo+v8+fh4guyyuF388bDIQL26/DG6XyrxD/sfdUy1NKO21f97dBTTf00JflC1mgJotczkGtIwmy7pWEFirNJgaz+pUtmt9QvaNbiX83QUk8vouLPVYOS5VOGUWfEVi684DYyMNiQlk38Hr3B51ZOvBtICbQlEzpbAQMP4bACcu/yBC3Y+ofwR67Of4zJuVGRxzgg9DByd6zwS1lM3eY3DDnh8wAu7Z2NtXU1YstkkDyTKfpGvaFmAuORtes86yduQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cH6BOUyMtfM8o5dNMDEDXQIwt+ByT1erXGrzxpDcRVA=; b=kvBLVfcmDjYieethWEv2aKxIT7xYuVRfwrQnK+zyOo3Yao/pT2zJgvnJNrGnc14vhnQvcZ6uaYsIMVWDtMnV/j6yGLrv8zP+ona9Iy7wxAPcRFM4Cyn5qgy4BlvEjXvpsyc7nYKa9buEjVduzTsPCZcb5bxhR+UJ7V1bwAdO7MY= Received: from SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) by IA1PR10MB6856.namprd10.prod.outlook.com (2603:10b6:208:423::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.20; Thu, 14 Mar 2024 18:15:57 +0000 Received: from SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::210e:eea7:3142:6088]) by SJ0PR10MB4429.namprd10.prod.outlook.com ([fe80::210e:eea7:3142:6088%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 18:15:57 +0000 Message-ID: Date: Thu, 14 Mar 2024 11:15:55 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] mm/memory-failure: Convert memory_failure() to use a folio Content-Language: en-US To: Miaohe Lin , Matthew Wilcox Cc: linux-mm@kvack.org, Naoya Horiguchi , Andrew Morton , ak@linux.intel.com References: <20240229212036.2160900-1-willy@infradead.org> <20240229212036.2160900-7-willy@infradead.org> <5eab08d7-ae38-4f99-401f-f361466e34e0@huawei.com> <196d00e3-4335-4f8f-ac51-5ccfa5ef5f75@oracle.com> From: Jane Chu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BYAPR21CA0010.namprd21.prod.outlook.com (2603:10b6:a03:114::20) To SJ0PR10MB4429.namprd10.prod.outlook.com (2603:10b6:a03:2d1::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB4429:EE_|IA1PR10MB6856:EE_ X-MS-Office365-Filtering-Correlation-Id: b5bd4b65-4d2d-41fc-7ee5-08dc4452cb77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SWQY1RpdFpn8EQcqbw7S88HgzIvxBTGX5fMmMp+qcbWV51yyPPzCNN+IUgj9UuG7GyZGPHC2Tps2NJR9uusZaAAnG3QTSALRuBRAtZNOlNbrvvH1lnLbNqcZ8MaAV4JyTIcTuSovEu0S5mpLqEBVw5V5pHf46itZXCTuhrWnRQbdAsYUyiJTD5wwP8UJpdjtKP7ve/11jVhlWavK6c7/KCtAZkw/tXUNe7xWJRasckX9vJNMIWAQeqRhJPRrPJy6NpQxl4AUZ+u1VTNjXT8NBNtwpQF/wWCpilsd4njkfP+SfwGM85mgBrzmjM+G7IFGcnw9WLJFO5IInIU+swdQQvUaLjHArtMXZjpfHvhC38U2ZcJh62xvwxxGB6d9TxDSRtry2mmxY9agKoojf0txtTjM+U20ONS2wNiSVIJsSjweaiZYTXrYQ1k3fPS5BEAuXSRtGrmvgdrVe8+FZR8BsnPZ7m/n+yxkrqouf7Ug0SNwtrV7YDcB4fhFq0+PRT+RIhbOhmikhjeu7vbPdMaCcglaOvS14rtO61WOfifeYNr1DBQoBOKfM9XlPOLuRyZmMKHclev9HkD3kbkHdFtjExjto8og1Pa0gRUlhS6ehV8ue128Y84EsSqvlczCSJkmd/4+vfY8cNo7R9v1vd+uuqwlqVjQ2xcGtxnfREPGc1E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB4429.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzJteVUvWkhET2t2Z2JTV3ROY0t4b2hzZVFEVXNhVXJzZnBKTktDeFBSY3pu?= =?utf-8?B?Z1RsWCtuNzVIMDNqMjcxMDBQK1RZZWtrVHpCZ1d4NkNCQzZWOEhidGQ5T3h3?= =?utf-8?B?MGo3L3gvdzBVcGN3YXltQ1pUdWxiTUwvbUtSTmk4TUxQRFQvM0ZzR3U5eGZM?= =?utf-8?B?ck1RTTkwdVh3eHFoYjZIelA2YzQwaXNqb0w3NTZCV0VESC8zQlIySXFmSCtJ?= =?utf-8?B?dXo4NG51NDhzek91Mng1c2NwSW9aMnBFaXFEZnhUc1VoMVNTK2ZkbzdoSjZT?= =?utf-8?B?Y1dHZTczZVZUUXlUalVMVmgveEtFV2hETWVvZVdZZEFwZ01oVVR3VGN5Y2RD?= =?utf-8?B?WTNPU2F6bjJxMXUrWVQ0dVFVa3NWTnFJWXN4ODZjcXZqRWFHcUt1WTFIRmw5?= =?utf-8?B?cTlKMjBYNUpYVzVSdWp4RUNVS1dHNVRncWlQYUZwekMwc0o5OEppNG1lUDBn?= =?utf-8?B?aTBDY1kyRHhWUXpxOFVpeXZjWVc5clRleFRVSXdhV2VkV3pZSkRFNVkya0w3?= =?utf-8?B?bW12a0s1eHNIazZ0VUExNWpYUVBIdmpoaWFhL2c1TWxMbE1QZXJBK3J0b0pE?= =?utf-8?B?OTdST0IvSldlbmh5UEJGSzVMNWZ4L0hOZkhDcjcyS3RBenZEQjJtSkw5S0NW?= =?utf-8?B?S1RTenFySVRPL1JHM3hQTjJzL0xMWXF3WWxaamxGYTFiaVNaVGFUOWlLOEUv?= =?utf-8?B?S0FsMk5vN0c2OUJ4Tlh5V2hPTGFSWFBwbWdaY21BbjRjcDVJWUxac0J0K0NU?= =?utf-8?B?dE44YW1JcDRvdFFkZ3V4N2Q1UjZqWHNKRzgwNzQ1bkxLQ2VLM2NDaFlkS2Yw?= =?utf-8?B?a1IzeXFQT1lrS3FHakNVck9tR3pVV21XS0xJRkF4L1JKMENEUVJDcVFQMlQ1?= =?utf-8?B?L2N2c0UvWUlPY256Qm51c2ZBNGJMaTBlRlY1RVJ3ejV6MlZaMEZ1WnhJWTEy?= =?utf-8?B?bG9XdExqeGNEZTdpVU95eHAzdlhTblVPV2Y5Q3AxNjVyalVodXZjTGFQdysy?= =?utf-8?B?VGYyT3ZMTE8yZWh1M1R3d0hCbURwRzRtK0I0VmlJZU9YK1FyM2VwM0FEVjhJ?= =?utf-8?B?aTFZRC9aMUZYSVI2NVVFM09SeVNwUkszNk01eXhXSGszWW5xLytYOW1ZT3Er?= =?utf-8?B?NVJFNnJHWEhBSE9xTVMybGN5QzFkUHhrWEJWWFduS2x3NTc3bldZTVpVV1VB?= =?utf-8?B?dnJiUmtqMFNpNkc4SzJwTml0Rko0Tm1YMVBBZ2p5YzI2WFFEQnhNeFA1bk9Z?= =?utf-8?B?NWtjY2VyWFNoUmVEQk1BWTNsNjJuL2NhcmVvQzV5cFhsNGg0MTE3Q0ZlU2FB?= =?utf-8?B?NVpBbHdSSkdjMVR6V2hTS2tTTUJENjVGd1VDVXA4VTZFSThtblBNNExPMFZR?= =?utf-8?B?b01vWitTVThPWWk3cFY3dGtHbTVyR1BmVEFUM1pGd0RneFRlR2FGWE9Ga1Bs?= =?utf-8?B?M3BEcDRsRk1QNFE3WGlUOFhKMWZMVjZvSHRqTmdkTWQrdGhEd0x3ekc0Z0dm?= =?utf-8?B?d3NMTElKZzBqQWNpc0JLUVgxNjR1V2RGM2liK252SVpVc0dCSGpmU1diYWdJ?= =?utf-8?B?RmJ5T05icS92eHRmdEhCbEFtazdrWTZKNUhaTWR4VWhKeWd1azhIVzFDVzR1?= =?utf-8?B?a1NrSy8vaGxrd0ZxR3lOekdjejN3Q0NKYnNTZk5RMnQ1Vm1RTjdGM0plM2ZD?= =?utf-8?B?WnEwR1lOOWIwUEprQnhJWkhxbHZnNUFVT2JXWi85bkJGK3pHZ1pUYUNVZXkz?= =?utf-8?B?ZzZCZ0VMakx3Mno5bTNHd2ZSRHAvTDJtQzJkVXllMmFLMzZpU0swN21IREcr?= =?utf-8?B?SXZzQWdjUXRqaDMrellEck5sNy9HSk5wbHhzNm9EcDhreHBNcUpwWXJMUGxF?= =?utf-8?B?WWFmaXFHekxoU0p6QmRmRkJOVThmR0Y1QmE5ampnN0hwSlk0ZlY0YkdXTlA1?= =?utf-8?B?SUlOek9JV0h0VENBeUNPbjRoN3VFbHlnbFoyS0RKNjNlOEpoWUFGTE9TYlRW?= =?utf-8?B?OHg0M3ZrcStpQnRwQlVud241MlpRMk1xWUJwcXF3Z2lKQUZPbGpWaGhDYVdq?= =?utf-8?B?azdWL0IyME82RENIMjA2a2lvcU9vcDl0bVVxOW1XVlQrN25DT1ZuNUVvMEQw?= =?utf-8?Q?p5COUU4FQROTl6+9MY+NOaIok?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZxUDQV2ePFNKCOe5RE3bnHlMOKwAr/xEVjIqCyfYseP3Y2eVCauRV6dj0gsyjIW8O8M9Kn2TanxXd0TCRbIrxCJXwlVlie7L16EDFTyPMIc7TX9GQ47hD0/EoVsKcKUa9uBY/s6LphIzH65LVykHMrzEDToo5mELh2QiaETY1aqm8m5lFAPrH1rHCG9uh94FEi6OdcRK1YvZvxUDUT7oAjBDcWVzAG+9IGbI54OCFNIFTqmkr4V/EtHSITmpgJWw4n4UZ8l1yyjNy7m/DBJsellg/HbtuBODfddsM9GFJNQ7nM3eag9XQIexsuJzxVr2AoQRJpR84mdXdFV3OETnfLD/dimsnLNalAsg6347O9Jdjyouu+qKbbt3kitxkpwVW4gZPPBZdSBm6AIjuxC8RXCFRQGFY/oqdgLkyUi3N8ccbN37yLcDW99VgSIQTESn9v2NncV8xVh66nHrT+6laotCSC6B9JdA6nm80rJAzpKdH8JmhhZZ36I47yL6NWcsnzc9MNjpTNhWA33xJoQwyEuexX8Md1G2tQE6rfQRz3crix8Kr7jyXx3EK/ws93hOqNg0vmUhReFIZNhFgY9ft7o8WYNGB7TgbTRT9Q13oh0= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5bd4b65-4d2d-41fc-7ee5-08dc4452cb77 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 18:15:57.2980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZpJZzaDb6wp6F4X5yDLcPNvO1+fY5PvEtXqXcERV/E8scElWpmxUX3bOEu6qqVYH5yk6WpGQDVrLhUDdT2ONDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6856 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-14_13,2024-03-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403140139 X-Proofpoint-GUID: ybdHAmfpiKGGyJs0Q8af1kJk4ssvbtp9 X-Proofpoint-ORIG-GUID: ybdHAmfpiKGGyJs0Q8af1kJk4ssvbtp9 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5157820015 X-Stat-Signature: 1jzry1xjiwnajchhnzdi5kp6gzty4sd9 X-Rspam-User: X-HE-Tag: 1710440173-205265 X-HE-Meta: U2FsdGVkX190vJ0v9IBBkxQmKe/EdOVn4GRcLh3Wg7yEBjvC4+b8l4HgSKlIU3yJ1AA23RHhy6WODfjXpWBx3B/QvkoyhKlyoYcCcFwtYbyQTx/sLnUjLlpV3zUfU9oGIysgKiYqd5METJ5EPL8C7LXhJYl4WHiSqjkpkFBImj4WJ+bOAP8y5eohPtprZQXjpq3yE0LKTYwHTI9BRD7eqLdeAWQ2nFf5ib4GbPxH6zVXJfCU6ty7EbUOXZoJ0SQhdczn5UAXdPAGmJR6QX3FrkhKgNB98MsH0l3NO9FlEJodPL3DDcfNIDqByFLJl40VyobXqtT8RenUUcdE6DpFMDBfZgAoYDAcDXkC+pW2wW3ME801iEMddNAtkZgH60osTtKOD+ZjCsM5habnU2K02Ek/BoETSApdhzl8y9wE4/jdWLUY6bCoJChDaaNEgOkSH5H/VSJdkJ1qMdsSXvTXcWCkCDglmruV9qJA25ctLmZ2NwWCVglSv+lFRlwKWKyZy98/qsCbKOUMhkcHnFZwxQIae7X7nhg6znFbUrYxmVFRzdmp5US3vYs3RhrMGQA5Md0xYvOvLGntGihdhrR4BnHSua2indrqTmIjDgms4suT+TnigJwbqDufksWOIpL/j40nOeKFrQCvA6VrvmulsrWVo/rfSfye/oDtIdNQXbe+EN5jYN+gC2+hZLvFFsn5SpITCGK8MjdVeXN6ZEiHiFVG9B+qewJ5tw38lcWzQnfltO7N6mUAV0y0jTfHfcnyrWjDYQsiJwRLmoOslbh4zLggJJ4r3xoPrrevkjhGfU3lM0rt0FExjv3DufttUJ/Lng0hTze5xwJk4y/o7XQOscWs4/i+4UCJHuNYkpEYE9T0IbKIGKUJw0Q6xjIZfzMi8rQip6UFLXPrlqqrGoP7M8KhW/IXpR57U6+ZwYLr1UACyTU0jH7vbGBqeKdvi0xHaJcuTDKQc+zlzgdmedm bnMc7PeF 3Og0c2+HBzYpVRlh3STrxiERkRZQNh1vf+Z07OSxeE7KCJ3lTBEK76f8U3C/D7r/pfd5vQt5QHuhhVW/lnNSfKITfPKdJtMlwfP6gWM72K8fGI/i/vSK0f/07x2u9OVEeU57D X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/13/2024 7:34 PM, Miaohe Lin wrote: > On 2024/3/13 9:23, Jane Chu wrote: >> On 3/12/2024 7:14 AM, Matthew Wilcox wrote: >> >>> On Tue, Mar 12, 2024 at 03:07:39PM +0800, Miaohe Lin wrote: >>>> On 2024/3/11 20:31, Matthew Wilcox wrote: >>>>> Assuming we have a refcount on this page so it can't be simultaneously >>>>> split/freed/whatever, these three sequences are equivalent: >>>> If page is stable after page refcnt is held, I agree below three sequences are equivalent. >>>> >>>>> 1    if (PageCompound(p)) >>>>> >>>>> 2    struct page *head = compound_head(p); >>>>> 2    if (PageHead(head)) >>>>> >>>>> 3    struct folio *folio = page_folio(p); >>>>> 3    if (folio_test_large(folio)) >>>>> >>>>> . >>>>> >>>> But please see below commit: >>>> >>>> """ >>>> commit f37d4298aa7f8b74395aa13c728677e2ed86fdaf >>>> Author: Andi Kleen >>>> Date:   Wed Aug 6 16:06:49 2014 -0700 >>>> >>>>      hwpoison: fix race with changing page during offlining >>>> >>>>      When a hwpoison page is locked it could change state due to parallel >>>>      modifications.  The original compound page can be torn down and then >>>>      this 4k page becomes part of a differently-size compound page is is a >>>>      standalone regular page. >>>> >>>>      Check after the lock if the page is still the same compound page. >>> I can't speak to what the rules were ten years ago, but this is not >>> true now.  Compound pages cannot be split if you hold a refcount. >>> Since we don't track a per-page refcount, we wouldn't know which of >>> the split pages to give the excess refcount to. >> I noticed this recently >> >>  * GUP pin and PG_locked transferred to @page. Rest subpages can be freed if >>  * they are not mapped. >>  * >>  * Returns 0 if the hugepage is split successfully. >>  * Returns -EBUSY if the page is pinned or if anon_vma disappeared from under >>  * us. >>  */ >> int split_huge_page_to_list(struct page *page, struct list_head *list) >> { >> >> I have a test case with poisoned shmem THP page that was mlocked and >> >> GUP pinned (FOLL_LONGTERM|FOLL_WRITE), but the split succeeded. > Thanks for points this out. Compound pages can be split even if extra refcnt is held. So folio_test_large > check is not stable if we hold a refcnt now? Will it introduce some obscure races? > > Except from that, I think a page cannot become a subpage of a THP when extra refcnt is held now. So below code can be removed. > Any thought? > > /* > * We're only intended to deal with the non-Compound page here. > * However, the page could have changed compound pages due to > * race window. If this happens, we could try again to hopefully > * handle the page next round. > */ > if (PageCompound(p)) { > if (retry) { > ClearPageHWPoison(p); > unlock_page(p); > put_page(p); > flags &= ~MF_COUNT_INCREASED; > retry = false; > goto try_again; > } > res = action_result(pfn, MF_MSG_DIFFERENT_COMPOUND, MF_IGNORED); > goto unlock_page; > } Not sure of what scenario it was meant to deal with.  How about adding a warning instead of removal? It'll be interesting to see how the warning got triggered. But if after a while nothing happens, then remove it. thanks! -jane > > Thanks. > >> thanks, >> >> -jane >> >> .