From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D6A5C2B9F4 for ; Tue, 22 Jun 2021 21:39:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 403C76128E for ; Tue, 22 Jun 2021 21:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229625AbhFVVlU (ORCPT ); Tue, 22 Jun 2021 17:41:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:37576 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbhFVVlU (ORCPT ); Tue, 22 Jun 2021 17:41:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5767161042; Tue, 22 Jun 2021 21:39:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624397943; bh=pptQ00AoHqZUrezNXW2i/eMLGj8TwQiqhCcPQ+pubZw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=p6t2lfWg1F4oMbMl9k0/5T2fOBLGI7WaMACmuDE/uvKBsKG1FOARxSWH2xlvrme+2 2vLEG1BEhXtoJUIcW04e3r99mz8pYqrQXuakIrBeCcUATVTQxtLbNtskU/XbuS5w5/ rzmXfsyoU9cp07854RYe4ijqwROlrkZ2Cs5+ZA/5NP0hBU4pyAc11n50Gcxa8F5p7r e8EMMlUwR9zMHgt4CCYclDueSf9s/+6I5juuc84cZsRLuW9rEtdrC+JCz27+L/z8mE Otg2ZKtU9I894kY184+i27dXBFCBNsr+KXnPXBT3QMmbflYELd79ex5/i38qlElmQl VbxIy9FXedKiQ== Message-ID: Subject: Re: [PATCH net-next] net/mlx5: Use cpumask_available() in mlx5_eq_create_generic() From: Saeed Mahameed To: Nathan Chancellor , Leon Romanovsky , "David S. Miller" , Jakub Kicinski Cc: Nick Desaulniers , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Date: Tue, 22 Jun 2021 14:39:02 -0700 In-Reply-To: <20210618000358.2402567-1-nathan@kernel.org> References: <20210618000358.2402567-1-nathan@kernel.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.2 (3.40.2-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, 2021-06-17 at 17:03 -0700, Nathan Chancellor wrote: > When CONFIG_CPUMASK_OFFSTACK is unset, cpumask_var_t is not a pointer > but a single element array, meaning its address in a structure cannot > be > NULL as long as it is not the first element, which it is not. This > results in a clang warning: > > drivers/net/ethernet/mellanox/mlx5/core/eq.c:715:14: warning: address > of > array 'param->affinity' will always evaluate to 'true' > [-Wpointer-bool-conversion] >         if (!param->affinity) >             ~~~~~~~~^~~~~~~~ > 1 warning generated. > > The helper cpumask_available was added in commit f7e30f01a9e2 > ("cpumask: > Add helper cpumask_available()") to handle situations like this so use > it to keep the meaning of the code the same while resolving the > warning. > > Fixes: e4e3f24b822f ("net/mlx5: Provide cpumask at EQ creation phase") > Link: https://github.com/ClangBuiltLinux/linux/issues/1400 > Signed-off-by: Nathan Chancellor > --- Applied to net-next-mlx5 Thanks!