From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751903AbdBBWRm (ORCPT ); Thu, 2 Feb 2017 17:17:42 -0500 Received: from mail-pf0-f172.google.com ([209.85.192.172]:36336 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbdBBWRk (ORCPT ); Thu, 2 Feb 2017 17:17:40 -0500 Subject: Re: [PATCH v4 2nd 2/4] pstore: support multiple pmsg instances To: Nobuhiro Iwamatsu , Anton Vorontsov , Colin Cross , Kees Cook , Tony Luck References: <1485827915-9620-1-git-send-email-nobuhiro.iwamatsu.kw@hitachi.com> <1485827915-9620-3-git-send-email-nobuhiro.iwamatsu.kw@hitachi.com> Cc: linux-kernel@vger.kernel.org, Hiraku Toyooka , Seiji Aguchi From: Mark Salyzyn Message-ID: Date: Thu, 2 Feb 2017 14:17:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1485827915-9620-3-git-send-email-nobuhiro.iwamatsu.kw@hitachi.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/30/2017 05:58 PM, Nobuhiro Iwamatsu wrote: > diff --git a/include/linux/pstore.h b/include/linux/pstore.h > index 0da29cae009b..7a5db4833b8a 100644 > --- a/include/linux/pstore.h > +++ b/include/linux/pstore.h > @@ -55,6 +55,7 @@ struct pstore_info { > size_t bufsize; > struct mutex read_mutex; /* serialize open/read/close */ > int flags; > + unsigned int num_pmsg; > int (*open)(struct pstore_info *psi); > int (*close)(struct pstore_info *psi); > ssize_t (*read)(u64 *id, enum pstore_type_id *type, Before patch there was an implication that num_pmsg was 1, after patch calloc leaves this at a value of 0. Please reconcile the functional difference that this causes. -- Mark