All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-10 12:26 ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-10 12:26 UTC (permalink / raw)
  To: gregkh
  Cc: jirislaby, matthias.bgg, angelogioacchino.delregno, zhiyong.tao,
	colin.king, linux-serial, linux-arm-kernel, linux-mediatek,
	linux-kernel, wenst, broonie

It was found that some MediaTek SoCs are incompatible with this
change. Also, this register was mistakenly understood as it was
related to the 16550A register layout selection but, at least
on some IPs, if not all, it's related to something else unknown.

This reverts commit 6f81fdded0d024c7d4084d434764f30bca1cd6b1.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 drivers/tty/serial/8250/8250_mtk.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
index 21053db93ff1..54051ec7b499 100644
--- a/drivers/tty/serial/8250/8250_mtk.c
+++ b/drivers/tty/serial/8250/8250_mtk.c
@@ -54,9 +54,6 @@
 #define MTK_UART_TX_TRIGGER	1
 #define MTK_UART_RX_TRIGGER	MTK_UART_RX_SIZE
 
-#define MTK_UART_FEATURE_SEL	39	/* Feature Selection register */
-#define MTK_UART_FEAT_NEWRMAP	BIT(0)	/* Use new register map */
-
 #define MTK_UART_XON1		40	/* I/O: Xon character 1 */
 #define MTK_UART_XOFF1		42	/* I/O: Xoff character 1 */
 
@@ -575,10 +572,6 @@ static int mtk8250_probe(struct platform_device *pdev)
 		uart.dma = data->dma;
 #endif
 
-	/* Set AP UART new register map */
-	writel(MTK_UART_FEAT_NEWRMAP, uart.port.membase +
-	       (MTK_UART_FEATURE_SEL << uart.port.regshift));
-
 	/* Disable Rate Fix function */
 	writel(0x0, uart.port.membase +
 			(MTK_UART_RATE_FIX << uart.port.regshift));
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-10 12:26 ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-10 12:26 UTC (permalink / raw)
  To: gregkh
  Cc: jirislaby, matthias.bgg, angelogioacchino.delregno, zhiyong.tao,
	colin.king, linux-serial, linux-arm-kernel, linux-mediatek,
	linux-kernel, wenst, broonie

It was found that some MediaTek SoCs are incompatible with this
change. Also, this register was mistakenly understood as it was
related to the 16550A register layout selection but, at least
on some IPs, if not all, it's related to something else unknown.

This reverts commit 6f81fdded0d024c7d4084d434764f30bca1cd6b1.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 drivers/tty/serial/8250/8250_mtk.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
index 21053db93ff1..54051ec7b499 100644
--- a/drivers/tty/serial/8250/8250_mtk.c
+++ b/drivers/tty/serial/8250/8250_mtk.c
@@ -54,9 +54,6 @@
 #define MTK_UART_TX_TRIGGER	1
 #define MTK_UART_RX_TRIGGER	MTK_UART_RX_SIZE
 
-#define MTK_UART_FEATURE_SEL	39	/* Feature Selection register */
-#define MTK_UART_FEAT_NEWRMAP	BIT(0)	/* Use new register map */
-
 #define MTK_UART_XON1		40	/* I/O: Xon character 1 */
 #define MTK_UART_XOFF1		42	/* I/O: Xoff character 1 */
 
@@ -575,10 +572,6 @@ static int mtk8250_probe(struct platform_device *pdev)
 		uart.dma = data->dma;
 #endif
 
-	/* Set AP UART new register map */
-	writel(MTK_UART_FEAT_NEWRMAP, uart.port.membase +
-	       (MTK_UART_FEATURE_SEL << uart.port.regshift));
-
 	/* Disable Rate Fix function */
 	writel(0x0, uart.port.membase +
 			(MTK_UART_RATE_FIX << uart.port.regshift));
-- 
2.35.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 30+ messages in thread

* [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-10 12:26 ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-10 12:26 UTC (permalink / raw)
  To: gregkh
  Cc: jirislaby, matthias.bgg, angelogioacchino.delregno, zhiyong.tao,
	colin.king, linux-serial, linux-arm-kernel, linux-mediatek,
	linux-kernel, wenst, broonie

It was found that some MediaTek SoCs are incompatible with this
change. Also, this register was mistakenly understood as it was
related to the 16550A register layout selection but, at least
on some IPs, if not all, it's related to something else unknown.

This reverts commit 6f81fdded0d024c7d4084d434764f30bca1cd6b1.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 drivers/tty/serial/8250/8250_mtk.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
index 21053db93ff1..54051ec7b499 100644
--- a/drivers/tty/serial/8250/8250_mtk.c
+++ b/drivers/tty/serial/8250/8250_mtk.c
@@ -54,9 +54,6 @@
 #define MTK_UART_TX_TRIGGER	1
 #define MTK_UART_RX_TRIGGER	MTK_UART_RX_SIZE
 
-#define MTK_UART_FEATURE_SEL	39	/* Feature Selection register */
-#define MTK_UART_FEAT_NEWRMAP	BIT(0)	/* Use new register map */
-
 #define MTK_UART_XON1		40	/* I/O: Xon character 1 */
 #define MTK_UART_XOFF1		42	/* I/O: Xoff character 1 */
 
@@ -575,10 +572,6 @@ static int mtk8250_probe(struct platform_device *pdev)
 		uart.dma = data->dma;
 #endif
 
-	/* Set AP UART new register map */
-	writel(MTK_UART_FEAT_NEWRMAP, uart.port.membase +
-	       (MTK_UART_FEATURE_SEL << uart.port.regshift));
-
 	/* Disable Rate Fix function */
 	writel(0x0, uart.port.membase +
 			(MTK_UART_RATE_FIX << uart.port.regshift));
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
  2022-05-10 12:26 ` AngeloGioacchino Del Regno
  (?)
@ 2022-05-10 12:45   ` Mark Brown
  -1 siblings, 0 replies; 30+ messages in thread
From: Mark Brown @ 2022-05-10 12:45 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

On Tue, May 10, 2022 at 02:26:20PM +0200, AngeloGioacchino Del Regno wrote:
> It was found that some MediaTek SoCs are incompatible with this
> change. Also, this register was mistakenly understood as it was
> related to the 16550A register layout selection but, at least
> on some IPs, if not all, it's related to something else unknown.
> 
> This reverts commit 6f81fdded0d024c7d4084d434764f30bca1cd6b1.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---

Reported-by: "kernelci.org bot" <bot@kernelci.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-10 12:45   ` Mark Brown
  0 siblings, 0 replies; 30+ messages in thread
From: Mark Brown @ 2022-05-10 12:45 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst


[-- Attachment #1.1: Type: text/plain, Size: 565 bytes --]

On Tue, May 10, 2022 at 02:26:20PM +0200, AngeloGioacchino Del Regno wrote:
> It was found that some MediaTek SoCs are incompatible with this
> change. Also, this register was mistakenly understood as it was
> related to the 16550A register layout selection but, at least
> on some IPs, if not all, it's related to something else unknown.
> 
> This reverts commit 6f81fdded0d024c7d4084d434764f30bca1cd6b1.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---

Reported-by: "kernelci.org bot" <bot@kernelci.org>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-10 12:45   ` Mark Brown
  0 siblings, 0 replies; 30+ messages in thread
From: Mark Brown @ 2022-05-10 12:45 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst


[-- Attachment #1.1: Type: text/plain, Size: 565 bytes --]

On Tue, May 10, 2022 at 02:26:20PM +0200, AngeloGioacchino Del Regno wrote:
> It was found that some MediaTek SoCs are incompatible with this
> change. Also, this register was mistakenly understood as it was
> related to the 16550A register layout selection but, at least
> on some IPs, if not all, it's related to something else unknown.
> 
> This reverts commit 6f81fdded0d024c7d4084d434764f30bca1cd6b1.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---

Reported-by: "kernelci.org bot" <bot@kernelci.org>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
  2022-05-10 12:45   ` Mark Brown
  (?)
@ 2022-05-10 12:46     ` AngeloGioacchino Del Regno
  -1 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-10 12:46 UTC (permalink / raw)
  To: Mark Brown
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 10/05/22 14:45, Mark Brown ha scritto:
> On Tue, May 10, 2022 at 02:26:20PM +0200, AngeloGioacchino Del Regno wrote:
>> It was found that some MediaTek SoCs are incompatible with this
>> change. Also, this register was mistakenly understood as it was
>> related to the 16550A register layout selection but, at least
>> on some IPs, if not all, it's related to something else unknown.
>>
>> This reverts commit 6f81fdded0d024c7d4084d434764f30bca1cd6b1.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
> 
> Reported-by: "kernelci.org bot" <bot@kernelci.org>


Sorry for missing this tag, and also I'm sorry for the noise.

Regards,
Angelo

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-10 12:46     ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-10 12:46 UTC (permalink / raw)
  To: Mark Brown
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 10/05/22 14:45, Mark Brown ha scritto:
> On Tue, May 10, 2022 at 02:26:20PM +0200, AngeloGioacchino Del Regno wrote:
>> It was found that some MediaTek SoCs are incompatible with this
>> change. Also, this register was mistakenly understood as it was
>> related to the 16550A register layout selection but, at least
>> on some IPs, if not all, it's related to something else unknown.
>>
>> This reverts commit 6f81fdded0d024c7d4084d434764f30bca1cd6b1.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
> 
> Reported-by: "kernelci.org bot" <bot@kernelci.org>


Sorry for missing this tag, and also I'm sorry for the noise.

Regards,
Angelo

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-10 12:46     ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-10 12:46 UTC (permalink / raw)
  To: Mark Brown
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 10/05/22 14:45, Mark Brown ha scritto:
> On Tue, May 10, 2022 at 02:26:20PM +0200, AngeloGioacchino Del Regno wrote:
>> It was found that some MediaTek SoCs are incompatible with this
>> change. Also, this register was mistakenly understood as it was
>> related to the 16550A register layout selection but, at least
>> on some IPs, if not all, it's related to something else unknown.
>>
>> This reverts commit 6f81fdded0d024c7d4084d434764f30bca1cd6b1.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
> 
> Reported-by: "kernelci.org bot" <bot@kernelci.org>


Sorry for missing this tag, and also I'm sorry for the noise.

Regards,
Angelo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
  2022-05-10 12:46     ` AngeloGioacchino Del Regno
  (?)
@ 2022-05-10 12:56       ` Mark Brown
  -1 siblings, 0 replies; 30+ messages in thread
From: Mark Brown @ 2022-05-10 12:56 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:

> Sorry for missing this tag, and also I'm sorry for the noise.

Hey, if nobody broke anything all this testing stuff wouldn't be worth
it!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-10 12:56       ` Mark Brown
  0 siblings, 0 replies; 30+ messages in thread
From: Mark Brown @ 2022-05-10 12:56 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst


[-- Attachment #1.1: Type: text/plain, Size: 217 bytes --]

On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:

> Sorry for missing this tag, and also I'm sorry for the noise.

Hey, if nobody broke anything all this testing stuff wouldn't be worth
it!

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-10 12:56       ` Mark Brown
  0 siblings, 0 replies; 30+ messages in thread
From: Mark Brown @ 2022-05-10 12:56 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst


[-- Attachment #1.1: Type: text/plain, Size: 217 bytes --]

On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:

> Sorry for missing this tag, and also I'm sorry for the noise.

Hey, if nobody broke anything all this testing stuff wouldn't be worth
it!

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
  2022-05-10 12:56       ` Mark Brown
  (?)
@ 2022-05-10 15:29         ` AngeloGioacchino Del Regno
  -1 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-10 15:29 UTC (permalink / raw)
  To: Mark Brown
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 10/05/22 14:56, Mark Brown ha scritto:
> On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
> 
>> Sorry for missing this tag, and also I'm sorry for the noise.
> 
> Hey, if nobody broke anything all this testing stuff wouldn't be worth
> it!


Haha! That's true :-)

Thank you!

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-10 15:29         ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-10 15:29 UTC (permalink / raw)
  To: Mark Brown
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 10/05/22 14:56, Mark Brown ha scritto:
> On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
> 
>> Sorry for missing this tag, and also I'm sorry for the noise.
> 
> Hey, if nobody broke anything all this testing stuff wouldn't be worth
> it!


Haha! That's true :-)

Thank you!

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-10 15:29         ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-10 15:29 UTC (permalink / raw)
  To: Mark Brown
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 10/05/22 14:56, Mark Brown ha scritto:
> On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
> 
>> Sorry for missing this tag, and also I'm sorry for the noise.
> 
> Hey, if nobody broke anything all this testing stuff wouldn't be worth
> it!


Haha! That's true :-)

Thank you!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
  2022-05-10 15:29         ` AngeloGioacchino Del Regno
  (?)
@ 2022-05-23 10:17           ` AngeloGioacchino Del Regno
  -1 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-23 10:17 UTC (permalink / raw)
  To: Mark Brown
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
> Il 10/05/22 14:56, Mark Brown ha scritto:
>> On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
>>
>>> Sorry for missing this tag, and also I'm sorry for the noise.
>>
>> Hey, if nobody broke anything all this testing stuff wouldn't be worth
>> it!
> 
> 
> Haha! That's true :-)
> 
> Thank you!


Hello Mark, Greg

I've just noticed that v5.18 was released, but without this revert.
Can you schedule this for backport on v5.18?

Thanks,
Angelo

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-23 10:17           ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-23 10:17 UTC (permalink / raw)
  To: Mark Brown
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
> Il 10/05/22 14:56, Mark Brown ha scritto:
>> On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
>>
>>> Sorry for missing this tag, and also I'm sorry for the noise.
>>
>> Hey, if nobody broke anything all this testing stuff wouldn't be worth
>> it!
> 
> 
> Haha! That's true :-)
> 
> Thank you!


Hello Mark, Greg

I've just noticed that v5.18 was released, but without this revert.
Can you schedule this for backport on v5.18?

Thanks,
Angelo

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-23 10:17           ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-23 10:17 UTC (permalink / raw)
  To: Mark Brown
  Cc: gregkh, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
> Il 10/05/22 14:56, Mark Brown ha scritto:
>> On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
>>
>>> Sorry for missing this tag, and also I'm sorry for the noise.
>>
>> Hey, if nobody broke anything all this testing stuff wouldn't be worth
>> it!
> 
> 
> Haha! That's true :-)
> 
> Thank you!


Hello Mark, Greg

I've just noticed that v5.18 was released, but without this revert.
Can you schedule this for backport on v5.18?

Thanks,
Angelo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
  2022-05-23 10:17           ` AngeloGioacchino Del Regno
  (?)
@ 2022-05-23 12:10             ` Greg KH
  -1 siblings, 0 replies; 30+ messages in thread
From: Greg KH @ 2022-05-23 12:10 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: Mark Brown, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

On Mon, May 23, 2022 at 12:17:06PM +0200, AngeloGioacchino Del Regno wrote:
> Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
> > Il 10/05/22 14:56, Mark Brown ha scritto:
> > > On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
> > > 
> > > > Sorry for missing this tag, and also I'm sorry for the noise.
> > > 
> > > Hey, if nobody broke anything all this testing stuff wouldn't be worth
> > > it!
> > 
> > 
> > Haha! That's true :-)
> > 
> > Thank you!
> 
> 
> Hello Mark, Greg
> 
> I've just noticed that v5.18 was released, but without this revert.

What is "this revert"?

> Can you schedule this for backport on v5.18?

I need more context here, sorry.

greg k-h

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-23 12:10             ` Greg KH
  0 siblings, 0 replies; 30+ messages in thread
From: Greg KH @ 2022-05-23 12:10 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: Mark Brown, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

On Mon, May 23, 2022 at 12:17:06PM +0200, AngeloGioacchino Del Regno wrote:
> Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
> > Il 10/05/22 14:56, Mark Brown ha scritto:
> > > On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
> > > 
> > > > Sorry for missing this tag, and also I'm sorry for the noise.
> > > 
> > > Hey, if nobody broke anything all this testing stuff wouldn't be worth
> > > it!
> > 
> > 
> > Haha! That's true :-)
> > 
> > Thank you!
> 
> 
> Hello Mark, Greg
> 
> I've just noticed that v5.18 was released, but without this revert.

What is "this revert"?

> Can you schedule this for backport on v5.18?

I need more context here, sorry.

greg k-h

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-23 12:10             ` Greg KH
  0 siblings, 0 replies; 30+ messages in thread
From: Greg KH @ 2022-05-23 12:10 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: Mark Brown, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

On Mon, May 23, 2022 at 12:17:06PM +0200, AngeloGioacchino Del Regno wrote:
> Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
> > Il 10/05/22 14:56, Mark Brown ha scritto:
> > > On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
> > > 
> > > > Sorry for missing this tag, and also I'm sorry for the noise.
> > > 
> > > Hey, if nobody broke anything all this testing stuff wouldn't be worth
> > > it!
> > 
> > 
> > Haha! That's true :-)
> > 
> > Thank you!
> 
> 
> Hello Mark, Greg
> 
> I've just noticed that v5.18 was released, but without this revert.

What is "this revert"?

> Can you schedule this for backport on v5.18?

I need more context here, sorry.

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
  2022-05-23 12:10             ` Greg KH
  (?)
@ 2022-05-23 12:13               ` AngeloGioacchino Del Regno
  -1 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-23 12:13 UTC (permalink / raw)
  To: Greg KH
  Cc: Mark Brown, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 23/05/22 14:10, Greg KH ha scritto:
> On Mon, May 23, 2022 at 12:17:06PM +0200, AngeloGioacchino Del Regno wrote:
>> Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
>>> Il 10/05/22 14:56, Mark Brown ha scritto:
>>>> On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
>>>>
>>>>> Sorry for missing this tag, and also I'm sorry for the noise.
>>>>
>>>> Hey, if nobody broke anything all this testing stuff wouldn't be worth
>>>> it!
>>>
>>>
>>> Haha! That's true :-)
>>>
>>> Thank you!
>>
>>
>> Hello Mark, Greg
>>
>> I've just noticed that v5.18 was released, but without this revert.
> 
> What is "this revert"?
> 

"this revert" == "this commit", reverting

6f81fdded0d0 ("serial: 8250_mtk: Make sure to select the right FEATURE_SEL")

>> Can you schedule this for backport on v5.18?
> 
> I need more context here, sorry.
> 

As stated in the commit description, some MediaTek SoCs are incompatible with
this change, hence it's actually breaking late serial for some machines.

> greg k-h



^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-23 12:13               ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-23 12:13 UTC (permalink / raw)
  To: Greg KH
  Cc: Mark Brown, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 23/05/22 14:10, Greg KH ha scritto:
> On Mon, May 23, 2022 at 12:17:06PM +0200, AngeloGioacchino Del Regno wrote:
>> Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
>>> Il 10/05/22 14:56, Mark Brown ha scritto:
>>>> On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
>>>>
>>>>> Sorry for missing this tag, and also I'm sorry for the noise.
>>>>
>>>> Hey, if nobody broke anything all this testing stuff wouldn't be worth
>>>> it!
>>>
>>>
>>> Haha! That's true :-)
>>>
>>> Thank you!
>>
>>
>> Hello Mark, Greg
>>
>> I've just noticed that v5.18 was released, but without this revert.
> 
> What is "this revert"?
> 

"this revert" == "this commit", reverting

6f81fdded0d0 ("serial: 8250_mtk: Make sure to select the right FEATURE_SEL")

>> Can you schedule this for backport on v5.18?
> 
> I need more context here, sorry.
> 

As stated in the commit description, some MediaTek SoCs are incompatible with
this change, hence it's actually breaking late serial for some machines.

> greg k-h



_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-23 12:13               ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-23 12:13 UTC (permalink / raw)
  To: Greg KH
  Cc: Mark Brown, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 23/05/22 14:10, Greg KH ha scritto:
> On Mon, May 23, 2022 at 12:17:06PM +0200, AngeloGioacchino Del Regno wrote:
>> Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
>>> Il 10/05/22 14:56, Mark Brown ha scritto:
>>>> On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
>>>>
>>>>> Sorry for missing this tag, and also I'm sorry for the noise.
>>>>
>>>> Hey, if nobody broke anything all this testing stuff wouldn't be worth
>>>> it!
>>>
>>>
>>> Haha! That's true :-)
>>>
>>> Thank you!
>>
>>
>> Hello Mark, Greg
>>
>> I've just noticed that v5.18 was released, but without this revert.
> 
> What is "this revert"?
> 

"this revert" == "this commit", reverting

6f81fdded0d0 ("serial: 8250_mtk: Make sure to select the right FEATURE_SEL")

>> Can you schedule this for backport on v5.18?
> 
> I need more context here, sorry.
> 

As stated in the commit description, some MediaTek SoCs are incompatible with
this change, hence it's actually breaking late serial for some machines.

> greg k-h



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
  2022-05-23 12:13               ` AngeloGioacchino Del Regno
  (?)
@ 2022-05-23 12:32                 ` Greg KH
  -1 siblings, 0 replies; 30+ messages in thread
From: Greg KH @ 2022-05-23 12:32 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: Mark Brown, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

On Mon, May 23, 2022 at 02:13:35PM +0200, AngeloGioacchino Del Regno wrote:
> Il 23/05/22 14:10, Greg KH ha scritto:
> > On Mon, May 23, 2022 at 12:17:06PM +0200, AngeloGioacchino Del Regno wrote:
> > > Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
> > > > Il 10/05/22 14:56, Mark Brown ha scritto:
> > > > > On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
> > > > > 
> > > > > > Sorry for missing this tag, and also I'm sorry for the noise.
> > > > > 
> > > > > Hey, if nobody broke anything all this testing stuff wouldn't be worth
> > > > > it!
> > > > 
> > > > 
> > > > Haha! That's true :-)
> > > > 
> > > > Thank you!
> > > 
> > > 
> > > Hello Mark, Greg
> > > 
> > > I've just noticed that v5.18 was released, but without this revert.
> > 
> > What is "this revert"?
> > 
> 
> "this revert" == "this commit", reverting
> 
> 6f81fdded0d0 ("serial: 8250_mtk: Make sure to select the right FEATURE_SEL")
> 
> > > Can you schedule this for backport on v5.18?
> > 
> > I need more context here, sorry.
> > 
> 
> As stated in the commit description, some MediaTek SoCs are incompatible with
> this change, hence it's actually breaking late serial for some machines.

Did I already apply this change to my tree?  If so, once it hits Linus's
tree we can backport it to 5.18.1.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-23 12:32                 ` Greg KH
  0 siblings, 0 replies; 30+ messages in thread
From: Greg KH @ 2022-05-23 12:32 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: Mark Brown, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

On Mon, May 23, 2022 at 02:13:35PM +0200, AngeloGioacchino Del Regno wrote:
> Il 23/05/22 14:10, Greg KH ha scritto:
> > On Mon, May 23, 2022 at 12:17:06PM +0200, AngeloGioacchino Del Regno wrote:
> > > Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
> > > > Il 10/05/22 14:56, Mark Brown ha scritto:
> > > > > On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
> > > > > 
> > > > > > Sorry for missing this tag, and also I'm sorry for the noise.
> > > > > 
> > > > > Hey, if nobody broke anything all this testing stuff wouldn't be worth
> > > > > it!
> > > > 
> > > > 
> > > > Haha! That's true :-)
> > > > 
> > > > Thank you!
> > > 
> > > 
> > > Hello Mark, Greg
> > > 
> > > I've just noticed that v5.18 was released, but without this revert.
> > 
> > What is "this revert"?
> > 
> 
> "this revert" == "this commit", reverting
> 
> 6f81fdded0d0 ("serial: 8250_mtk: Make sure to select the right FEATURE_SEL")
> 
> > > Can you schedule this for backport on v5.18?
> > 
> > I need more context here, sorry.
> > 
> 
> As stated in the commit description, some MediaTek SoCs are incompatible with
> this change, hence it's actually breaking late serial for some machines.

Did I already apply this change to my tree?  If so, once it hits Linus's
tree we can backport it to 5.18.1.

thanks,

greg k-h

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-23 12:32                 ` Greg KH
  0 siblings, 0 replies; 30+ messages in thread
From: Greg KH @ 2022-05-23 12:32 UTC (permalink / raw)
  To: AngeloGioacchino Del Regno
  Cc: Mark Brown, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

On Mon, May 23, 2022 at 02:13:35PM +0200, AngeloGioacchino Del Regno wrote:
> Il 23/05/22 14:10, Greg KH ha scritto:
> > On Mon, May 23, 2022 at 12:17:06PM +0200, AngeloGioacchino Del Regno wrote:
> > > Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
> > > > Il 10/05/22 14:56, Mark Brown ha scritto:
> > > > > On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
> > > > > 
> > > > > > Sorry for missing this tag, and also I'm sorry for the noise.
> > > > > 
> > > > > Hey, if nobody broke anything all this testing stuff wouldn't be worth
> > > > > it!
> > > > 
> > > > 
> > > > Haha! That's true :-)
> > > > 
> > > > Thank you!
> > > 
> > > 
> > > Hello Mark, Greg
> > > 
> > > I've just noticed that v5.18 was released, but without this revert.
> > 
> > What is "this revert"?
> > 
> 
> "this revert" == "this commit", reverting
> 
> 6f81fdded0d0 ("serial: 8250_mtk: Make sure to select the right FEATURE_SEL")
> 
> > > Can you schedule this for backport on v5.18?
> > 
> > I need more context here, sorry.
> > 
> 
> As stated in the commit description, some MediaTek SoCs are incompatible with
> this change, hence it's actually breaking late serial for some machines.

Did I already apply this change to my tree?  If so, once it hits Linus's
tree we can backport it to 5.18.1.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
  2022-05-23 12:32                 ` Greg KH
  (?)
@ 2022-05-23 13:25                   ` AngeloGioacchino Del Regno
  -1 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-23 13:25 UTC (permalink / raw)
  To: Greg KH
  Cc: Mark Brown, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 23/05/22 14:32, Greg KH ha scritto:
> On Mon, May 23, 2022 at 02:13:35PM +0200, AngeloGioacchino Del Regno wrote:
>> Il 23/05/22 14:10, Greg KH ha scritto:
>>> On Mon, May 23, 2022 at 12:17:06PM +0200, AngeloGioacchino Del Regno wrote:
>>>> Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
>>>>> Il 10/05/22 14:56, Mark Brown ha scritto:
>>>>>> On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
>>>>>>
>>>>>>> Sorry for missing this tag, and also I'm sorry for the noise.
>>>>>>
>>>>>> Hey, if nobody broke anything all this testing stuff wouldn't be worth
>>>>>> it!
>>>>>
>>>>>
>>>>> Haha! That's true :-)
>>>>>
>>>>> Thank you!
>>>>
>>>>
>>>> Hello Mark, Greg
>>>>
>>>> I've just noticed that v5.18 was released, but without this revert.
>>>
>>> What is "this revert"?
>>>
>>
>> "this revert" == "this commit", reverting
>>
>> 6f81fdded0d0 ("serial: 8250_mtk: Make sure to select the right FEATURE_SEL")
>>
>>>> Can you schedule this for backport on v5.18?
>>>
>>> I need more context here, sorry.
>>>
>>
>> As stated in the commit description, some MediaTek SoCs are incompatible with
>> this change, hence it's actually breaking late serial for some machines.
> 
> Did I already apply this change to my tree?

Yes you have applied it to tty-next.

 >
>  If so, once it hits Linus's
> tree we can backport it to 5.18.1.
> 

Okay, sounds good, thank you!

Regards,
Angelo



^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-23 13:25                   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-23 13:25 UTC (permalink / raw)
  To: Greg KH
  Cc: Mark Brown, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 23/05/22 14:32, Greg KH ha scritto:
> On Mon, May 23, 2022 at 02:13:35PM +0200, AngeloGioacchino Del Regno wrote:
>> Il 23/05/22 14:10, Greg KH ha scritto:
>>> On Mon, May 23, 2022 at 12:17:06PM +0200, AngeloGioacchino Del Regno wrote:
>>>> Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
>>>>> Il 10/05/22 14:56, Mark Brown ha scritto:
>>>>>> On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
>>>>>>
>>>>>>> Sorry for missing this tag, and also I'm sorry for the noise.
>>>>>>
>>>>>> Hey, if nobody broke anything all this testing stuff wouldn't be worth
>>>>>> it!
>>>>>
>>>>>
>>>>> Haha! That's true :-)
>>>>>
>>>>> Thank you!
>>>>
>>>>
>>>> Hello Mark, Greg
>>>>
>>>> I've just noticed that v5.18 was released, but without this revert.
>>>
>>> What is "this revert"?
>>>
>>
>> "this revert" == "this commit", reverting
>>
>> 6f81fdded0d0 ("serial: 8250_mtk: Make sure to select the right FEATURE_SEL")
>>
>>>> Can you schedule this for backport on v5.18?
>>>
>>> I need more context here, sorry.
>>>
>>
>> As stated in the commit description, some MediaTek SoCs are incompatible with
>> this change, hence it's actually breaking late serial for some machines.
> 
> Did I already apply this change to my tree?

Yes you have applied it to tty-next.

 >
>  If so, once it hits Linus's
> tree we can backport it to 5.18.1.
> 

Okay, sounds good, thank you!

Regards,
Angelo



_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL"
@ 2022-05-23 13:25                   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 30+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-05-23 13:25 UTC (permalink / raw)
  To: Greg KH
  Cc: Mark Brown, jirislaby, matthias.bgg, zhiyong.tao, colin.king,
	linux-serial, linux-arm-kernel, linux-mediatek, linux-kernel,
	wenst

Il 23/05/22 14:32, Greg KH ha scritto:
> On Mon, May 23, 2022 at 02:13:35PM +0200, AngeloGioacchino Del Regno wrote:
>> Il 23/05/22 14:10, Greg KH ha scritto:
>>> On Mon, May 23, 2022 at 12:17:06PM +0200, AngeloGioacchino Del Regno wrote:
>>>> Il 10/05/22 17:29, AngeloGioacchino Del Regno ha scritto:
>>>>> Il 10/05/22 14:56, Mark Brown ha scritto:
>>>>>> On Tue, May 10, 2022 at 02:46:28PM +0200, AngeloGioacchino Del Regno wrote:
>>>>>>
>>>>>>> Sorry for missing this tag, and also I'm sorry for the noise.
>>>>>>
>>>>>> Hey, if nobody broke anything all this testing stuff wouldn't be worth
>>>>>> it!
>>>>>
>>>>>
>>>>> Haha! That's true :-)
>>>>>
>>>>> Thank you!
>>>>
>>>>
>>>> Hello Mark, Greg
>>>>
>>>> I've just noticed that v5.18 was released, but without this revert.
>>>
>>> What is "this revert"?
>>>
>>
>> "this revert" == "this commit", reverting
>>
>> 6f81fdded0d0 ("serial: 8250_mtk: Make sure to select the right FEATURE_SEL")
>>
>>>> Can you schedule this for backport on v5.18?
>>>
>>> I need more context here, sorry.
>>>
>>
>> As stated in the commit description, some MediaTek SoCs are incompatible with
>> this change, hence it's actually breaking late serial for some machines.
> 
> Did I already apply this change to my tree?

Yes you have applied it to tty-next.

 >
>  If so, once it hits Linus's
> tree we can backport it to 5.18.1.
> 

Okay, sounds good, thank you!

Regards,
Angelo



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, other threads:[~2022-05-23 13:26 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 12:26 [PATCH] Revert "serial: 8250_mtk: Make sure to select the right FEATURE_SEL" AngeloGioacchino Del Regno
2022-05-10 12:26 ` AngeloGioacchino Del Regno
2022-05-10 12:26 ` AngeloGioacchino Del Regno
2022-05-10 12:45 ` Mark Brown
2022-05-10 12:45   ` Mark Brown
2022-05-10 12:45   ` Mark Brown
2022-05-10 12:46   ` AngeloGioacchino Del Regno
2022-05-10 12:46     ` AngeloGioacchino Del Regno
2022-05-10 12:46     ` AngeloGioacchino Del Regno
2022-05-10 12:56     ` Mark Brown
2022-05-10 12:56       ` Mark Brown
2022-05-10 12:56       ` Mark Brown
2022-05-10 15:29       ` AngeloGioacchino Del Regno
2022-05-10 15:29         ` AngeloGioacchino Del Regno
2022-05-10 15:29         ` AngeloGioacchino Del Regno
2022-05-23 10:17         ` AngeloGioacchino Del Regno
2022-05-23 10:17           ` AngeloGioacchino Del Regno
2022-05-23 10:17           ` AngeloGioacchino Del Regno
2022-05-23 12:10           ` Greg KH
2022-05-23 12:10             ` Greg KH
2022-05-23 12:10             ` Greg KH
2022-05-23 12:13             ` AngeloGioacchino Del Regno
2022-05-23 12:13               ` AngeloGioacchino Del Regno
2022-05-23 12:13               ` AngeloGioacchino Del Regno
2022-05-23 12:32               ` Greg KH
2022-05-23 12:32                 ` Greg KH
2022-05-23 12:32                 ` Greg KH
2022-05-23 13:25                 ` AngeloGioacchino Del Regno
2022-05-23 13:25                   ` AngeloGioacchino Del Regno
2022-05-23 13:25                   ` AngeloGioacchino Del Regno

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.