From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA67CC433EF for ; Wed, 15 Dec 2021 12:39:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242576AbhLOMjH (ORCPT ); Wed, 15 Dec 2021 07:39:07 -0500 Received: from foss.arm.com ([217.140.110.172]:50848 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234378AbhLOMjG (ORCPT ); Wed, 15 Dec 2021 07:39:06 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 854CAD6E; Wed, 15 Dec 2021 04:39:05 -0800 (PST) Received: from [10.57.33.203] (unknown [10.57.33.203]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E90B53F774; Wed, 15 Dec 2021 04:39:02 -0800 (PST) Message-ID: Date: Wed, 15 Dec 2021 12:38:47 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [RFC PATCH 1/1] perf arm64: Implement --topdown with metrics Content-Language: en-US To: John Garry , Ian Rogers Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, Will Deacon , Mathieu Poirier , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org References: <4c375d34-bf20-496d-22fc-aed8597126e2@huawei.com> <20211214184240.24215-1-andrew.kilroy@arm.com> <20211214184240.24215-2-andrew.kilroy@arm.com> From: Andrew Kilroy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ian, John, thanks for the feedback. On 15/12/2021 10:52, John Garry wrote: > Hi Andrew, > >>>   const struct pmu_event *metricgroup__find_metric(const char *metric, >>>                                                   const struct >>> pmu_events_map *map); >>>   int metricgroup__parse_groups_test(struct evlist *evlist, >>> diff --git a/tools/perf/util/topdown.c b/tools/perf/util/topdown.c >>> index 1081b20f9891..57c0c5f2c6bd 100644 >>> --- a/tools/perf/util/topdown.c >>> +++ b/tools/perf/util/topdown.c >>> @@ -56,3 +56,9 @@ __weak bool arch_topdown_sample_read(struct evsel >>> *leader __maybe_unused) >>>   { >>>          return false; >>>   } >>> + >>> +__weak bool arch_topdown_use_json_metrics(void) >>> +{ > > AFAICS, only x86 supports topdown today and that is because they have > special kernel topdown events exposed for the kernel CPU PMU driver. So > other architectures - not only arm - would need rely on metricgroups for > topdown support. So let's make this generic for all archs. > >> I like this extension! I've ranted in the past about weak symbols >> breaking with archives due to lazy loading [1]. In this case >> tools/perf/arch/arm64/util/topdown.c has no other symbols within it >> and so the weak symbol has an extra chance of being linked >> incorrectly. We could add a new command line of --topdown-json to >> avoid this, but there seems little difference in doing this over just >> doing '-M TopDownL1'. > > >> Is it possible to use the json metric approach >> for when the CPU version fails? > > I think that's a good idea. > Taking a look. > In addition we could also add a --topdown arg to force using JSON > metricgroups. > What arg do think would be supplied? > Did you actually test this patch? I have something experimental working > from some time ago, and it was more complicated than this. I need to > check the code again... > I got stats back from this implementation, yes. Let me know if there's things my patch isn't catering for. > Thanks, > John From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2076DC433EF for ; Wed, 15 Dec 2021 12:40:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gi2S3tLZpHlL9kPZN5Pr7BJnVMsJYeRkxcujWPmdpmM=; b=3TGOIhyBMHCJU0 nqyZ88ZsOqcizdW6YaQnQMpNUY7C2C3S6xwhkY0KUwa8z9J5s5WCHruwtKBlBmb2dnk7h+mbfl4nu Ywx82jc5djzGlvFhVp3evY+SSI4+rA6gli1nXEZcqR1wsmEehpe7Ix1ZpJLsp5uybQgWQonE+a3a0 s6v3+Ics5gi/TjWRIe9KleO8bfk5miiLKgjw8jDmDJN0upoSNGZK75RTvUyFRZE0WrD5BWSfjLSn2 dW9KhvYTpKMdm1BCqvDlIkfWo8P/IfFrZ3aNeJ1fn2WgJnZ/j9CiNFpYwpZFTi7EJfXy/AdlEZ171 HcmgBp4vq7lV/aejdz8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxTYs-000ouO-79; Wed, 15 Dec 2021 12:39:10 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxTYo-000otU-Rq for linux-arm-kernel@lists.infradead.org; Wed, 15 Dec 2021 12:39:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 854CAD6E; Wed, 15 Dec 2021 04:39:05 -0800 (PST) Received: from [10.57.33.203] (unknown [10.57.33.203]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E90B53F774; Wed, 15 Dec 2021 04:39:02 -0800 (PST) Message-ID: Date: Wed, 15 Dec 2021 12:38:47 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [RFC PATCH 1/1] perf arm64: Implement --topdown with metrics Content-Language: en-US To: John Garry , Ian Rogers Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, acme@kernel.org, Will Deacon , Mathieu Poirier , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org References: <4c375d34-bf20-496d-22fc-aed8597126e2@huawei.com> <20211214184240.24215-1-andrew.kilroy@arm.com> <20211214184240.24215-2-andrew.kilroy@arm.com> From: Andrew Kilroy In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_043906_973956_C12CC83F X-CRM114-Status: GOOD ( 18.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWFuLCBKb2huLCB0aGFua3MgZm9yIHRoZSBmZWVkYmFjay4KCk9uIDE1LzEyLzIwMjEgMTA6NTIs IEpvaG4gR2Fycnkgd3JvdGU6Cj4gSGkgQW5kcmV3LAo+IAo+Pj4gwqAgY29uc3Qgc3RydWN0IHBt dV9ldmVudCAqbWV0cmljZ3JvdXBfX2ZpbmRfbWV0cmljKGNvbnN0IGNoYXIgKm1ldHJpYywKPj4+ IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGNvbnN0IHN0cnVjdCAK Pj4+IHBtdV9ldmVudHNfbWFwICptYXApOwo+Pj4gwqAgaW50IG1ldHJpY2dyb3VwX19wYXJzZV9n cm91cHNfdGVzdChzdHJ1Y3QgZXZsaXN0ICpldmxpc3QsCj4+PiBkaWZmIC0tZ2l0IGEvdG9vbHMv cGVyZi91dGlsL3RvcGRvd24uYyBiL3Rvb2xzL3BlcmYvdXRpbC90b3Bkb3duLmMKPj4+IGluZGV4 IDEwODFiMjBmOTg5MS4uNTdjMGM1ZjJjNmJkIDEwMDY0NAo+Pj4gLS0tIGEvdG9vbHMvcGVyZi91 dGlsL3RvcGRvd24uYwo+Pj4gKysrIGIvdG9vbHMvcGVyZi91dGlsL3RvcGRvd24uYwo+Pj4gQEAg LTU2LDMgKzU2LDkgQEAgX193ZWFrIGJvb2wgYXJjaF90b3Bkb3duX3NhbXBsZV9yZWFkKHN0cnVj dCBldnNlbCAKPj4+ICpsZWFkZXIgX19tYXliZV91bnVzZWQpCj4+PiDCoCB7Cj4+PiDCoMKgwqDC oMKgwqDCoMKgIHJldHVybiBmYWxzZTsKPj4+IMKgIH0KPj4+ICsKPj4+ICtfX3dlYWsgYm9vbCBh cmNoX3RvcGRvd25fdXNlX2pzb25fbWV0cmljcyh2b2lkKQo+Pj4gK3sKPiAKPiBBRkFJQ1MsIG9u bHkgeDg2IHN1cHBvcnRzIHRvcGRvd24gdG9kYXkgYW5kIHRoYXQgaXMgYmVjYXVzZSB0aGV5IGhh dmUgCj4gc3BlY2lhbCBrZXJuZWwgdG9wZG93biBldmVudHMgZXhwb3NlZCBmb3IgdGhlIGtlcm5l bCBDUFUgUE1VIGRyaXZlci4gU28gCj4gb3RoZXIgYXJjaGl0ZWN0dXJlcyAtIG5vdCBvbmx5IGFy bSAtIHdvdWxkIG5lZWQgcmVseSBvbiBtZXRyaWNncm91cHMgZm9yIAo+IHRvcGRvd24gc3VwcG9y dC4gU28gbGV0J3MgbWFrZSB0aGlzIGdlbmVyaWMgZm9yIGFsbCBhcmNocy4KPiAKPj4gSSBsaWtl IHRoaXMgZXh0ZW5zaW9uISBJJ3ZlIHJhbnRlZCBpbiB0aGUgcGFzdCBhYm91dCB3ZWFrIHN5bWJv bHMKPj4gYnJlYWtpbmcgd2l0aCBhcmNoaXZlcyBkdWUgdG8gbGF6eSBsb2FkaW5nIFsxXS4gSW4g dGhpcyBjYXNlCj4+IHRvb2xzL3BlcmYvYXJjaC9hcm02NC91dGlsL3RvcGRvd24uYyBoYXMgbm8g b3RoZXIgc3ltYm9scyB3aXRoaW4gaXQKPj4gYW5kIHNvIHRoZSB3ZWFrIHN5bWJvbCBoYXMgYW4g ZXh0cmEgY2hhbmNlIG9mIGJlaW5nIGxpbmtlZAo+PiBpbmNvcnJlY3RseS4gV2UgY291bGQgYWRk IGEgbmV3IGNvbW1hbmQgbGluZSBvZiAtLXRvcGRvd24tanNvbiB0bwo+PiBhdm9pZCB0aGlzLCBi dXQgdGhlcmUgc2VlbXMgbGl0dGxlIGRpZmZlcmVuY2UgaW4gZG9pbmcgdGhpcyBvdmVyIGp1c3QK Pj4gZG9pbmcgJy1NIFRvcERvd25MMScuCj4gCj4gCj4+IElzIGl0IHBvc3NpYmxlIHRvIHVzZSB0 aGUganNvbiBtZXRyaWMgYXBwcm9hY2gKPj4gZm9yIHdoZW4gdGhlIENQVSB2ZXJzaW9uIGZhaWxz Pwo+IAo+IEkgdGhpbmsgdGhhdCdzIGEgZ29vZCBpZGVhLgo+IAoKVGFraW5nIGEgbG9vay4KCj4g SW4gYWRkaXRpb24gd2UgY291bGQgYWxzbyBhZGQgYSAtLXRvcGRvd24gYXJnIHRvIGZvcmNlIHVz aW5nIEpTT04gCj4gbWV0cmljZ3JvdXBzLgo+IAoKV2hhdCBhcmcgZG8gdGhpbmsgd291bGQgYmUg c3VwcGxpZWQ/Cgo+IERpZCB5b3UgYWN0dWFsbHkgdGVzdCB0aGlzIHBhdGNoPyBJIGhhdmUgc29t ZXRoaW5nIGV4cGVyaW1lbnRhbCB3b3JraW5nIAo+IGZyb20gc29tZSB0aW1lIGFnbywgYW5kIGl0 IHdhcyBtb3JlIGNvbXBsaWNhdGVkIHRoYW4gdGhpcy4gSSBuZWVkIHRvIAo+IGNoZWNrIHRoZSBj b2RlIGFnYWluLi4uCj4gCgpJIGdvdCBzdGF0cyBiYWNrIGZyb20gdGhpcyBpbXBsZW1lbnRhdGlv biwgeWVzLiAgTGV0IG1lIGtub3cgaWYgdGhlcmUncyAKdGhpbmdzIG15IHBhdGNoIGlzbid0IGNh dGVyaW5nIGZvci4KCj4gVGhhbmtzLAo+IEpvaG4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK