All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Vincent Fu <vincent.fu@samsung.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] kyber: make trace_block_rq call consistent with documentation
Date: Fri, 6 Aug 2021 16:40:35 -0600	[thread overview]
Message-ID: <d9229ef3-6751-407f-a013-c4a1671996f9@kernel.dk> (raw)
In-Reply-To: <20210804194913.10497-1-vincent.fu@samsung.com>

On 8/4/21 1:49 PM, Vincent Fu wrote:
> The kyber ioscheduler calls trace_block_rq_insert() *after* the request
> is added to the queue but the documentation for trace_block_rq_insert()
> says that the call should be made *before* the request is added to the
> queue.  Move the tracepoint for the kyber ioscheduler so that it is
> consistent with the documentation.

Applied, thanks.

-- 
Jens Axboe


      parent reply	other threads:[~2021-08-06 22:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210804194924uscas1p2922dc9e7bb44fbfa10abe8157fdd43e1@uscas1p2.samsung.com>
2021-08-04 19:49 ` [PATCH] kyber: make trace_block_rq call consistent with documentation Vincent Fu
2021-08-05 20:31   ` Adam Manzanares
2021-08-06 22:40   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9229ef3-6751-407f-a013-c4a1671996f9@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=vincent.fu@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.