* [PATCH] media: renesas-ceu: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-01 5:55 Cai Huoqing
2021-09-01 11:05 ` Kieran Bingham
2021-09-03 14:26 ` Jacopo Mondi
0 siblings, 2 replies; 3+ messages in thread
From: Cai Huoqing @ 2021-09-01 5:55 UTC (permalink / raw)
To: caihuoqing
Cc: Jacopo Mondi, Mauro Carvalho Chehab, linux-media,
linux-renesas-soc, linux-kernel
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/media/platform/renesas-ceu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c
index 9376eb363748..2e8dbacc414e 100644
--- a/drivers/media/platform/renesas-ceu.c
+++ b/drivers/media/platform/renesas-ceu.c
@@ -1628,7 +1628,6 @@ static int ceu_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
const struct ceu_data *ceu_data;
struct ceu_device *ceudev;
- struct resource *res;
unsigned int irq;
int num_subdevs;
int ret;
@@ -1644,8 +1643,7 @@ static int ceu_probe(struct platform_device *pdev)
spin_lock_init(&ceudev->lock);
mutex_init(&ceudev->mlock);
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ceudev->base = devm_ioremap_resource(dev, res);
+ ceudev->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(ceudev->base)) {
ret = PTR_ERR(ceudev->base);
goto error_free_ceudev;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: renesas-ceu: Make use of the helper function devm_platform_ioremap_resource()
2021-09-01 5:55 [PATCH] media: renesas-ceu: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
@ 2021-09-01 11:05 ` Kieran Bingham
2021-09-03 14:26 ` Jacopo Mondi
1 sibling, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2021-09-01 11:05 UTC (permalink / raw)
To: Cai Huoqing
Cc: Jacopo Mondi, Mauro Carvalho Chehab, linux-media,
linux-renesas-soc, linux-kernel
On 01/09/2021 06:55, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/media/platform/renesas-ceu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c
> index 9376eb363748..2e8dbacc414e 100644
> --- a/drivers/media/platform/renesas-ceu.c
> +++ b/drivers/media/platform/renesas-ceu.c
> @@ -1628,7 +1628,6 @@ static int ceu_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> const struct ceu_data *ceu_data;
> struct ceu_device *ceudev;
> - struct resource *res;
> unsigned int irq;
> int num_subdevs;
> int ret;
> @@ -1644,8 +1643,7 @@ static int ceu_probe(struct platform_device *pdev)
> spin_lock_init(&ceudev->lock);
> mutex_init(&ceudev->mlock);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ceudev->base = devm_ioremap_resource(dev, res);
> + ceudev->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ceudev->base)) {
> ret = PTR_ERR(ceudev->base);
> goto error_free_ceudev;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: renesas-ceu: Make use of the helper function devm_platform_ioremap_resource()
2021-09-01 5:55 [PATCH] media: renesas-ceu: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01 11:05 ` Kieran Bingham
@ 2021-09-03 14:26 ` Jacopo Mondi
1 sibling, 0 replies; 3+ messages in thread
From: Jacopo Mondi @ 2021-09-03 14:26 UTC (permalink / raw)
To: Cai Huoqing
Cc: Mauro Carvalho Chehab, linux-media, linux-renesas-soc, linux-kernel
Hello Cai,
On Wed, Sep 01, 2021 at 01:55:39PM +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Acked-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Thanks
j
> ---
> drivers/media/platform/renesas-ceu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c
> index 9376eb363748..2e8dbacc414e 100644
> --- a/drivers/media/platform/renesas-ceu.c
> +++ b/drivers/media/platform/renesas-ceu.c
> @@ -1628,7 +1628,6 @@ static int ceu_probe(struct platform_device *pdev)
> struct device *dev = &pdev->dev;
> const struct ceu_data *ceu_data;
> struct ceu_device *ceudev;
> - struct resource *res;
> unsigned int irq;
> int num_subdevs;
> int ret;
> @@ -1644,8 +1643,7 @@ static int ceu_probe(struct platform_device *pdev)
> spin_lock_init(&ceudev->lock);
> mutex_init(&ceudev->mlock);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ceudev->base = devm_ioremap_resource(dev, res);
> + ceudev->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ceudev->base)) {
> ret = PTR_ERR(ceudev->base);
> goto error_free_ceudev;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-03 14:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 5:55 [PATCH] media: renesas-ceu: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01 11:05 ` Kieran Bingham
2021-09-03 14:26 ` Jacopo Mondi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.