From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF3CBC4321E for ; Thu, 20 Oct 2022 06:23:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230133AbiJTGXd (ORCPT ); Thu, 20 Oct 2022 02:23:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbiJTGXa (ORCPT ); Thu, 20 Oct 2022 02:23:30 -0400 Received: from cpanel.siel.si (cpanel.siel.si [46.19.9.99]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2221D7DF4A; Wed, 19 Oct 2022 23:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=I/afnG2+a4ez2vedQq7/YijcurboxCvkdx39ZZvFVHk=; b=UovpLjUZJLJCJR4gewLl+FP0hw vIoA+7ioenmYj1chWeaaRYs3YR8r6ujLr2h+xKoWHT6ey2bg6WBljx1KOmTr4eQ4uglIq2aSTdOiu pNSHjVv4A32nGOj6fS3y5cVZh7uEiZD5QN577nW48es4daYfH/JFYjlBQ1H7DGmi+zcZbpJtvaWMt 51SH8mjRAQ9nPutO7lZYLFDxZjK+MGHFDd6rZmxfoisrP3XtqnEIDfqdU0dfp4FlrYtMpmPlDP96w LLWaXWf/b7/N22VsVhTr2hNncj6usDpJ8KZhuliuD/DfzGma8sbO1OOv1RPDckzvN0GS8UYXAOc/K gsXnTFxw==; Received: from [89.212.21.243] (port=33888 helo=[192.168.69.85]) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.95) (envelope-from ) id 1olOxY-00Cio8-7W; Thu, 20 Oct 2022 08:23:23 +0200 Message-ID: Date: Thu, 20 Oct 2022 08:23:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 2/3] dt-bindings: watchdog: fsl-imx: document suspend in wait mode Content-Language: en-GB To: Krzysztof Kozlowski , Alexander Stein Cc: linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-imx@nxp.com, festevam@gmail.com, kernel@pengutronix.de, s.hauer@pengutronix.de, wim@linux-watchdog.org, robh+dt@kernel.org References: <20221019111714.1953262-1-andrej.picej@norik.com> <20221019111714.1953262-3-andrej.picej@norik.com> <7508670.GXAFRqVoOG@steina-w> <56118d35-dfe6-f46b-9fc7-28aca6530fb5@linaro.org> From: Andrej Picej In-Reply-To: <56118d35-dfe6-f46b-9fc7-28aca6530fb5@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexander and Krzysztof, hope I can reply to both questions here. On 19. 10. 22 17:51, Krzysztof Kozlowski wrote: > On 19/10/2022 09:00, Alexander Stein wrote: >> Hello Andrej, >> >> Am Mittwoch, 19. Oktober 2022, 13:17:13 CEST schrieb Andrej Picej: > > Missing commit msg. > >>> Signed-off-by: Andrej Picej >>> --- >>> Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>> b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml index >>> fb7695515be1..01b3e04e7e65 100644 >>> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>> @@ -55,6 +55,11 @@ properties: >>> If present, the watchdog device is configured to assert its >>> external reset (WDOG_B) instead of issuing a software reset. >>> >>> + fsl,suspend-in-wait: >>> + $ref: /schemas/types.yaml#/definitions/flag >>> + description: | >>> + If present, the watchdog device is suspended in WAIT mode. >>> + >>> required: >>> - compatible >>> - interrupts >> >> What is the condition the watchdog is suspended in WAIT mode? Is this specific >> to SoC or platform or something else? >> > Sorry, what exactly do you mean by condition? When the property "fsl,suspend-in-wait" is set the watchdog is suspended in WAIT mode, so this is defined by the user. Didn't want to apply it for all the supported machines since there could be devices which depend on watchdog triggering in WAIT mode. We stumbled on this problem on imx6 devices, but the same bit (with the same description) is found on imx25, imx35, imx50/51/53, imx7 and imx8. > And what happens else? When it is not suspended in WAIT mode? > When you put the device in "freeze"/"Suspend-To-Idle" low-power mode the watchdog keeps running and triggers a reset after 128 seconds. So the maximum length the device can stay in this mode is limited to 128 seconds. Hope this answers your questions. Best regards, Andrej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D32BDC433FE for ; Thu, 20 Oct 2022 06:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DZlPSpVVdfUfb70yRgZVQhepOOmF6P7rvjkq4QbCdBo=; b=Um2rariWiXwhtK OSHKoz+rD2Jk3flni07wZym6RsuXkAdxqY9z//eIDywpsvtVQGAn584abyiPUGXK24IR0nwJN5wIG yRCbEz17GodtePhlVhKZl7cgrPO50OCSbS8xBb+mkAkS7NVJmn/hhSsKj3ymbQInJgk0B5yP4LlCx NITzZiDWJchdc53+YeagCAyzmqfuf+fIT4kBh7vupaqWakxir8ZRul/7gf/7/HB3ZIPd4eHst+RtR o/TK/DPoKbLqlBwijGmHHubgCqUi8KWetoblhIypIgEO1n7JHDRB844+I3Vb301YyEfTnClYNILbB UKZsNf74k45eHYPfLsmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olOy4-00B2LP-8L; Thu, 20 Oct 2022 06:23:48 +0000 Received: from cpanel.siel.si ([46.19.9.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olOy0-00B2Je-8i for linux-arm-kernel@lists.infradead.org; Thu, 20 Oct 2022 06:23:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=I/afnG2+a4ez2vedQq7/YijcurboxCvkdx39ZZvFVHk=; b=UovpLjUZJLJCJR4gewLl+FP0hw vIoA+7ioenmYj1chWeaaRYs3YR8r6ujLr2h+xKoWHT6ey2bg6WBljx1KOmTr4eQ4uglIq2aSTdOiu pNSHjVv4A32nGOj6fS3y5cVZh7uEiZD5QN577nW48es4daYfH/JFYjlBQ1H7DGmi+zcZbpJtvaWMt 51SH8mjRAQ9nPutO7lZYLFDxZjK+MGHFDd6rZmxfoisrP3XtqnEIDfqdU0dfp4FlrYtMpmPlDP96w LLWaXWf/b7/N22VsVhTr2hNncj6usDpJ8KZhuliuD/DfzGma8sbO1OOv1RPDckzvN0GS8UYXAOc/K gsXnTFxw==; Received: from [89.212.21.243] (port=33888 helo=[192.168.69.85]) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.95) (envelope-from ) id 1olOxY-00Cio8-7W; Thu, 20 Oct 2022 08:23:23 +0200 Message-ID: Date: Thu, 20 Oct 2022 08:23:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 2/3] dt-bindings: watchdog: fsl-imx: document suspend in wait mode Content-Language: en-GB To: Krzysztof Kozlowski , Alexander Stein Cc: linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org, linux@roeck-us.net, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-imx@nxp.com, festevam@gmail.com, kernel@pengutronix.de, s.hauer@pengutronix.de, wim@linux-watchdog.org, robh+dt@kernel.org References: <20221019111714.1953262-1-andrej.picej@norik.com> <20221019111714.1953262-3-andrej.picej@norik.com> <7508670.GXAFRqVoOG@steina-w> <56118d35-dfe6-f46b-9fc7-28aca6530fb5@linaro.org> From: Andrej Picej In-Reply-To: <56118d35-dfe6-f46b-9fc7-28aca6530fb5@linaro.org> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_232344_506407_48577D3B X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander and Krzysztof, hope I can reply to both questions here. On 19. 10. 22 17:51, Krzysztof Kozlowski wrote: > On 19/10/2022 09:00, Alexander Stein wrote: >> Hello Andrej, >> >> Am Mittwoch, 19. Oktober 2022, 13:17:13 CEST schrieb Andrej Picej: > > Missing commit msg. > >>> Signed-off-by: Andrej Picej >>> --- >>> Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>> b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml index >>> fb7695515be1..01b3e04e7e65 100644 >>> --- a/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>> +++ b/Documentation/devicetree/bindings/watchdog/fsl-imx-wdt.yaml >>> @@ -55,6 +55,11 @@ properties: >>> If present, the watchdog device is configured to assert its >>> external reset (WDOG_B) instead of issuing a software reset. >>> >>> + fsl,suspend-in-wait: >>> + $ref: /schemas/types.yaml#/definitions/flag >>> + description: | >>> + If present, the watchdog device is suspended in WAIT mode. >>> + >>> required: >>> - compatible >>> - interrupts >> >> What is the condition the watchdog is suspended in WAIT mode? Is this specific >> to SoC or platform or something else? >> > Sorry, what exactly do you mean by condition? When the property "fsl,suspend-in-wait" is set the watchdog is suspended in WAIT mode, so this is defined by the user. Didn't want to apply it for all the supported machines since there could be devices which depend on watchdog triggering in WAIT mode. We stumbled on this problem on imx6 devices, but the same bit (with the same description) is found on imx25, imx35, imx50/51/53, imx7 and imx8. > And what happens else? When it is not suspended in WAIT mode? > When you put the device in "freeze"/"Suspend-To-Idle" low-power mode the watchdog keeps running and triggers a reset after 128 seconds. So the maximum length the device can stay in this mode is limited to 128 seconds. Hope this answers your questions. Best regards, Andrej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel