From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v4 4/7] raw/dpaa2_cmdif: introduce DPAA2
 command interface driver
Date: Thu, 3 May 2018 19:40:56 +0530
Message-ID: <d94ace1d-a519-c4bf-80af-a04615598505@nxp.com>
References: <1524737696-3145-1-git-send-email-nipun.gupta@nxp.com>
 <1525281329-27984-1-git-send-email-nipun.gupta@nxp.com>
 <1525281329-27984-5-git-send-email-nipun.gupta@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Nipun Gupta <nipun.gupta@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur03hn0237.outbound.protection.outlook.com [104.47.9.237])
 by dpdk.org (Postfix) with ESMTP id B10EADD2
 for <dev@dpdk.org>; Thu,  3 May 2018 15:54:20 +0200 (CEST)
In-Reply-To: <1525281329-27984-5-git-send-email-nipun.gupta@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wednesday 02 May 2018 10:45 PM, Nipun Gupta wrote:
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> ---
>   MAINTAINERS                                        |   4 +
>   config/common_base                                 |   5 +
>   config/common_linuxapp                             |   1 +
>   drivers/raw/Makefile                               |   1 +
>   drivers/raw/dpaa2_cmdif/Makefile                   |  33 +++++
>   drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c              | 139 +++++++++++++++++++++
>   drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h         |  35 ++++++
>   drivers/raw/dpaa2_cmdif/meson.build                |   7 ++
>   .../dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map    |   4 +
>   drivers/raw/meson.build                            |   2 +-
>   mk/rte.app.mk                                      |   1 +
>   11 files changed, 231 insertions(+), 1 deletion(-)
>   create mode 100644 drivers/raw/dpaa2_cmdif/Makefile
>   create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
>   create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h
>   create mode 100644 drivers/raw/dpaa2_cmdif/meson.build
>   create mode 100644 drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map
> 

[...]

> diff --git a/drivers/raw/dpaa2_cmdif/Makefile b/drivers/raw/dpaa2_cmdif/Makefile
> new file mode 100644
> index 0000000..66f9c0e
> --- /dev/null
> +++ b/drivers/raw/dpaa2_cmdif/Makefile
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright 2018 NXP
> +
> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +#
> +# library name
> +#
> +LIB = librte_pmd_dpaa2_cmdif.a
> +
> +CFLAGS += -DALLOW_EXPERIMENTAL_API
> +CFLAGS += -O3
> +CFLAGS += $(WERROR_FLAGS)
> +
> +CFLAGS += -I$(RTE_SDK)/drivers/bus/fslmc
> +CFLAGS += -I$(RTE_SDK)/drivers/bus/fslmc/qbman/include
> +
> +LDLIBS += -lrte_bus_fslmc
> +LDLIBS += -lrte_eal
> +LDLIBS += -lrte_rawdev
> +LDLIBS += -lrte_bus_vdev
> +LDLIBS += -lrte_kvargs

Shared lib (x86_64 build) fails with dependency on rte_mempool_dpaa2.
Using:

LDLIBS += -lrte_mempool_dpaa2

Succeeds.

> +
> +EXPORT_MAP := rte_pmd_dpaa2_cmdif_version.map
> +
> +LIBABIVER := 1
> +
> +#
> +# all source are stored in SRCS-y
> +#
> +SRCS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_CMDIF_RAWDEV) += dpaa2_cmdif.c
> +
> +include $(RTE_SDK)/mk/rte.lib.mk