From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58142C3A5A1 for ; Sun, 25 Aug 2019 14:12:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BD9020850 for ; Sun, 25 Aug 2019 14:12:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BD9020850 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42818 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1tFq-0003vr-DD for qemu-devel@archiver.kernel.org; Sun, 25 Aug 2019 10:12:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45574) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1tFD-0003ST-AS for qemu-devel@nongnu.org; Sun, 25 Aug 2019 10:11:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1tFC-00037K-7P for qemu-devel@nongnu.org; Sun, 25 Aug 2019 10:11:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55092) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i1tF9-00035z-VU; Sun, 25 Aug 2019 10:11:44 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 504FBA28883; Sun, 25 Aug 2019 14:11:43 +0000 (UTC) Received: from maximlenovopc.usersys.redhat.com (unknown [10.35.206.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id EF20410016EB; Sun, 25 Aug 2019 14:11:36 +0000 (UTC) Message-ID: From: Maxim Levitsky To: "Daniel P." =?ISO-8859-1?Q?Berrang=E9?= Date: Sun, 25 Aug 2019 17:11:36 +0300 In-Reply-To: <20190822103447.GG3267@redhat.com> References: <20190814202219.1870-1-mlevitsk@redhat.com> <20190814202219.1870-4-mlevitsk@redhat.com> <56f412ca-1985-589c-85b4-a8164f701a64@redhat.com> <426e109e6799ba1c9e045541777aeae9183b6134.camel@redhat.com> <20190822103447.GG3267@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Sun, 25 Aug 2019 14:11:43 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 03/13] qcrypto-luks: refactoring: extract load/store/check/parse header functions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 2019-08-22 at 11:34 +0100, Daniel P. Berrang=C3=A9 wrote: > On Thu, Aug 22, 2019 at 01:43:05AM +0300, Maxim Levitsky wrote: > > On Tue, 2019-08-20 at 20:01 +0200, Max Reitz wrote: > > > On 14.08.19 22:22, Maxim Levitsky wrote: > > > > With upcoming key management, the header will > > > > need to be stored after the image is created. > > > >=20 > > > > Extracting load header isn't strictly needed, but > > > > do this anyway for the symmetry. > > > >=20 > > > > Also I extracted a function that does basic sanity > > > > checks on the just read header, and a function > > > > which parses all the crypto format to make the > > > > code a bit more readable, plus now the code > > > > doesn't destruct the in-header cipher-mode string, > > > > so that the header now can be stored many times, > > > > which is needed for the key management. > > > >=20 > > > > Also this allows to contain the endianess conversions > > > > in these functions alone > > > >=20 > > > > The header is no longer endian swapped in place, > > > > to prevent (mostly theoretical races I think) > > > > races where someone could see the header in the > > > > process of beeing byteswapped. > > >=20 > > > The formatting looks weird, it doesn=E2=80=99t look quite 72 charac= ters wide... > > > (what commit messages normally use) > >=20 > > Could you elaborate on that? I thought that code should not > > exceed 80 character limit. > >=20 > > >=20 > > > > Signed-off-by: Maxim Levitsky > > > > --- > > > > crypto/block-luks.c | 756 ++++++++++++++++++++++++++------------= ------ > > > > 1 file changed, 440 insertions(+), 316 deletions(-) > > >=20 > > > Also, this commit is just too big. > >=20 > > Yea, but it has no functional changes. > > I can split it further, but that won't help much IMHO. >=20 > I'd find it easier to review if each newly introduced method was a > separate patch. It makes it easier to see which bit of removed > code was added to which method. >=20 > Regards, > Daniel Done, patch is now split in several patches. Best regards, Maxim Levitsky