From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD9FC433C1 for ; Wed, 31 Mar 2021 00:55:46 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id AB5B861864 for ; Wed, 31 Mar 2021 00:55:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB5B861864 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB26D406A3; Wed, 31 Mar 2021 02:55:44 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 56C724069E for ; Wed, 31 Mar 2021 02:55:43 +0200 (CEST) Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F979D54x1z19K5P; Wed, 31 Mar 2021 08:53:36 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Wed, 31 Mar 2021 08:55:40 +0800 To: Ferruh Yigit , CC: Aaron Conole , Honnappa Nagarahalli , David Marchand , Thomas Monjalon References: <1616507156-35880-1-git-send-email-humin29@huawei.com> <1616507156-35880-3-git-send-email-humin29@huawei.com> From: "Min Hu (Connor)" Message-ID: Date: Wed, 31 Mar 2021 08:55:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 2/6] net/hns3: fix compiling error for using SVE algorithm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/3/30 0:10, Ferruh Yigit 写道: > On 3/23/2021 1:45 PM, Min Hu (Connor) wrote: >> From: Huisong Li >> >> The 'queue_full_cnt' stats have been encapsulated in 'dfx_stats'. >> However, the modification in the SVE algorithm is omitted. >> As a result, the driver fails to be compiled when the SVE >> algorithm is used. >> >> Fixes: 9b77f1fe303f ("net/hns3: encapsulate DFX stats in datapath") >> >> Signed-off-by: Huisong Li >> Signed-off-by: Min Hu (Connor) >> --- >>   drivers/net/hns3/hns3_rxtx_vec_sve.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c >> b/drivers/net/hns3/hns3_rxtx_vec_sve.c >> index f8655fa..e1a1731 100644 >> --- a/drivers/net/hns3/hns3_rxtx_vec_sve.c >> +++ b/drivers/net/hns3/hns3_rxtx_vec_sve.c >> @@ -439,7 +439,7 @@ hns3_xmit_fixed_burst_vec_sve(void *__restrict >> tx_queue, >>       nb_pkts = RTE_MIN(txq->tx_bd_ready, nb_pkts); >>       if (unlikely(nb_pkts == 0)) { >> -        txq->queue_full_cnt++; >> +        txq->dfx_stats.queue_full_cnt++; >>           return 0; >>       } >> > > Hi Connor, > > This is a very obvious build error, I am concerned how this is released. > Do you have any internal testing? > Hi Ferruh, Well, we admit it is our mistake for this issue. Let me describe the reason: Firstly, we must declare that we have our inner CI system for building and testing. While when we upstream the ""support SVE" patch, our CI does not support SVE building. Instead we build and test SVE on our local platform. Then when we upstream the "encapsulate DFX stats in datapath" patch, we only build it in CI(at that time, SVE building is still not supported), regardless of SVE building on local platform. Now, SVE building is supported in our CI， So the building error occurs. We'll pay more attention to the issue in the future. Thanks. > + Aaron & Honnappa, > > If we can have a build test in our public CI with SVE? > > > .