From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Sat, 22 Jun 2019 21:24:26 +0200
Subject: [U-Boot] [PATCH 1/1] disk: part: avoid undefined reference to
 `__udivmoddi4'
In-Reply-To: <CAPnjgZ1CmMbaDzJYruKo4+NyFkpoK5NKE_tg+4WiOfuEQc-FsQ@mail.gmail.com>
References: <20190602083551.3207-1-xypron.glpk@gmx.de>
 <CAPnjgZ1CmMbaDzJYruKo4+NyFkpoK5NKE_tg+4WiOfuEQc-FsQ@mail.gmail.com>
Message-ID: <d9539387-6bbc-cb6e-ddd4-0b70b3f3f67c@gmx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 6/22/19 9:10 PM, Simon Glass wrote:
> On Sun, 2 Jun 2019 at 09:36, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>>
>> When compiling with FTRACE=1 an error
>>
>> ld.bfd: disk/built-in.o: in function `lba512_muldiv':
>> disk/part.c:114: undefined reference to `__udivmoddi4
>>
>> occurred.
>>
>> Use '>> 11' instead of '/ 2048' to avoid the division.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>>   disk/part.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> Looks OK but I think you should rename div_by to shift_right, or similar.

Thanks for reviewing.

The patch is already merged. I will send a new patch to rename the
parameter.

Regards

Heinrcih