From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp0.taitradio.net (unknown [202.37.96.22]) by mail.openembedded.org (Postfix) with SMTP id A50127D2F9 for ; Thu, 6 Jun 2019 21:03:31 +0000 (UTC) Received: from [172.16.169.141] (unknown [172.16.169.141]) by smtp0.taitradio.net (Postfix) with ESMTP id DA27A220229; Fri, 7 Jun 2019 09:03:31 +1200 (NZST) To: "Burton, Ross" References: <20190606020544.26181-1-douglas.royds@taitradio.com> From: Douglas Royds Message-ID: Date: Fri, 7 Jun 2019 09:03:31 +1200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Cc: OE-core Subject: Re: [PATCH] json-c: Disable icecc to avoid implicit-fallthrough warning as error X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jun 2019 21:03:32 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB I struggled to find a solution that would work in the -native case, as we need to support gcc as old as 5.4 (Ubuntu 16.04). The problem is somewhat specific to json-c, as -Werror is hard-coded into configure.ac in this package. On 6/06/19 9:45 PM, Burton, Ross wrote: > Considering the pain that the gcc upgrade introducing that warning > caused I'll be *very* surprised if this problem is limited to json-c. > Could the icecc class forcibly disable that warning instead? > > Ross > > On Thu, 6 Jun 2019 at 03:06, Douglas Royds via Openembedded-core > wrote: >> icecc preprocesses source files locally before shipping them off to be compiled >> on remote hosts. This preprocessing removes comments, including /* fallthrough */ >> comments in switch statements that normally prevent the implicit-fallthrough >> warning. >> >> Rather than turning off -Werror by patching configure.ac, it is simpler to >> disable icecc completely for json-c. There are very few source files to compile, >> so the compilation is quick even without icecc. >> >> See https://github.com/icecc/icecream/issues/419 >> >> Signed-off-by: Douglas Royds >> --- >> meta/recipes-devtools/json-c/json-c_0.13.1.bb | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/meta/recipes-devtools/json-c/json-c_0.13.1.bb b/meta/recipes-devtools/json-c/json-c_0.13.1.bb >> index 5b10e68297..8d2a20352d 100644 >> --- a/meta/recipes-devtools/json-c/json-c_0.13.1.bb >> +++ b/meta/recipes-devtools/json-c/json-c_0.13.1.bb >> @@ -21,6 +21,7 @@ RPROVIDES_${PN} = "libjson" >> inherit autotools >> >> EXTRA_OECONF = "--enable-rdrand" >> +ICECC_DISABLED = "1" >> >> do_configure_prepend() { >> # Clean up autoconf cruft that should not be in the tarball >> -- >> 2.17.1 >> >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core