All of lore.kernel.org
 help / color / mirror / Atom feed
From: "xiaoqiang.zhao" <zxq_yx_007@163.com>
To: Eric Blake <eblake@redhat.com>,
	berrange@redhat.com, marcandre.lureau@redhat.com,
	kwolf@redhat.com, armbru@redhat.com
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org,
	kraxel@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH v3 1/3] qemu-sockets: add abstract UNIX domain socket support
Date: Tue, 12 May 2020 14:52:20 +0800	[thread overview]
Message-ID: <d9600083-303f-2e55-a0f0-86548774d55b@163.com> (raw)
In-Reply-To: <0ead3ac4-efa3-b773-f5c3-7aa055e2af18@redhat.com>

在 2020/5/12 上午2:01, Eric Blake 写道:
> On 5/10/20 1:14 AM, xiaoqiang zhao wrote:
>> unix_listen/connect_saddr now support abstract address types
>>
>> two aditional BOOL switches are introduced:
>> tight: whether to set @addrlen to the minimal string length,
>>         or the maximum sun_path length. default is TRUE
>> abstract: whether we use abstract address. default is FALSE
>>
>> cli example:
>> -monitor unix:/tmp/unix.socket,abstract,tight=off
>> OR
>> -chardev socket,path=/tmp/unix.socket,id=unix1,abstract,tight=on
>>
>> Signed-off-by: xiaoqiang zhao <zxq_yx_007@163.com>
>> ---
>
>> +++ b/qapi/sockets.json
>> @@ -73,12 +73,19 @@
>>   # Captures a socket address in the local ("Unix socket") namespace.
>>   #
>>   # @path: filesystem path to use
>> +# @tight: pass a socket address length that does not include the whole
>> +#         struct sockaddr_un record but (besides other components) only
>> +#         the relevant part of the filename or abstract string.
>> +#         default value is 'true'
>
> Perhaps:
>
> pass a socket address length confined to the minimum length of the 
> abstract string, rather than the full sockaddr_un record length (only 
> matters for abstract sockets, default true)
>
Sounds better
>> +# @abstract: whether this is a abstract address, default is 'false'
>
> Both new fields should have a '(since 5.1)' tag, to make it obvious 
> that they did not exist in earlier releases with the rest of the struct.
>
> s/a abstract/an abstract/
>
Will fix in the next version,  thanks Eric.



  reply	other threads:[~2020-05-12  6:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-10  6:14 [PATCH v3 0/3] " xiaoqiang zhao
2020-05-10  6:14 ` [PATCH v3 1/3] " xiaoqiang zhao
2020-05-11 18:01   ` Eric Blake
2020-05-12  6:52     ` xiaoqiang.zhao [this message]
2020-05-13 15:52   ` Daniel P. Berrangé
2020-05-10  6:14 ` [PATCH v3 2/3] tests/util-sockets: add abstract unix socket cases xiaoqiang zhao
2020-05-13 15:49   ` Daniel P. Berrangé
2020-05-14  0:26     ` xiaoqiang zhao
2020-05-10  6:14 ` [PATCH v3 3/3] qemu-options: updates for abstract unix sockets xiaoqiang zhao
2020-05-13 15:50   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9600083-303f-2e55-a0f0-86548774d55b@163.com \
    --to=zxq_yx_007@163.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --subject='Re: [PATCH v3 1/3] qemu-sockets: add abstract UNIX domain socket support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.