From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
George Dunlap <george.dunlap@citrix.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
WeiLiu <wei.liu2@citrix.com>,
"George Dunlap" <George.Dunlap@eu.citrix.com>,
"Tim Deegan" <tim@xen.org>,
IanJackson <ian.jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH] build: Rename as-insn-check to as-insn-add
Date: Fri, 23 Feb 2018 11:40:34 +0000 [thread overview]
Message-ID: <d96c7a7f-c82c-a982-5603-e306681c8693@citrix.com> (raw)
In-Reply-To: <5A8ED62402000078001AA691@prv-mh.provo.novell.com>
On 22/02/18 13:39, Jan Beulich wrote:
>>>> On 22.02.18 at 13:39, <george.dunlap@citrix.com> wrote:
>> On 02/22/2018 12:22 PM, Jan Beulich wrote:
>>>>>> On 22.02.18 at 12:41, <andrew.cooper3@citrix.com> wrote:
>>>> On 22/02/18 11:33, Jan Beulich wrote:
>>>>>>>> On 22.02.18 at 11:51, <andrew.cooper3@citrix.com> wrote:
>>>>>> as-insn-check mutates the passed-in flags. Rename it to as-insn-add, in line
>>>>>> with cc-option-add. Update all callers.
>>>>> I'm not convinced - cc-option-add makes relatively clear that
>>>>> something is being added to the options passed to CC. If I
>>>>> take as-insn-add this way, the macro would need to add an
>>>>> insn to the AS invocation. While I agree as-insn-check doesn't
>>>>> make clear that it adds any options, I still find this less
>>>>> misleading than the suggested new name. Let's see what
>>>>> others think.
>>>> I'm open to better name suggestions.
>>> The best I can come up with is, well, as-insn-check, as that
>>> reasonably describes at least part of what the construct does.
>>> as-insn-check-and-add-option, besides being too long, isn't
>>> meaningfully better.
>> We're definitely getting into bikeshed territory here.
> Indeed, but I think a change in name should be an improvement,
> not going from one questionable name to another questionable
> one.
>
>> I agree with
>> Andy that 'check' doesn't really convey that something changed. Is the
>> check-and-add "add it if it doesn't exist already"? Or add it if some
>> other check passes / fails?
> It is "check if this piece of assembly assembles and add the
> provided option to the indicated variable", extended by Roger's
> patch to "..., and add the other provided option if it doesn't
> assemble".
Ok - how do we unblock this?
There appears to be agreement that as-insn-check isn't a great name, and
my proposed as-insn-add isn't much better.
The base runes of as-insn and cc-option are compatible. They check the
fragment, and yield one of two options. cc-option-add and as-insn-check
are built on top of the base runes, and mutate the flags passed in.
as-check-frag-update-option ?
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-23 11:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 10:51 [PATCH] build: Rename as-insn-check to as-insn-add Andrew Cooper
2018-02-22 11:33 ` Jan Beulich
2018-02-22 11:41 ` Andrew Cooper
2018-02-22 12:22 ` Jan Beulich
2018-02-22 12:39 ` George Dunlap
2018-02-22 13:39 ` Jan Beulich
2018-02-23 11:40 ` Andrew Cooper [this message]
2018-02-23 11:46 ` Roger Pau Monné
2018-02-23 11:47 ` Ian Jackson
2018-02-23 11:58 ` Jan Beulich
2018-02-23 12:37 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d96c7a7f-c82c-a982-5603-e306681c8693@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.