From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfvZ5-00019g-DA for qemu-devel@nongnu.org; Mon, 20 Feb 2017 16:32:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cfvZ2-0005I9-AJ for qemu-devel@nongnu.org; Mon, 20 Feb 2017 16:32:11 -0500 Received: from mail-db5eur01on0130.outbound.protection.outlook.com ([104.47.2.130]:62462 helo=EUR01-DB5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cfvZ1-0005HL-Oa for qemu-devel@nongnu.org; Mon, 20 Feb 2017 16:32:08 -0500 References: <1487614915-18710-1-git-send-email-den@openvz.org> <1487614915-18710-3-git-send-email-den@openvz.org> <7e55a8e9-0a5d-5602-7626-9c7976f6a49c@redhat.com> From: "Denis V. Lunev" Message-ID: Date: Mon, 20 Feb 2017 20:58:38 +0100 MIME-Version: 1.0 In-Reply-To: <7e55a8e9-0a5d-5602-7626-9c7976f6a49c@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] qapi: flatten GuestPanicInformation union List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Anton Nefedov , Paolo Bonzini , Roman Kagan , Evgeniy Yakovlev On 02/20/2017 08:48 PM, Eric Blake wrote: > On 02/20/2017 12:21 PM, Denis V. Lunev wrote: >> From: Anton Nefedov >> >> Signed-off-by: Anton Nefedov >> Signed-off-by: Denis V. Lunev >> CC: Paolo Bonzini >> CC: Eric Blake >> --- >> qapi-schema.json | 12 ++++++++++++ >> target/i386/cpu.c | 15 ++++++--------- >> vl.c | 12 ++++++------ >> 3 files changed, 24 insertions(+), 15 deletions(-) >> >> diff --git a/qapi-schema.json b/qapi-schema.json >> index e9a6364..b142e15 100644 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -5872,6 +5872,16 @@ >> 'data': [ 'pause', 'poweroff' ] } >> >> ## >> +# @GuestPanicInformationType: >> +# >> +# An enumeration of the guest panic information types >> +# >> +# Since: 2.9 >> +## >> +{ 'enum': 'GuestPanicInformationType', >> + 'data': [ 'hyper-v'] } > Perhaps 'hyperv' is better? It's the difference between > GUEST_PANIC_INFORMATION_TYPE_HYPER_V and > GUEST_PANIC_INFORMATION_TYPE_HYPERV. But that's bikeshedding, so no need > to change it. > > Must go into 2.9, so we aren't baking in bad API. > > Reviewed-by: Eric Blake > We can you plain 'hv', like all command line options controlling HyperV features. Roman, Evgeniy, do you have any opinion on that? Den