From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C008EC433F5 for ; Tue, 29 Mar 2022 11:38:12 +0000 (UTC) Received: from localhost ([::1]:33976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZAAt-0000Hd-OJ for qemu-devel@archiver.kernel.org; Tue, 29 Mar 2022 07:38:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZA8V-0006q1-Jl for qemu-devel@nongnu.org; Tue, 29 Mar 2022 07:35:43 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:54933) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZA8S-0002kj-No for qemu-devel@nongnu.org; Tue, 29 Mar 2022 07:35:42 -0400 Received: from [192.168.100.1] ([82.142.13.234]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MeTwY-1o9JlN1Eou-00aTk3; Tue, 29 Mar 2022 13:35:21 +0200 Message-ID: Date: Tue, 29 Mar 2022 13:35:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH for-7.0 v5] qemu-binfmt-conf.sh: mips: allow nonzero EI_ABIVERSION, distinguish o32 and n32 Content-Language: fr To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , =?UTF-8?Q?Andreas_K=2e_H=c3=bcttel?= , qemu-devel@nongnu.org References: <20220328204900.3914990-1-dilfridge@gentoo.org> From: Laurent Vivier In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:NfHkpyPun85OPE7MPyqxBVBYFzwsMrogNHpqaZzkHfdfeHXq22X WXIDzN0qFcebWFCHohxVNZi4NclZEprUT9FpqZSJTaNZSs3e0bguORWM2QnF1wnr4Xxf0zC vu1Ur16N2sQD4bmYe6xGZCRM3tBUOySaErTr9Batyk6EpYVTLCE+sM1DMd4gIRJVhis2P1J xj48fRqaptyY1k5YOVwIw== X-UI-Out-Filterresults: notjunk:1;V03:K0:zk47haZmssE=:chPD25orgQmC+rsx3lQylR n5swuyrh4WuiIeBtQkOcIJ04/d+TaAQtc1jTbSwEEjCN2FXyk3bprkc7hLAYALiF8BcE8MXmh CbWMFhMZ1Nnb3/axnSTNyH6f7SduElFOdhGppwHnZDGVJem88fP60Jy3ByDEBBNBBodrODm99 74miQ+UXRyCGAZcKGNkoTtPdcTmtaS+N+7JYa4o4g89tqKQV8GvIHJjWXTrz47AKWhFIG/XEo kCYXutIrW7ozlYbs+TiId3Jmtuv7cZTTqaUAqw7dO706iWIT9PiwA1MqZfGgC7cGqLfioWQap jA9tEBD+DP0ZhGau0+FANYGtIacM7PWkSLLD4maESkAuX+K8dyrm+lbxgiGqr/l5L3jPQU77Q RdSc4SpUCUVowYJQffcUO2bSPES9dCrgH6e4Bs4eaYgDQmnVHCnRwaeIxGFmYli/QRieuyQyF uKTmtzCxPAZTYb2qW7KBSAY6CRyDNI/4GwCnt3g+FASOZawXWEgM/h36hrgEu37+T/cx7+lvs CSXN11BGySaap7VJN2M7Hp/8ywlwvk9KdH4fOndb/3fqRtNrmOw8EdOMiBG8mPfskqh289/Bk XzY/yN4sp2KYEQ/exbTfzAuCAYzDM6Dh7VgV3OFVgK3nEo6Wj8r2OXxQBfha3e1YUevkO0Hvb 7QuV6NKgQKKiUmDaeMLiHRNHQOTD0JFALfGv85m9bsd+A9jzpem95DXidpio6ErqLJAY= Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Bennee , WANG Xuerui , Richard Henderson , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 29/03/2022 à 01:39, Philippe Mathieu-Daudé a écrit : > On 28/3/22 22:49, Andreas K. Hüttel wrote: >> With the command line flag -mplt and a recent toolchain, ELF binaries >> generated by gcc can obtain EI_ABIVERSION=1, which makes, e.g., gcc >> three-stage bootstrap in a mips-unknown-linux-gnu qemu-user chroot >> fail since the binfmt-misc magic does not match anymore. Also other >> values are technically possible. qemu executes these binaries just >> fine, so relax the mask for the EI_ABIVERSION byte at offset 0x08. >> >> In addition, extend magic string to distinguish mips o32 and n32 ABI. >> This information is given by the EF_MIPS_ABI2 (0x20) bit in the >> e_flags field of the ELF header (a 4-byte value at offset 0x24 for >> the here applicable ELFCLASS32). >> >> See-also: ace3d65459 >> Signed-off-by: Andreas K. Hüttel >> Reviewed-by: Philippe Mathieu-Daudé >> Reviewed-by: WANG Xuerui > > v5 changes are too different from v4 to keep these R-b tags IMO. > > LGTM but I'd like Xuerui to double-check the R-b stands, > and an Acked-by from Laurent would make me feel safer ;) Sorry, I didn't see your email before. It's more mips than linux-user, so there is no problem for me. Thanks, Laurent