From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.29.96]:41552 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932526AbeFGIa2 (ORCPT ); Thu, 7 Jun 2018 04:30:28 -0400 Subject: Re: [PATCH v2] arm64: dts: msm8996: Use dwc3-qcom glue driver for USB References: <20180531104710.23965-1-mgautam@codeaurora.org> From: Vivek Gautam Message-ID: Date: Thu, 7 Jun 2018 14:00:21 +0530 MIME-Version: 1.0 In-Reply-To: <20180531104710.23965-1-mgautam@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: devicetree-owner@vger.kernel.org To: Manu Gautam , andy.gross@linaro.org Cc: linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dianders@chromium.org, linux-usb@vger.kernel.org, felipe.balbi@linux.intel.com, gregkh@linuxfoundation.org, bjorn.andersson@linaro.org List-ID: On 5/31/2018 4:17 PM, Manu Gautam wrote: > Move from dwc3-of-simple to dwc3-qcom glue driver to > support peripheral mode which requires qscratch wrapper > programming on VBUS event. > > Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver") > Signed-off-by: Manu Gautam > --- > > Changes since v1: > - Update unit address of DT node as per Doug's comment > > arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 6 ++++-- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 10 ++++++---- > 2 files changed, 10 insertions(+), 6 deletions(-) Tested on DB820c. Works fine. Tested-by: Vivek Gautam BRs Vivek > > diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi > index f45a0ab30d30..00be0d53891a 100644 > --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi > +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi > @@ -106,8 +106,9 @@ > status = "okay"; > }; > > - usb@6a00000 { > + usb@6af8800 { > status = "okay"; > + extcon = <&usb3_id>; > > dwc3@6a00000 { > extcon = <&usb3_id>; > @@ -122,8 +123,9 @@ > pinctrl-0 = <&usb3_vbus_det_gpio>; > }; > > - usb@7600000 { > + usb@76f8800 { > status = "okay"; > + extcon = <&usb2_id>; > > dwc3@7600000 { > extcon = <&usb2_id>; > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 26292027ba9b..8b6dd5443524 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -776,8 +776,9 @@ > status = "disabled"; > }; > > - usb2: usb@7600000 { > - compatible = "qcom,dwc3"; > + usb2: usb@76f8800 { > + compatible = "qcom,msm8996-dwc3", "qcom,dwc3"; > + reg = <0x76f8800 0x400>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -804,8 +805,9 @@ > }; > }; > > - usb3: usb@6a00000 { > - compatible = "qcom,dwc3"; > + usb3: usb@6af8800 { > + compatible = "qcom,msm8996-dwc3", "qcom,dwc3"; > + reg = <0x6af8800 0x400>; > #address-cells = <1>; > #size-cells = <1>; > ranges; From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] arm64: dts: msm8996: Use dwc3-qcom glue driver for USB From: Vivek Gautam Message-Id: Date: Thu, 7 Jun 2018 14:00:21 +0530 To: Manu Gautam , andy.gross@linaro.org Cc: linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dianders@chromium.org, linux-usb@vger.kernel.org, felipe.balbi@linux.intel.com, gregkh@linuxfoundation.org, bjorn.andersson@linaro.org List-ID: T24gNS8zMS8yMDE4IDQ6MTcgUE0sIE1hbnUgR2F1dGFtIHdyb3RlOgo+IE1vdmUgZnJvbSBkd2Mz LW9mLXNpbXBsZSB0byBkd2MzLXFjb20gZ2x1ZSBkcml2ZXIgdG8KPiBzdXBwb3J0IHBlcmlwaGVy YWwgbW9kZSB3aGljaCByZXF1aXJlcyBxc2NyYXRjaCB3cmFwcGVyCj4gcHJvZ3JhbW1pbmcgb24g VkJVUyBldmVudC4KPgo+IEZpeGVzOiBhNDMzM2MzYTZiYTkgKCJ1c2I6IGR3YzM6IEFkZCBRdWFs Y29tbSBEV0MzIGdsdWUgZHJpdmVyIikKPiBTaWduZWQtb2ZmLWJ5OiBNYW51IEdhdXRhbSA8bWdh dXRhbUBjb2RlYXVyb3JhLm9yZz4KPiAtLS0KPgo+IENoYW5nZXMgc2luY2UgdjE6Cj4gICAtIFVw ZGF0ZSB1bml0IGFkZHJlc3Mgb2YgRFQgbm9kZSBhcyBwZXIgRG91ZydzIGNvbW1lbnQKPgo+ICAg YXJjaC9hcm02NC9ib290L2R0cy9xY29tL2FwcTgwOTYtZGI4MjBjLmR0c2kgfCAgNiArKysrLS0K PiAgIGFyY2gvYXJtNjQvYm9vdC9kdHMvcWNvbS9tc204OTk2LmR0c2kgICAgICAgIHwgMTAgKysr KysrLS0tLQo+ICAgMiBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9u cygtKQoKVGVzdGVkIG9uIERCODIwYy4gV29ya3MgZmluZS4KVGVzdGVkLWJ5OiBWaXZlayBHYXV0 YW0gPHZpdmVrLmdhdXRhbUBjb2RlYXVyb3JhLm9yZz4KCkJScwpWaXZlawo+Cj4gZGlmZiAtLWdp dCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcWNvbS9hcHE4MDk2LWRiODIwYy5kdHNpIGIvYXJjaC9h cm02NC9ib290L2R0cy9xY29tL2FwcTgwOTYtZGI4MjBjLmR0c2kKPiBpbmRleCBmNDVhMGFiMzBk MzAuLjAwYmUwZDUzODkxYSAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3Fjb20v YXBxODA5Ni1kYjgyMGMuZHRzaQo+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcWNvbS9hcHE4 MDk2LWRiODIwYy5kdHNpCj4gQEAgLTEwNiw4ICsxMDYsOSBAQAo+ICAgCQkJc3RhdHVzID0gIm9r YXkiOwo+ICAgCQl9Owo+ICAgCj4gLQkJdXNiQDZhMDAwMDAgewo+ICsJCXVzYkA2YWY4ODAwIHsK PiAgIAkJCXN0YXR1cyA9ICJva2F5IjsKPiArCQkJZXh0Y29uID0gPCZ1c2IzX2lkPjsKPiAgIAo+ ICAgCQkJZHdjM0A2YTAwMDAwIHsKPiAgIAkJCQlleHRjb24gPSA8JnVzYjNfaWQ+Owo+IEBAIC0x MjIsOCArMTIzLDkgQEAKPiAgIAkJCXBpbmN0cmwtMCA9IDwmdXNiM192YnVzX2RldF9ncGlvPjsK PiAgIAkJfTsKPiAgIAo+IC0JCXVzYkA3NjAwMDAwIHsKPiArCQl1c2JANzZmODgwMCB7Cj4gICAJ CQlzdGF0dXMgPSAib2theSI7Cj4gKwkJCWV4dGNvbiA9IDwmdXNiMl9pZD47Cj4gICAKPiAgIAkJ CWR3YzNANzYwMDAwMCB7Cj4gICAJCQkJZXh0Y29uID0gPCZ1c2IyX2lkPjsKPiBkaWZmIC0tZ2l0 IGEvYXJjaC9hcm02NC9ib290L2R0cy9xY29tL21zbTg5OTYuZHRzaSBiL2FyY2gvYXJtNjQvYm9v dC9kdHMvcWNvbS9tc204OTk2LmR0c2kKPiBpbmRleCAyNjI5MjAyN2JhOWIuLjhiNmRkNTQ0MzUy NCAxMDA2NDQKPiAtLS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL3Fjb20vbXNtODk5Ni5kdHNpCj4g KysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9xY29tL21zbTg5OTYuZHRzaQo+IEBAIC03NzYsOCAr Nzc2LDkgQEAKPiAgIAkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4gICAJCX07Cj4gICAKPiAtCQl1 c2IyOiB1c2JANzYwMDAwMCB7Cj4gLQkJCWNvbXBhdGlibGUgPSAicWNvbSxkd2MzIjsKPiArCQl1 c2IyOiB1c2JANzZmODgwMCB7Cj4gKwkJCWNvbXBhdGlibGUgPSAicWNvbSxtc204OTk2LWR3YzMi LCAicWNvbSxkd2MzIjsKPiArCQkJcmVnID0gPDB4NzZmODgwMCAweDQwMD47Cj4gICAJCQkjYWRk cmVzcy1jZWxscyA9IDwxPjsKPiAgIAkJCSNzaXplLWNlbGxzID0gPDE+Owo+ICAgCQkJcmFuZ2Vz Owo+IEBAIC04MDQsOCArODA1LDkgQEAKPiAgIAkJCX07Cj4gICAJCX07Cj4gICAKPiAtCQl1c2Iz OiB1c2JANmEwMDAwMCB7Cj4gLQkJCWNvbXBhdGlibGUgPSAicWNvbSxkd2MzIjsKPiArCQl1c2Iz OiB1c2JANmFmODgwMCB7Cj4gKwkJCWNvbXBhdGlibGUgPSAicWNvbSxtc204OTk2LWR3YzMiLCAi cWNvbSxkd2MzIjsKPiArCQkJcmVnID0gPDB4NmFmODgwMCAweDQwMD47Cj4gICAJCQkjYWRkcmVz cy1jZWxscyA9IDwxPjsKPiAgIAkJCSNzaXplLWNlbGxzID0gPDE+Owo+ICAgCQkJcmFuZ2VzOwot LS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2Ny aWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2Vy Lmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9y Zy9tYWpvcmRvbW8taW5mby5odG1sCg==