All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.com
Subject: [PATCH] btrfs-progs: fix inspect-internal --help incomplete sentence
Date: Fri, 19 Mar 2021 14:46:52 +0800	[thread overview]
Message-ID: <d9905452906eea5e8ac5b569e92df3c48861d734.1616136002.git.anand.jain@oracle.com> (raw)

btrfs inspect-internal --help show some incomplete sentenses. As shown
below,

  btrfs inspect-internal --help
  <snip>
      btrfs inspect-internal min-dev-size [options] <path>
          Get the minimum size the device can be shrunk to. The
      btrfs inspect-internal dump-tree [options] <device> [<device> ..]
  <snip>

This patch just fixes it.

Also, the consistency is missing whether to add a period after the
one-line statement of the btrfs --help output.
So while here, this patch adds a period at the end of the help
statement and makes it consistent within the command
btrfs inspect-internal --help.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 cmds/inspect.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/cmds/inspect.c b/cmds/inspect.c
index 15f19c8a3027..fcb3b1ae1321 100644
--- a/cmds/inspect.c
+++ b/cmds/inspect.c
@@ -80,7 +80,7 @@ out:
 
 static const char * const cmd_inspect_inode_resolve_usage[] = {
 	"btrfs inspect-internal inode-resolve [-v] <inode> <path>",
-	"Get file system paths for the given inode",
+	"Get file system paths for the given inode.",
 	"",
 	"-v   deprecated, alias for global -v option",
 	HELPINFO_INSERT_GLOBALS,
@@ -126,7 +126,7 @@ static DEFINE_SIMPLE_COMMAND(inspect_inode_resolve, "inode-resolve");
 
 static const char * const cmd_inspect_logical_resolve_usage[] = {
 	"btrfs inspect-internal logical-resolve [-Pvo] [-s bufsize] <logical> <path>",
-	"Get file system paths for the given logical address",
+	"Get file system paths for the given logical address.",
 	"",
 	"-P          skip the path resolving and print the inodes instead",
 	"-o          ignore offsets when matching references (requires v2 ioctl",
@@ -389,9 +389,9 @@ static DEFINE_SIMPLE_COMMAND(inspect_rootid, "rootid");
 
 static const char* const cmd_inspect_min_dev_size_usage[] = {
 	"btrfs inspect-internal min-dev-size [options] <path>",
-	"Get the minimum size the device can be shrunk to. The",
-	"device id 1 is used by default.",
+	"Get the minimum size the device can be shrunk to.",
 	"",
+	"The device id 1 is used by default.",
 	"--id DEVID   specify the device id to query",
 	NULL
 };
-- 
2.29.2


             reply	other threads:[~2021-03-19  6:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19  6:46 Anand Jain [this message]
2021-03-19  7:10 ` [PATCH v2] btrfs-progs: fix inspect-internal --help incomplete sentence Anand Jain
2021-05-17  8:47   ` Anand Jain
2021-05-17 12:28   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9905452906eea5e8ac5b569e92df3c48861d734.1616136002.git.anand.jain@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.