From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 221F8C64E7B for ; Tue, 1 Dec 2020 12:32:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 77A342084C for ; Tue, 1 Dec 2020 12:32:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77A342084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B6A9B8D0005; Tue, 1 Dec 2020 07:32:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B1ACD8D0001; Tue, 1 Dec 2020 07:32:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A08C08D0005; Tue, 1 Dec 2020 07:32:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 892B68D0001 for ; Tue, 1 Dec 2020 07:32:45 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 53852824999B for ; Tue, 1 Dec 2020 12:32:45 +0000 (UTC) X-FDA: 77544652290.07.mice74_4609e21273aa Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 3733F1803F9D9 for ; Tue, 1 Dec 2020 12:32:45 +0000 (UTC) X-HE-Tag: mice74_4609e21273aa X-Filterd-Recvd-Size: 5763 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Dec 2020 12:32:44 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7B45BACC1; Tue, 1 Dec 2020 12:32:43 +0000 (UTC) Message-ID: Subject: Re: [linux-next:master 6272/9613] unittest.c:undefined reference to `of_dma_get_max_cpu_address' From: Nicolas Saenz Julienne To: Catalin Marinas , kernel test robot Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, Linux Memory Management List , Rob Herring Date: Tue, 01 Dec 2020 13:32:42 +0100 In-Reply-To: <20201201122915.GC31404@gaia> References: <202012011747.PIcmivAO-lkp@intel.com> <20201201122915.GC31404@gaia> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-uo/JAf+iWfTLbgcMzge/" User-Agent: Evolution 3.38.1 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=-uo/JAf+iWfTLbgcMzge/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2020-12-01 at 12:29 +0000, Catalin Marinas wrote: > On Tue, Dec 01, 2020 at 05:32:51PM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git master > > head: c6b11acc5f85b6e11d128fad8e0b7b223aa7e33f > > commit: 07d13a1d6120d453c3c1f020578693d072deded5 [6272/9613] of: unitte= st: Add test for of_dma_get_max_cpu_address() > > config: s390-randconfig-r034-20201201 (attached as .config) > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ac= 40a2d8f16b8a8c68fc811d67f647740e965cb8) > > reproduce (this is a W=3D1 build): > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0wget https://raw.github= usercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0chmod +x ~/bin/make.cro= ss > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0# install s390 cross co= mpiling tool for clang build > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0# apt-get install binut= ils-s390x-linux-gnu > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0# https://git.kernel.or= g/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3D07d13a1d6120d45= 3c3c1f020578693d072deded5 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0git remote add linux-ne= xt https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0git fetch --no-tags lin= ux-next master > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0git checkout 07d13a1d61= 20d453c3c1f020578693d072deded5 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0# save the attached .co= nfig to linux build tree > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0COMPILER_INSTALL_PATH= =3D$HOME/0day COMPILER=3Dclang make.cross ARCH=3Ds390=20 > >=20 > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > >=20 > > All errors (new ones prefixed by >>): > >=20 > > =C2=A0=C2=A0=C2=A0s390x-linux-gnu-ld: kernel/dma/coherent.o: in functio= n `dma_declare_coherent_memory': > > =C2=A0=C2=A0=C2=A0coherent.c:(.text+0xf8): undefined reference to `memu= nmap' > > =C2=A0=C2=A0=C2=A0s390x-linux-gnu-ld: kernel/dma/coherent.o: in functio= n `dma_init_coherent_memory': > > =C2=A0=C2=A0=C2=A0coherent.c:(.text+0x174): undefined reference to `mem= remap' > > =C2=A0=C2=A0=C2=A0s390x-linux-gnu-ld: coherent.c:(.text+0x344): undefin= ed reference to `memunmap' > > =C2=A0=C2=A0=C2=A0s390x-linux-gnu-ld: drivers/of/unittest.o: in functio= n `of_unittest': > > > > unittest.c:(.init.text+0x120): undefined reference to `of_dma_get_m= ax_cpu_address' >=20 > Thanks for the report. I think it needs the diff below. If Rob/Nicolas > are ok with it, I'll add it to the arm64 tree (with some commit text): >=20 > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c > index 98cc0163301b..799125ef66fc 100644 > --- a/drivers/of/unittest.c > +++ b/drivers/of/unittest.c > @@ -871,6 +871,7 @@ static void __init of_unittest_changeset(void) > =C2=A0 >=20 > =C2=A0static void __init of_unittest_dma_get_max_cpu_address(void) > =C2=A0{ > +#ifdef CONFIG_OF_ADDRESS > =C2=A0 struct device_node *np; > =C2=A0 phys_addr_t cpu_addr; > =C2=A0 >=20 > @@ -884,6 +885,7 @@ static void __init of_unittest_dma_get_max_cpu_addres= s(void) > =C2=A0 unittest(cpu_addr =3D=3D 0x4fffffff, > =C2=A0 "of_dma_get_max_cpu_address: wrong CPU addr %pad (expecting %x)\= n", > =C2=A0 &cpu_addr, 0x4fffffff); > +#endif > =C2=A0} > =C2=A0 >=20 > =C2=A0static void __init of_unittest_dma_ranges_one(const char *path, Yes, agree with this. Regards, Nicolas --=-uo/JAf+iWfTLbgcMzge/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl/GN+oACgkQlfZmHno8 x/4jJggAmR9G+WnJtxw9RpOkSYjT9pi783nE8PLta5UJRUpTivY2AF6tvrtaaehM ehJOiuDmi6pHtrc1cZ8Z+9NVweIOOspUiAXT5T/1wTiuZEPBtbuuKZEDbip7fRCd 7J0Ds2RHk6fvDzCw0mJ/qAJwZbN140zQmqwYYfBpsEPTFO1/igHSEaLHREQ9Q/hW XxEX/IhyalKwUvMRoZj4NKGqxGWNMX/gf6duoCxpjE1z76Trml2l5M+9xs5Ps+u5 1fYwyPdWfMJRD9IvUOEOyUYDx4tAh/9Zm08IXybbG27JnawuG50q+LWU74cApi/A 8iF0KCcXxtYkw3C3jaro7Dh9E9xFpg== =wX5v -----END PGP SIGNATURE----- --=-uo/JAf+iWfTLbgcMzge/-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1203938295377443373==" MIME-Version: 1.0 From: Nicolas Saenz Julienne To: kbuild-all@lists.01.org Subject: Re: [linux-next:master 6272/9613] unittest.c:undefined reference to `of_dma_get_max_cpu_address' Date: Tue, 01 Dec 2020 13:32:42 +0100 Message-ID: In-Reply-To: <20201201122915.GC31404@gaia> List-Id: --===============1203938295377443373== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, 2020-12-01 at 12:29 +0000, Catalin Marinas wrote: > On Tue, Dec 01, 2020 at 05:32:51PM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git master > > head: c6b11acc5f85b6e11d128fad8e0b7b223aa7e33f > > commit: 07d13a1d6120d453c3c1f020578693d072deded5 [6272/9613] of: unitte= st: Add test for of_dma_get_max_cpu_address() > > config: s390-randconfig-r034-20201201 (attached as .config) > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ac= 40a2d8f16b8a8c68fc811d67f647740e965cb8) > > reproduce (this is a W=3D1 build): > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0wget https://raw.github= usercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0chmod +x ~/bin/make.cro= ss > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0# install s390 cross co= mpiling tool for clang build > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0# apt-get install binut= ils-s390x-linux-gnu > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0# https://git.kernel.or= g/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=3D07d13a1d6120d45= 3c3c1f020578693d072deded5 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0git remote add linux-ne= xt https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0git fetch --no-tags lin= ux-next master > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0git checkout 07d13a1d61= 20d453c3c1f020578693d072deded5 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0# save the attached .co= nfig to linux build tree > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0COMPILER_INSTALL_PATH= =3D$HOME/0day COMPILER=3Dclang make.cross ARCH=3Ds390 = > > = > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > = > > All errors (new ones prefixed by >>): > > = > > =C2=A0=C2=A0=C2=A0s390x-linux-gnu-ld: kernel/dma/coherent.o: in functio= n `dma_declare_coherent_memory': > > =C2=A0=C2=A0=C2=A0coherent.c:(.text+0xf8): undefined reference to `memu= nmap' > > =C2=A0=C2=A0=C2=A0s390x-linux-gnu-ld: kernel/dma/coherent.o: in functio= n `dma_init_coherent_memory': > > =C2=A0=C2=A0=C2=A0coherent.c:(.text+0x174): undefined reference to `mem= remap' > > =C2=A0=C2=A0=C2=A0s390x-linux-gnu-ld: coherent.c:(.text+0x344): undefin= ed reference to `memunmap' > > =C2=A0=C2=A0=C2=A0s390x-linux-gnu-ld: drivers/of/unittest.o: in functio= n `of_unittest': > > > > unittest.c:(.init.text+0x120): undefined reference to `of_dma_get_m= ax_cpu_address' > = > Thanks for the report. I think it needs the diff below. If Rob/Nicolas > are ok with it, I'll add it to the arm64 tree (with some commit text): > = > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c > index 98cc0163301b..799125ef66fc 100644 > --- a/drivers/of/unittest.c > +++ b/drivers/of/unittest.c > @@ -871,6 +871,7 @@ static void __init of_unittest_changeset(void) > =C2=A0 > = > =C2=A0static void __init of_unittest_dma_get_max_cpu_address(void) > =C2=A0{ > +#ifdef CONFIG_OF_ADDRESS > =C2=A0 struct device_node *np; > =C2=A0 phys_addr_t cpu_addr; > =C2=A0 > = > @@ -884,6 +885,7 @@ static void __init of_unittest_dma_get_max_cpu_addres= s(void) > =C2=A0 unittest(cpu_addr =3D=3D 0x4fffffff, > =C2=A0 "of_dma_get_max_cpu_address: wrong CPU addr %pad (expecting %x)\= n", > =C2=A0 &cpu_addr, 0x4fffffff); > +#endif > =C2=A0} > =C2=A0 > = > =C2=A0static void __init of_unittest_dma_ranges_one(const char *path, Yes, agree with this. Regards, Nicolas --===============1203938295377443373== Content-Type: application/pgp-signature MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRRXpCQUFCQ0FBZEZpRUVyT2trR0RIQ2cy RWJQY0dqbGZabUhubzh4LzRGQWwvR04rb0FDZ2tRbGZabUhubzgKeC80akpnZ0FtUjlHK1duSnR4 dzlScE9rU1lqVDlwaTc4M25FOFBMdGE1VUpSVXBUaXZZMkFGNnR2cnRhYWVoTQplaEpPaXVEbWk2 cEh0cmMxY1o4Wis5TlZ3ZUlPT3NwVWlBWFQ1VC8xd1RpdVpFUEJ0YnV1S1pFRGJpcDdmUkNkCjdK MERzMlJIazZmdkR6Q3cwbUovcUFKd1piTjE0MHpRbXF3WVlmQnBzRVBURk8xL2lnSFNFYUxIUkVR OVEvaFcKWHhFWC9JaHlhbEt3VXZNUm9aajROS0dxeEdXTk1YL2dmNmR1b0N4cGpFMXo3NlRybWwy bDVNKzl4czVQcyt1NQoxZll3eVBkV2ZNSlJEOUl2VU9FT3lVWUR4NHRBaC85Wm0wOElYeWJiRzI3 Sm5hd3VHNTBxK0xXVTc0Y0FwaS9BCjhpRjBLQ2NYeHRZa3czQzNqYXJvN0RoOUU5eEZwZz09Cj13 WDV2Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============1203938295377443373==--