From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A79DC3E8C5 for ; Fri, 27 Nov 2020 21:44:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1857620B80 for ; Fri, 27 Nov 2020 21:44:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="LkWve4UN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731821AbgK0Vn2 (ORCPT ); Fri, 27 Nov 2020 16:43:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731224AbgK0Viy (ORCPT ); Fri, 27 Nov 2020 16:38:54 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3E84C0613D4; Fri, 27 Nov 2020 13:38:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=nO4RXuLseZ9MllgwTyIUkN6yFSiutROqckJ+OiN9Exk=; b=LkWve4UNDL+zocHWZAlhr7y2Gj u/UHYsXNREBswsFjIg5zoMAfXgomJ6MT7tF555vGL5q7ygZhq+jlBIYJWUh6hNn1t/5xEoSreQoYO vYhtzN0rJqnK8D03nZvhYHaMc6vtmhOLXOtSO8P6yZgbrEvs+x44NKBwqncjjvxkHSM33IytDa7A2 oE0FMx1Px8LNwMUIHQXMPUXK6ko0e4njkwxi+/zIdntevqOjFLFwZ6AmVJ9/+IqQTi44lEe23xObL dJtIoVMzqhNtP1SaZzU/3Ea57bu3GgpGe1VJT7vhNDZYdKN75UN1qMceoP7Ejj1tBQUJJK3Y/vImM WAj4NYCw==; Received: from [2601:1c0:6280:3f0::cc1f] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kilS1-0004ga-Ln; Fri, 27 Nov 2020 21:38:46 +0000 Subject: Re: linux-next: Tree for Nov 27 (drivers/idle/intel_idle.c) To: Stephen Rothwell Cc: Linux Next Mailing List , Linux Kernel Mailing List , "Rafael J. Wysocki" , Len Brown , Jacob Pan , Peter Zijlstra References: <20201127200457.1ffb6aaf@canb.auug.org.au> <0a6cc4c9-c48d-dbc4-6044-3b22cd133b76@infradead.org> <20201128083617.50021fff@canb.auug.org.au> From: Randy Dunlap Message-ID: Date: Fri, 27 Nov 2020 13:38:40 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201128083617.50021fff@canb.auug.org.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/27/20 1:36 PM, Stephen Rothwell wrote: > Hi Randy, > > On Fri, 27 Nov 2020 07:57:32 -0800 Randy Dunlap wrote: >> >> On 11/27/20 1:04 AM, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20201126: >>> >> >> (This looks strange to me.) >> >> >> on i386 or x86_64: >> >> # CONFIG_ACPI is not set >> >> ../drivers/idle/intel_idle.c: In function ‘intel_idle_init_cstates_icpu’: >> ../drivers/idle/intel_idle.c:1510:7: error: implicit declaration of function ‘intel_idle_state_needs_timer_stop’; did you mean ‘intel_idle_init_cstates_icpu’? [-Werror=implicit-function-declaration] >> if (intel_idle_state_needs_timer_stop(&drv->states[drv->state_count])) >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > intel_idle_state_needs_timer_stop() is only defined when > CONFIG_ACPI_PROCESSOR_CSTATE is set, but is used once where that is not > necessarily set. I assume CONFIG_ACPI_PROCESSOR_CSTATE is not set in > your config? Yes, you are correct (not set). > Caused by commit > > 6e1d2bc675bd ("intel_idle: Fix intel_idle() vs tracing") > > from the tip tree. -- ~Randy