From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1kTa-0003y6-Ls for qemu-devel@nongnu.org; Mon, 09 Oct 2017 22:40:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1kTX-0004AL-Ha for qemu-devel@nongnu.org; Mon, 09 Oct 2017 22:40:58 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55226) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e1kTX-00049o-8H for qemu-devel@nongnu.org; Mon, 09 Oct 2017 22:40:55 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v9A2clAi063387 for ; Mon, 9 Oct 2017 22:40:51 -0400 Received: from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201]) by mx0a-001b2d01.pphosted.com with ESMTP id 2dgmde36e0-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 09 Oct 2017 22:40:51 -0400 Received: from localhost by e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 Oct 2017 22:40:50 -0400 References: <20171009225623.29232-1-marcandre.lureau@redhat.com> <20171009225623.29232-6-marcandre.lureau@redhat.com> From: Stefan Berger Date: Mon, 9 Oct 2017 22:40:47 -0400 MIME-Version: 1.0 In-Reply-To: <20171009225623.29232-6-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 05/42] tpm: replace tpm_get_backend_driver() to drop be_drivers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: amarnath.valluri@intel.com On 10/09/2017 06:55 PM, Marc-Andr=C3=A9 Lureau wrote: > Use tpm_driver_find_by_type() instead. > > Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Stefan Berger > --- > tpm.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/tpm.c b/tpm.c > index 04de8da5fd..ad2ed6a0da 100644 > --- a/tpm.c > +++ b/tpm.c > @@ -31,13 +31,6 @@ void tpm_register_model(enum TpmModel model) > tpm_models[model] =3D true; > } > =20 > -static const TPMDriverOps *tpm_get_backend_driver(const char *type) > -{ > - int i =3D qapi_enum_parse(&TpmType_lookup, type, -1, NULL); > - > - return i >=3D 0 ? be_drivers[i] : NULL; > -} > - > #ifdef CONFIG_TPM > =20 > void tpm_register_driver(const TPMDriverOps *tdo) > @@ -110,6 +103,7 @@ static int configure_tpm(QemuOpts *opts) > const TPMDriverOps *be; > TPMBackend *drv; > Error *local_err =3D NULL; > + int i; > =20 > if (!QLIST_EMPTY(&tpm_backends)) { > error_report("Only one TPM is allowed."); > @@ -129,7 +123,8 @@ static int configure_tpm(QemuOpts *opts) > return 1; > } > =20 > - be =3D tpm_get_backend_driver(value); > + i =3D qapi_enum_parse(&TpmType_lookup, value, -1, NULL); > + be =3D i >=3D 0 ? tpm_driver_find_by_type(i) : NULL; > if (be =3D=3D NULL) { > error_report(QERR_INVALID_PARAMETER_VALUE, > "type", "a TPM backend type");