From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17016C433C1 for ; Sun, 21 Mar 2021 19:01:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B23E16024A for ; Sun, 21 Mar 2021 19:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230163AbhCUTA1 (ORCPT ); Sun, 21 Mar 2021 15:00:27 -0400 Received: from mxout02.lancloud.ru ([45.84.86.82]:47302 "EHLO mxout02.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230182AbhCUTAA (ORCPT ); Sun, 21 Mar 2021 15:00:00 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout02.lancloud.ru 6FD9B205FD45 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: [PATCH 4/4] pata_imx: deny IRQ0 From: Sergey Shtylyov To: Jens Axboe , , Shawn Guo , Sascha Hauer , "Pengutronix Kernel Team" , Fabio Estevam , "NXP Linux Team" , References: <2e552c36-84a5-a642-a8f0-1395f77a1a6a@omprussia.ru> Organization: Open Mobile Platform, LLC Message-ID: Date: Sun, 21 Mar 2021 21:59:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <2e552c36-84a5-a642-a8f0-1395f77a1a6a@omprussia.ru> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1908.lancloud.ru (fd00:f066::208) Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org If platform_get_irq() returns IRQ0 (considered invalid according to Linus) the driver blithely passes it to ata_host_activate() that treats IRQ0 as a sign that libata should use polling and thus complains about non-NULL IRQ handler passed to it. Deny IRQ0 right away, returning -EINVAL from the probe() method... Fixes: e39c75cf3e04 ("ata: Add iMX pata support") Signed-off-by: Sergey Shtylyov --- drivers/ata/pata_imx.c | 2 ++ 1 file changed, 2 insertions(+) Index: linux-block/drivers/ata/pata_imx.c =================================================================== --- linux-block.orig/drivers/ata/pata_imx.c +++ linux-block/drivers/ata/pata_imx.c @@ -135,6 +135,8 @@ static int pata_imx_probe(struct platfor irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; + if (!irq) + return -EINVAL; priv = devm_kzalloc(&pdev->dev, sizeof(struct pata_imx_priv), GFP_KERNEL); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F88AC433DB for ; Sun, 21 Mar 2021 19:03:11 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03B076194C for ; Sun, 21 Mar 2021 19:03:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03B076194C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=omprussia.ru Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pUEP2ZPx8dxZ3oltxgNigaZWgnwOmNeJHUjrAtqPZEg=; b=UBd4bw/X4KaBcTuFvexSrfEuF T/3W420fXxMex3sIGSUwtLzs30oDltXg5auB8TvOtXvtgUy4E0mRcR6o7Vpwe7oVVQYrfqhdc3MTX dceOW8jW7x5JRJB82j5vNGpktqisaYZshcQtfxte+oR3MMOjuzeBs0zM74hLbUqKVupkyfG9btawq mGNPk7HIlaiXO8IkY5mLpBJYiUDb0qjw3kl+bn0Vd2hOx/iE3A4trdk9j068freYlyrd98LG5y8Ox IIHzCCnMtrdZjE/1UhLJwdNlZ6CJnoaVSDIUE7hIuVzVdZR6nr2uQQpUF4osJN9Br5knw+dtIhO0F uWtD0m02Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lO3JD-00AFuf-0c; Sun, 21 Mar 2021 19:00:19 +0000 Received: from mxout02.lancloud.ru ([45.84.86.82]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lO3It-00AFrJ-OX for linux-arm-kernel@lists.infradead.org; Sun, 21 Mar 2021 19:00:03 +0000 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout02.lancloud.ru 6FD9B205FD45 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: [PATCH 4/4] pata_imx: deny IRQ0 From: Sergey Shtylyov To: Jens Axboe , , Shawn Guo , Sascha Hauer , "Pengutronix Kernel Team" , Fabio Estevam , "NXP Linux Team" , References: <2e552c36-84a5-a642-a8f0-1395f77a1a6a@omprussia.ru> Organization: Open Mobile Platform, LLC Message-ID: Date: Sun, 21 Mar 2021 21:59:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <2e552c36-84a5-a642-a8f0-1395f77a1a6a@omprussia.ru> Content-Language: en-US X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1908.lancloud.ru (fd00:f066::208) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210321_190000_794152_E767F094 X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If platform_get_irq() returns IRQ0 (considered invalid according to Linus) the driver blithely passes it to ata_host_activate() that treats IRQ0 as a sign that libata should use polling and thus complains about non-NULL IRQ handler passed to it. Deny IRQ0 right away, returning -EINVAL from the probe() method... Fixes: e39c75cf3e04 ("ata: Add iMX pata support") Signed-off-by: Sergey Shtylyov --- drivers/ata/pata_imx.c | 2 ++ 1 file changed, 2 insertions(+) Index: linux-block/drivers/ata/pata_imx.c =================================================================== --- linux-block.orig/drivers/ata/pata_imx.c +++ linux-block/drivers/ata/pata_imx.c @@ -135,6 +135,8 @@ static int pata_imx_probe(struct platfor irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; + if (!irq) + return -EINVAL; priv = devm_kzalloc(&pdev->dev, sizeof(struct pata_imx_priv), GFP_KERNEL); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel