From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C030CC433F5 for ; Wed, 6 Apr 2022 15:08:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4FA9283DC1; Wed, 6 Apr 2022 17:08:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 2C35E83DC7; Wed, 6 Apr 2022 17:08:44 +0200 (CEST) Received: from mail-m17664.qiye.163.com (mail-m17664.qiye.163.com [59.111.176.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B187F83DA7 for ; Wed, 6 Apr 2022 17:08:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [192.168.0.115] (unknown [112.49.233.126]) by mail-m17664.qiye.163.com (Hmail) with ESMTPA id 2A9D21401E4; Wed, 6 Apr 2022 23:08:25 +0800 (CST) Message-ID: Date: Wed, 6 Apr 2022 23:08:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/9] net: gmac_rockchip: Fix misuse of GENMASK macro Content-Language: en-US To: =?UTF-8?Q?Pierre-Cl=c3=a9ment_Tosi?= , u-boot@lists.denx.de Cc: Joe Hershberger , Heiko Stuebner , Tom Rini , =?UTF-8?B?5ZC06L6+6LaF?= References: <20220316153948.197650-1-ptosi@google.com> From: Kever Yang In-Reply-To: <20220316153948.197650-1-ptosi@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUhPN1dZLVlBSVdZDwkaFQgSH1lBWRkeShpWTkoaQxlMTxpNSB 5NVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITk9VS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NAg6Sxw5Fj4CN0lRLhxJND0d Ej8wCxdVSlVKTU9CSU5MTEtOT01JVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlKSklVT0JVSUhIVUpJTVlXWQgBWUFJTENMNwY+ X-HM-Tid: 0a7fff6b6f42da2fkuws2a9d21401e4 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Add David, Hi David,     Could you help to check this patch? Thanks, - Kever On 2022/3/16 23:39, Pierre-Clément Tosi wrote: > Swap the arguments as that seems to have been the author's intention. > > Note: This fix wasn't tested on hardware and will result in more bits > being set by the underlying writel() in rk_clrsetreg(), which > might bring unexpected behavioural changes. > > Fixes: b07911840025 ("net: gmac_rockchip: add support for px30") > Signed-off-by: Pierre-Clément Tosi > Cc: Joe Hershberger > Cc: Heiko Stuebner > Cc: Kever Yang > Cc: Tom Rini > --- > drivers/net/gmac_rockchip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/gmac_rockchip.c b/drivers/net/gmac_rockchip.c > index 04008d2b19..0ecbcdf641 100644 > --- a/drivers/net/gmac_rockchip.c > +++ b/drivers/net/gmac_rockchip.c > @@ -350,7 +350,7 @@ static void px30_gmac_set_to_rmii(struct gmac_rockchip_plat *pdata) > struct px30_grf *grf; > enum { > PX30_GMAC_PHY_INTF_SEL_SHIFT = 4, > - PX30_GMAC_PHY_INTF_SEL_MASK = GENMASK(4, 6), > + PX30_GMAC_PHY_INTF_SEL_MASK = GENMASK(6, 4), > PX30_GMAC_PHY_INTF_SEL_RMII = BIT(6), > }; >