From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02C5C004EF for ; Wed, 10 Jul 2019 09:47:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D360D20651 for ; Wed, 10 Jul 2019 09:47:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727197AbfGJJrX (ORCPT ); Wed, 10 Jul 2019 05:47:23 -0400 Received: from foss.arm.com ([217.140.110.172]:58574 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbfGJJrX (ORCPT ); Wed, 10 Jul 2019 05:47:23 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07B07344; Wed, 10 Jul 2019 02:47:22 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7905E3F246; Wed, 10 Jul 2019 02:47:18 -0700 (PDT) Subject: Re: [PATCH v7 10/25] arm64: compat: Add vDSO To: John Stultz Cc: linux-arch@vger.kernel.org, linux-arm-kernel , lkml , linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan , Andre Przywara , Arnd Bergmann , Huw Davies , Catalin Marinas , Daniel Lezcano , Will Deacon , Russell King , Ralf Baechle , Mark Salyzyn , Paul Burton , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Thomas Gleixner , Shijith Thotton , Peter Collingbourne References: <20190621095252.32307-1-vincenzo.frascino@arm.com> <20190621095252.32307-11-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: Date: Wed, 10 Jul 2019 10:47:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, On 10/07/2019 05:02, John Stultz wrote: > On Fri, Jun 21, 2019 at 3:18 AM Vincenzo Frascino > wrote: >> >> Provide the arm64 compat (AArch32) vDSO in kernel/vdso32 in a similar >> way to what happens in kernel/vdso. >> >> The compat vDSO leverages on an adaptation of the arm architecture code >> with few changes: >> - Use of lib/vdso for gettimeofday >> - Implementation of syscall based fallback >> - Introduction of clock_getres for the compat library >> - Implementation of trampolines >> - Implementation of elf note >> >> To build the compat vDSO a 32 bit compiler is required and needs to be >> specified via CONFIG_CROSS_COMPILE_COMPAT_VDSO. >> > > Hey Vincenzo! > Congrats on getting this work merged, I know its been a long effort > over a number of years! > > Though unfortunately, it seems the arm64 vdso code that just landed is > breaking AOSP for me. > > I see a lot of the following errors: > 01-01 01:22:14.097 755 755 F libc : Fatal signal 11 (SIGSEGV), > code 1 (SEGV_MAPERR), fault addr 0x3cf2c96c in tid 755 (cameraserver), > pid 755 (cameraserver) > 01-01 01:22:14.112 759 759 F libc : Fatal signal 11 (SIGSEGV), > code 1 (SEGV_MAPERR), fault addr 0x3cf2c96c in tid 759 > (android.hardwar), pid 759 (android.hardwar) > 01-01 01:22:14.120 756 756 F libc : Fatal signal 11 (SIGSEGV), > code 1 (SEGV_MAPERR), fault addr 0x3cf2c96c in tid 756 (drmserver), > pid 756 (drmserver) > > Which go away if I revert the vdso merge that went in via tip/timers. > > I tried to bisect things down a bit, but as some later fixes are > required (at one point, date was returning the start epoch and never > increasing), this hasn't worked too well. But I'm guessing since I > see: "CROSS_COMPILE_COMPAT not defined or empty, the compat vDSO will > not be built", and the system is half working, I'm guessing this is an > issue with just the 32bit code failing. While I can try to sort out > the proper CROSS_COMPILE_COMPAT in my build environment, I assume > userland shouldn't be crashing if that value isn't set. > > Any chance this issue has already been raised? > I do not have Android (bionic/libc) as part of my testing environment hence I never saw this issue. Thanks for reporting it. I am investigating the problem and will post a fix as soon as it is ready. As Will suggested, .config would help the debugging and I would like to ask to you to test my fix once it is ready. Is that OK for you? > thanks > -john > -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincenzo Frascino Subject: Re: [PATCH v7 10/25] arm64: compat: Add vDSO Date: Wed, 10 Jul 2019 10:47:16 +0100 Message-ID: References: <20190621095252.32307-1-vincenzo.frascino@arm.com> <20190621095252.32307-11-vincenzo.frascino@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: John Stultz Cc: linux-arch@vger.kernel.org, linux-arm-kernel , lkml , linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan , Andre Przywara , Arnd Bergmann , Huw Davies , Catalin Marinas , Daniel Lezcano , Will Deacon , Russell King , Ralf Baechle , Mark Salyzyn , Paul Burton , Dmitry Safonov <0x7f454c46@gmail.com>, Rasmus Villemoes , Thomas Gleixner , Shijith Thotton , Pe List-Id: linux-arch.vger.kernel.org Hi John, On 10/07/2019 05:02, John Stultz wrote: > On Fri, Jun 21, 2019 at 3:18 AM Vincenzo Frascino > wrote: >> >> Provide the arm64 compat (AArch32) vDSO in kernel/vdso32 in a similar >> way to what happens in kernel/vdso. >> >> The compat vDSO leverages on an adaptation of the arm architecture code >> with few changes: >> - Use of lib/vdso for gettimeofday >> - Implementation of syscall based fallback >> - Introduction of clock_getres for the compat library >> - Implementation of trampolines >> - Implementation of elf note >> >> To build the compat vDSO a 32 bit compiler is required and needs to be >> specified via CONFIG_CROSS_COMPILE_COMPAT_VDSO. >> > > Hey Vincenzo! > Congrats on getting this work merged, I know its been a long effort > over a number of years! > > Though unfortunately, it seems the arm64 vdso code that just landed is > breaking AOSP for me. > > I see a lot of the following errors: > 01-01 01:22:14.097 755 755 F libc : Fatal signal 11 (SIGSEGV), > code 1 (SEGV_MAPERR), fault addr 0x3cf2c96c in tid 755 (cameraserver), > pid 755 (cameraserver) > 01-01 01:22:14.112 759 759 F libc : Fatal signal 11 (SIGSEGV), > code 1 (SEGV_MAPERR), fault addr 0x3cf2c96c in tid 759 > (android.hardwar), pid 759 (android.hardwar) > 01-01 01:22:14.120 756 756 F libc : Fatal signal 11 (SIGSEGV), > code 1 (SEGV_MAPERR), fault addr 0x3cf2c96c in tid 756 (drmserver), > pid 756 (drmserver) > > Which go away if I revert the vdso merge that went in via tip/timers. > > I tried to bisect things down a bit, but as some later fixes are > required (at one point, date was returning the start epoch and never > increasing), this hasn't worked too well. But I'm guessing since I > see: "CROSS_COMPILE_COMPAT not defined or empty, the compat vDSO will > not be built", and the system is half working, I'm guessing this is an > issue with just the 32bit code failing. While I can try to sort out > the proper CROSS_COMPILE_COMPAT in my build environment, I assume > userland shouldn't be crashing if that value isn't set. > > Any chance this issue has already been raised? > I do not have Android (bionic/libc) as part of my testing environment hence I never saw this issue. Thanks for reporting it. I am investigating the problem and will post a fix as soon as it is ready. As Will suggested, .config would help the debugging and I would like to ask to you to test my fix once it is ready. Is that OK for you? > thanks > -john > -- Regards, Vincenzo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B38B2C004EF for ; Wed, 10 Jul 2019 09:47:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C2A820651 for ; Wed, 10 Jul 2019 09:47:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sVKJOeaz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C2A820651 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gj2CJs9H9zUqAi8ebMwWzkTJ9GWuDcZqw2vJHPEsn4w=; b=sVKJOeazRJNZJj hF2I8vN9SbWvbPdbQkAcbUkxMyw19I6PEoCAqDK2iegRlycZUFTeqD6axP3rZ0H2xMPjZ0QJkCay/ kBORKWkU1VBet9ys5kpiSeVTylD5hGHkuD6fwsc81NWXe3P07XSiZ0qXTBV3HmH20sbIsFF+6Hd0O 9t1BVjqCVWvmfuuoy55qLIrZfV6WA3cT08yZx8afS7FRnR6yzZFJZxVDG620/IVLFrPEjhkNsfd1n dKunDsXqxumO+wO40Buj6bnpWzdKVUwPBcIaIfWr4zT1pbuZ+sT6c7jLesUQ992t+bfyhdlGgmnva agnQ3hB5dWHq83PQ2WZA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hl9CD-0001pD-PM; Wed, 10 Jul 2019 09:47:29 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hl9C8-0001oB-6J for linux-arm-kernel@lists.infradead.org; Wed, 10 Jul 2019 09:47:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07B07344; Wed, 10 Jul 2019 02:47:22 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7905E3F246; Wed, 10 Jul 2019 02:47:18 -0700 (PDT) Subject: Re: [PATCH v7 10/25] arm64: compat: Add vDSO To: John Stultz References: <20190621095252.32307-1-vincenzo.frascino@arm.com> <20190621095252.32307-11-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: Date: Wed, 10 Jul 2019 10:47:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190710_024724_497496_E303AE4B X-CRM114-Status: GOOD ( 23.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Shijith Thotton , Peter Collingbourne , Arnd Bergmann , Huw Davies , Andre Przywara , Daniel Lezcano , Will Deacon , lkml , Ralf Baechle , linux-mips@vger.kernel.org, Paul Burton , Rasmus Villemoes , linux-kselftest@vger.kernel.org, Catalin Marinas , Russell King , Dmitry Safonov <0x7f454c46@gmail.com>, Mark Salyzyn , Shuah Khan , Thomas Gleixner , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi John, On 10/07/2019 05:02, John Stultz wrote: > On Fri, Jun 21, 2019 at 3:18 AM Vincenzo Frascino > wrote: >> >> Provide the arm64 compat (AArch32) vDSO in kernel/vdso32 in a similar >> way to what happens in kernel/vdso. >> >> The compat vDSO leverages on an adaptation of the arm architecture code >> with few changes: >> - Use of lib/vdso for gettimeofday >> - Implementation of syscall based fallback >> - Introduction of clock_getres for the compat library >> - Implementation of trampolines >> - Implementation of elf note >> >> To build the compat vDSO a 32 bit compiler is required and needs to be >> specified via CONFIG_CROSS_COMPILE_COMPAT_VDSO. >> > > Hey Vincenzo! > Congrats on getting this work merged, I know its been a long effort > over a number of years! > > Though unfortunately, it seems the arm64 vdso code that just landed is > breaking AOSP for me. > > I see a lot of the following errors: > 01-01 01:22:14.097 755 755 F libc : Fatal signal 11 (SIGSEGV), > code 1 (SEGV_MAPERR), fault addr 0x3cf2c96c in tid 755 (cameraserver), > pid 755 (cameraserver) > 01-01 01:22:14.112 759 759 F libc : Fatal signal 11 (SIGSEGV), > code 1 (SEGV_MAPERR), fault addr 0x3cf2c96c in tid 759 > (android.hardwar), pid 759 (android.hardwar) > 01-01 01:22:14.120 756 756 F libc : Fatal signal 11 (SIGSEGV), > code 1 (SEGV_MAPERR), fault addr 0x3cf2c96c in tid 756 (drmserver), > pid 756 (drmserver) > > Which go away if I revert the vdso merge that went in via tip/timers. > > I tried to bisect things down a bit, but as some later fixes are > required (at one point, date was returning the start epoch and never > increasing), this hasn't worked too well. But I'm guessing since I > see: "CROSS_COMPILE_COMPAT not defined or empty, the compat vDSO will > not be built", and the system is half working, I'm guessing this is an > issue with just the 32bit code failing. While I can try to sort out > the proper CROSS_COMPILE_COMPAT in my build environment, I assume > userland shouldn't be crashing if that value isn't set. > > Any chance this issue has already been raised? > I do not have Android (bionic/libc) as part of my testing environment hence I never saw this issue. Thanks for reporting it. I am investigating the problem and will post a fix as soon as it is ready. As Will suggested, .config would help the debugging and I would like to ask to you to test my fix once it is ready. Is that OK for you? > thanks > -john > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel