All of lore.kernel.org
 help / color / mirror / Atom feed
From: Song Gao <gaosong@loongson.cn>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: peter.maydell@linaro.org, thuth@redhat.com, chenhuacai@gmail.com,
	philmd@redhat.com, yangxiaojuan@loongson.cn,
	qemu-devel@nongnu.org, maobibo@loongson.cn, laurent@vivier.eu,
	alistair.francis@wdc.com, pbonzini@redhat.com,
	alex.bennee@linaro.org
Subject: Re: [PATCH v2 12/22] target/loongarch: Add fixed point extra instruction translation
Date: Wed, 4 Aug 2021 15:40:18 +0800	[thread overview]
Message-ID: <d9b20db9-ee1d-7860-45c3-c618399cfa52@loongson.cn> (raw)
In-Reply-To: <7a500d72-7d16-1a02-2ede-5e07f1383812@linaro.org>


On 07/23/2021 01:12 PM, Richard Henderson wrote:
>> +static bool trans_asrtle_d(DisasContext *ctx, arg_asrtle_d * a)
>> +{
>> +    TCGv t0, t1;
>> +
>> +    t0 = get_gpr(a->rj);
>> +    t1 = get_gpr(a->rk);
>> +
>> +    gen_helper_asrtle_d(cpu_env, t0, t1);
>> +
>> +    return true;
>> +}
>> +
>> +static bool trans_asrtgt_d(DisasContext *ctx, arg_asrtgt_d * a)
>> +{
>> +    TCGv t0, t1;
>> +
>> +    t0 = get_gpr(a->rj);
>> +    t1 = get_gpr(a->rk);
>> +
>> +    gen_helper_asrtgt_d(cpu_env, t0, t1);
>> +
>> +    return true;
>> +}
> 
> I'm not sure why both of these instructions are in the ISA, since
> 
>   ASRTLE X,Y <-> ASRTGT Y,X
> 
> but we certainly don't need two different helpers.
> Just swap the arguments for one of them.

Hi, Richard.

I find 'ASRTLE X,Y <-> ASRTGT Y,X ' is not right,
 
    ASRTLE X, Y is X <= Y, raise a exception.
    ASRTGT Y, X is X < Y, raise a exception, lose X=Y.

Thanks
Song Gao



  parent reply	other threads:[~2021-08-04  7:41 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21  9:52 [PATCH v2 00/22] Add LoongArch linux-user emulation support Song Gao
2021-07-21  9:52 ` [PATCH v2 01/22] target/loongarch: Add README Song Gao
2021-07-21  9:52 ` [PATCH v2 02/22] target/loongarch: Add CSR registers definition Song Gao
2021-07-21  9:52 ` [PATCH v2 03/22] target/loongarch: Add core definition Song Gao
2021-07-22 22:43   ` Richard Henderson
2021-07-26  8:47     ` Song Gao
2021-07-26 15:32       ` Richard Henderson
2021-07-21  9:53 ` [PATCH v2 04/22] target/loongarch: Add interrupt handling support Song Gao
2021-07-22 22:47   ` Richard Henderson
2021-07-26  9:23     ` Song Gao
2021-07-21  9:53 ` [PATCH v2 05/22] target/loongarch: Add memory management support Song Gao
2021-07-22 22:48   ` Richard Henderson
2021-07-26  9:25     ` Song Gao
2021-07-21  9:53 ` [PATCH v2 06/22] target/loongarch: Add main translation routines Song Gao
2021-07-22 23:50   ` Richard Henderson
2021-07-26  9:39     ` Song Gao
2021-07-26 15:35       ` Richard Henderson
2021-07-21  9:53 ` [PATCH v2 07/22] target/loongarch: Add fixed point arithmetic instruction translation Song Gao
2021-07-21 17:38   ` Philippe Mathieu-Daudé
2021-07-21 17:49     ` Philippe Mathieu-Daudé
2021-07-22  7:41       ` Song Gao
2021-07-23  0:46   ` Richard Henderson
2021-07-26 11:56     ` Song Gao
2021-07-26 15:53       ` Richard Henderson
2021-07-27  1:51         ` Song Gao
2021-07-21  9:53 ` [PATCH v2 08/22] target/loongarch: Add fixed point shift " Song Gao
2021-07-23  0:51   ` Richard Henderson
2021-07-26 11:57     ` Song Gao
2021-07-21  9:53 ` [PATCH v2 09/22] target/loongarch: Add fixed point bit " Song Gao
2021-07-21 17:46   ` Philippe Mathieu-Daudé
2021-07-22  8:17     ` Song Gao
2021-07-23  1:29   ` Richard Henderson
2021-07-26 12:22     ` Song Gao
2021-07-26 16:39       ` Richard Henderson
2021-07-21  9:53 ` [PATCH v2 10/22] target/loongarch: Add fixed point load/store " Song Gao
2021-07-23  1:45   ` Richard Henderson
2021-07-26 12:25     ` Song Gao
2021-07-21  9:53 ` [PATCH v2 11/22] target/loongarch: Add fixed point atomic " Song Gao
2021-07-23  1:49   ` Richard Henderson
2021-07-26 12:25     ` Song Gao
2021-07-21  9:53 ` [PATCH v2 12/22] target/loongarch: Add fixed point extra " Song Gao
2021-07-23  5:12   ` Richard Henderson
2021-07-26 12:57     ` Song Gao
2021-07-26 16:42       ` Richard Henderson
2021-07-27  1:46         ` Song Gao
2021-08-04  7:40     ` Song Gao [this message]
2021-08-04  7:51       ` Song Gao
2021-07-21  9:53 ` [PATCH v2 13/22] target/loongarch: Add floating point arithmetic " Song Gao
2021-07-23  5:44   ` Richard Henderson
2021-07-27  7:17     ` Song Gao
2021-07-27 16:12       ` Richard Henderson
2021-07-28  1:18         ` Song Gao
2021-07-21  9:53 ` [PATCH v2 14/22] target/loongarch: Add floating point comparison " Song Gao
2021-07-23  6:11   ` Richard Henderson
2021-07-27  7:56     ` Song Gao
2021-07-21  9:53 ` [PATCH v2 15/22] target/loongarch: Add floating point conversion " Song Gao
2021-07-23  6:16   ` Richard Henderson
2021-07-27  7:57     ` Song Gao
2021-07-21  9:53 ` [PATCH v2 16/22] target/loongarch: Add floating point move " Song Gao
2021-07-23  6:29   ` Richard Henderson
2021-07-27  8:06     ` Song Gao
2021-08-12  9:20     ` Song Gao
2021-08-12 19:31       ` Richard Henderson
2021-07-21  9:53 ` [PATCH v2 17/22] target/loongarch: Add floating point load/store " Song Gao
2021-07-23  6:34   ` Richard Henderson
2021-07-27  8:07     ` Song Gao
2021-07-21  9:53 ` [PATCH v2 18/22] target/loongarch: Add branch " Song Gao
2021-07-23  6:38   ` Richard Henderson
2021-07-27  8:07     ` Song Gao
2021-07-21  9:53 ` [PATCH v2 19/22] target/loongarch: Add disassembler Song Gao
2021-07-23  6:40   ` Richard Henderson
2021-08-12 10:33   ` Philippe Mathieu-Daudé
2021-07-21  9:53 ` [PATCH v2 20/22] LoongArch Linux User Emulation Song Gao
2021-07-21  9:53 ` [PATCH v2 21/22] configs: Add loongarch linux-user config Song Gao
2021-07-23  6:43   ` Richard Henderson
2021-07-21  9:53 ` [PATCH v2 22/22] target/loongarch: Add target build suport Song Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9b20db9-ee1d-7860-45c3-c618399cfa52@loongson.cn \
    --to=gaosong@loongson.cn \
    --cc=alex.bennee@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=chenhuacai@gmail.com \
    --cc=laurent@vivier.eu \
    --cc=maobibo@loongson.cn \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    --cc=yangxiaojuan@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.