From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/2] qapi/ui: introduce change-vnc-listen
Date: Tue, 21 Dec 2021 16:35:55 +0300 [thread overview]
Message-ID: <d9b5b69f-1329-724e-e867-e6c87486a14f@virtuozzo.com> (raw)
In-Reply-To: <CAJ+F1C+v1d49KT9+4n3RiDXfjj+82k7wz3rO_5=LVJ_T5Kn3vg@mail.gmail.com>
21.12.2021 11:13, Marc-André Lureau wrote:
> Hi
>
> On Mon, Dec 20, 2021 at 10:24 PM Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com <mailto:vsementsov@virtuozzo.com>> wrote:
>
> Add command that can change addresses where VNC server listens for new
> connections. Prior to 6.0 this functionality was available through
> 'change' qmp command which was deleted.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com <mailto:vsementsov@virtuozzo.com>>
>
>
> Looks good to me,
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com <mailto:marcandre.lureau@redhat.com>>
>
> Could you write an avocado test for it? (tests/avocado/vnc.py)
Thanks a lot for reviewing! I will.
--
Best regards,
Vladimir
next prev parent reply other threads:[~2021-12-21 13:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 15:44 [PATCH 0/2] qapi/ui: add change-vnc-listen Vladimir Sementsov-Ogievskiy
2021-12-20 15:44 ` [PATCH 1/2] ui/vnc: refactor arrays of addresses to SocketAddressList Vladimir Sementsov-Ogievskiy
2021-12-21 7:56 ` Marc-André Lureau
2021-12-20 15:44 ` [PATCH 2/2] qapi/ui: introduce change-vnc-listen Vladimir Sementsov-Ogievskiy
2021-12-21 8:13 ` Marc-André Lureau
2021-12-21 13:35 ` Vladimir Sementsov-Ogievskiy [this message]
2021-12-21 14:15 ` Markus Armbruster
2021-12-21 14:41 ` Vladimir Sementsov-Ogievskiy
2022-01-04 13:21 ` Daniel P. Berrangé
2022-01-13 16:27 ` Markus Armbruster
2022-01-13 16:30 ` Daniel P. Berrangé
2021-12-21 13:37 ` [PATCH 3/2] avocado/vnc: add test_change_listen Vladimir Sementsov-Ogievskiy
2021-12-21 13:45 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9b5b69f-1329-724e-e867-e6c87486a14f@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.