All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
	Etienne Carriere <etienne.carriere@linaro.org>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
	Jens Wiklander <jens.wiklander@linaro.org>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Sumit Garg <sumit.garg@linaro.org>
Subject: [linux-next:master 6897/13075] drivers/tee/optee/smc_abi.c:1021 irq_handler() error: uninitialized symbol 'value_valid'.
Date: Thu, 20 Apr 2023 09:03:10 +0300	[thread overview]
Message-ID: <d9b7f69b-c737-4cb3-8e74-79fe00c934f9@kili.mountain> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   3cdbc01c40e34c57697f8934f2727a88551696be
commit: b3b4ced12c1bc829888803ce07fff317e590ec1c [6897/13075] optee: add per cpu asynchronous notification
config: arm64-randconfig-m041-20230419 (https://download.01.org/0day-ci/archive/20230420/202304200755.OoiuclDZ-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202304200755.OoiuclDZ-lkp@intel.com/

smatch warnings:
drivers/tee/optee/smc_abi.c:1021 irq_handler() error: uninitialized symbol 'value_valid'.
drivers/tee/optee/smc_abi.c:1028 irq_handler() error: uninitialized symbol 'value_pending'.

vim +/value_valid +1021 drivers/tee/optee/smc_abi.c

b3b4ced12c1bc8 Etienne Carriere 2023-03-22  1011  static irqreturn_t irq_handler(struct optee *optee)
6749e69c4dadd3 Jens Wiklander   2021-06-15  1012  {
6749e69c4dadd3 Jens Wiklander   2021-06-15  1013  	bool do_bottom_half = false;
6749e69c4dadd3 Jens Wiklander   2021-06-15  1014  	bool value_valid;
6749e69c4dadd3 Jens Wiklander   2021-06-15  1015  	bool value_pending;
6749e69c4dadd3 Jens Wiklander   2021-06-15  1016  	u32 value;
6749e69c4dadd3 Jens Wiklander   2021-06-15  1017  
6749e69c4dadd3 Jens Wiklander   2021-06-15  1018  	do {
6749e69c4dadd3 Jens Wiklander   2021-06-15  1019  		value = get_async_notif_value(optee->smc.invoke_fn,
6749e69c4dadd3 Jens Wiklander   2021-06-15  1020  					      &value_valid, &value_pending);

The get_async_notif_value() function can return zero without initializing
*valid_value or *value_pending.

6749e69c4dadd3 Jens Wiklander   2021-06-15 @1021  		if (!value_valid)
6749e69c4dadd3 Jens Wiklander   2021-06-15  1022  			break;
6749e69c4dadd3 Jens Wiklander   2021-06-15  1023  
6749e69c4dadd3 Jens Wiklander   2021-06-15  1024  		if (value == OPTEE_SMC_ASYNC_NOTIF_VALUE_DO_BOTTOM_HALF)
6749e69c4dadd3 Jens Wiklander   2021-06-15  1025  			do_bottom_half = true;
6749e69c4dadd3 Jens Wiklander   2021-06-15  1026  		else
6749e69c4dadd3 Jens Wiklander   2021-06-15  1027  			optee_notif_send(optee, value);
6749e69c4dadd3 Jens Wiklander   2021-06-15 @1028  	} while (value_pending);
6749e69c4dadd3 Jens Wiklander   2021-06-15  1029  
6749e69c4dadd3 Jens Wiklander   2021-06-15  1030  	if (do_bottom_half)
6749e69c4dadd3 Jens Wiklander   2021-06-15  1031  		return IRQ_WAKE_THREAD;
6749e69c4dadd3 Jens Wiklander   2021-06-15  1032  	return IRQ_HANDLED;
6749e69c4dadd3 Jens Wiklander   2021-06-15  1033  }

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests


             reply	other threads:[~2023-04-20  6:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-20  6:03 Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-04-19 23:32 [linux-next:master 6897/13075] drivers/tee/optee/smc_abi.c:1021 irq_handler() error: uninitialized symbol 'value_valid' kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9b7f69b-c737-4cb3-8e74-79fe00c934f9@kili.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=etienne.carriere@linaro.org \
    --cc=jens.wiklander@linaro.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=oe-kbuild@lists.linux.dev \
    --cc=sumit.garg@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.