From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tuikov, Luben" <Luben.Tuikov-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH 2/8] drm/amdgpu: add a generic fb accessing helper function
Date: Fri, 11 Oct 2019 22:44:28 +0000
Message-ID: <d9b839fe-7545-adcf-4b57-1436eef173ec@amd.com>
References: <20191011035033.24935-1-tianci.yin@amd.com>
 <20191011035033.24935-2-tianci.yin@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
In-Reply-To: <20191011035033.24935-2-tianci.yin-5C7GfCeVMHo@public.gmane.org>
Content-Language: en-US
Content-ID: <A37BDEDBDC64644D9985501DCF1444C5-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org>
List-Id: Discussion list for AMD gfx <amd-gfx.lists.freedesktop.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/amd-gfx>
List-Post: <mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
List-Help: <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/amd-gfx>,
 <mailto:amd-gfx-request-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org?subject=subscribe>
Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Sender: "amd-gfx" <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
To: "Yin, Tianci (Rico)" <Tianci.Yin-5C7GfCeVMHo@public.gmane.org>, "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: "Deucher, Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>, "Koenig,
 Christian" <Christian.Koenig-5C7GfCeVMHo@public.gmane.org>

T24gMjAxOS0xMC0xMCAxMTo1MCBwLm0uLCBUaWFuY2kgWWluIHdyb3RlOg0KPiBGcm9tOiAiVGlh
bmNpLllpbiIgPHRpYW5jaS55aW5AYW1kLmNvbT4NCj4gDQo+IGFkZCBhIGdlbmVyaWMgaGVscGVy
IGZ1bmN0aW9uIGZvciBhY2Nlc3NpbmcgZnJhbWVidWZmZXIgdmlhIE1NSU8NCj4gDQo+IENoYW5n
ZS1JZDogSTRiYWEwYWE1M2M5M2E5NGMyZWZmOThjNjIxMWE2MWYzNjkyMzk5ODINCj4gUmV2aWV3
ZWQtYnk6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRldWNoZXJAYW1kLmNvbT4NCj4gU2lnbmVk
LW9mZi1ieTogVGlhbmNpLllpbiA8dGlhbmNpLnlpbkBhbWQuY29tPg0KPiAtLS0NCj4gIGRyaXZl
cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oICAgICAgICAgICB8ICAyICsrDQo+ICBkcml2
ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMgICAgfCAzNCArKysrKysrKysr
KysrKysrKysrDQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGlzY292ZXJ5
LmMgfCAxMyArLS0tLS0tDQo+ICAzIGZpbGVzIGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDEy
IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k
Z3B1L2FtZGdwdS5oIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgNCj4gaW5k
ZXggNTFjY2YxNzVjZGEwLi4xMTAyZTZiYWU1ZDUgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvZ3B1
L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k
Z3B1L2FtZGdwdS5oDQo+IEBAIC05OTEsNiArOTkxLDggQEAgaW50IGFtZGdwdV9kZXZpY2VfaW5p
dChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwNCj4gIHZvaWQgYW1kZ3B1X2RldmljZV9maW5p
KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KTsNCj4gIGludCBhbWRncHVfZ3B1X3dhaXRfZm9y
X2lkbGUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpOw0KPiAgDQo+ICtpbnQgYW1kZ3B1X2Rl
dmljZV92cmFtX2FjY2VzcyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgbG9mZl90IHBvcywN
Cj4gKwkJCSAgICAgIHVpbnQzMl90ICpidWYsIHNpemVfdCBzaXplLCBib29sIHdyaXRlKTsNCj4g
IHVpbnQzMl90IGFtZGdwdV9tbV9ycmVnKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LCB1aW50
MzJfdCByZWcsDQo+ICAJCQl1aW50MzJfdCBhY2NfZmxhZ3MpOw0KPiAgdm9pZCBhbWRncHVfbW1f
d3JlZyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgdWludDMyX3QgcmVnLCB1aW50MzJfdCB2
LA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rldmlj
ZS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jDQo+IGluZGV4
IDU5ODE1OGU5NWVjMS4uZmIyMWVjMWY4YTYxIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2dwdS9k
cm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMNCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2Ft
ZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jDQo+IEBAIC0xNTQsNiArMTU0LDQwIEBAIGJvb2wgYW1k
Z3B1X2RldmljZV9pc19weChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQ0KPiAgCXJldHVybiBmYWxz
ZTsNCj4gIH0NCj4gIA0KPiArLyoqDQo+ICsgKiBWUkFNIGFjY2VzcyBoZWxwZXIgZnVuY3Rpb25z
Lg0KPiArICoNCj4gKyAqIGFtZGdwdV9kZXZpY2VfdnJhbV9hY2Nlc3MgLSByZWFkL3dyaXRlIGEg
YnVmZmVyIGluIHZyYW0NCj4gKyAqDQo+ICsgKiBAYWRldjogYW1kZ3B1X2RldmljZSBwb2ludGVy
DQo+ICsgKiBAcG9zOiBvZmZzZXQgb2YgdGhlIGJ1ZmZlciBpbiB2cmFtDQo+ICsgKiBAYnVmOiB2
aXJ0dWFsIGFkZHJlc3Mgb2YgdGhlIGJ1ZmZlciBpbiBzeXN0ZW0gbWVtb3J5DQo+ICsgKiBAc2l6
ZTogcmVhZC93cml0ZSBzaXplLCBzaXplb2YoQGJ1ZikgbXVzdCA+IEBzaXplDQo+ICsgKiBAd3Jp
dGU6IHRydWUgLSB3cml0ZSB0byB2cmFtLCBvdGhlcndpc2UgLSByZWFkIGZyb20gdnJhbQ0KPiAr
ICoNCj4gKyAqIFJldHVybnMgMCBvbiBzdWNjZXNzIG9yIGFuIC1lcnJvciBvbiBmYWlsdXJlLg0K
DQpSZWFsbHk/IFdoZXJlPw0KVGhpcyBmdW5jdGlvbiBzZWVtcyB0byByZXR1cm4gMC4NClRyYWRp
dGlvbmFsbHkgcmVhZC93cml0ZSBmdW5jdGlvbnMNCnJldHVybiB0aGUgbnVtYmVyIG9mIGJ5dGVz
IHJlYWQvd3JpdHRlbiBvciBlcnJvci4NCllvdSBkbyBuZWl0aGVyLiBKdXN0IGRlZmluZSBpdCB2
b2lkLg0KDQo+ICsgKi8NCj4gK2ludCBhbWRncHVfZGV2aWNlX3ZyYW1fYWNjZXNzKHN0cnVjdCBh
bWRncHVfZGV2aWNlICphZGV2LCBsb2ZmX3QgcG9zLA0KPiArCQkJICAgICAgdWludDMyX3QgKmJ1
Ziwgc2l6ZV90IHNpemUsIGJvb2wgd3JpdGUpDQo+ICt7DQo+ICsJdWludDY0X3QgZW5kID0gcG9z
ICsgc2l6ZTsNCg0KTkFLISB0byBwcmVpbml0aWFsaXppbmcgYXV0b21hdGljIHZhcmlhYmxlcy4N
Cg0KPiArCXVuc2lnbmVkIGxvbmcgZmxhZ3M7DQo+ICsNCj4gKwl3aGlsZSAocG9zIDwgZW5kKSB7
DQo+ICsJCXNwaW5fbG9ja19pcnFzYXZlKCZhZGV2LT5tbWlvX2lkeF9sb2NrLCBmbGFncyk7DQo+
ICsJCVdSRUczMl9OT19LSVEobW1NTV9JTkRFWCwgKCh1aW50MzJfdClwb3MpIHwgMHg4MDAwMDAw
MCk7DQo+ICsJCVdSRUczMl9OT19LSVEobW1NTV9JTkRFWF9ISSwgcG9zID4+IDMxKTsNCj4gKwkJ
aWYgKHdyaXRlKQ0KPiArCQkJV1JFRzMyX05PX0tJUShtbU1NX0RBVEEsICpidWYrKyk7DQo+ICsJ
CWVsc2UNCj4gKwkJCSpidWYrKyA9IFJSRUczMl9OT19LSVEobW1NTV9EQVRBKTsNCj4gKwkJc3Bp
bl91bmxvY2tfaXJxcmVzdG9yZSgmYWRldi0+bW1pb19pZHhfbG9jaywgZmxhZ3MpOw0KPiArCQlw
b3MgKz0gNDsNCj4gKwl9DQoNCk5BSyEgdG8gdGhpcyB0aGlzOg0KDQp3aGlsZSAocG9zIDwgZW5k
KSB7ICAgICA8LS0tKw0KCTxib2R5IG9mIGxvb3A+ICAgICAgfC0tPiBQYXJ0IG9mIHRoZSBsb29w
IGRlZmluaXRpb24NCglwb3MgKz0gNDsgICAgICAgPC0tLSsNCn0NCg0KSW5zdGVhZCBvZiBicmVh
a2luZyB1cCB0aGUgbG9vcCBkZWZpbml0aW9uIGxpa2UgdGhpcywNCnVzZSBhIGZvci1sb29wLCBh
bmQgRE8gTk9UIHByZWluaXRpYWxpemUgdGhlICJlbmQiIHZhcmlhYmxlLA0KYW5kIGFsc28gcHJv
dGVjdCBmcm9tIG92ZXJmbG93LCBhbGwgbGlrZSB0aGlzOg0KDQpsYXN0ID0gc2l6ZSAtIDE7DQpm
b3IgKGxhc3QgKz0gcG9zOyBwb3MgPD0gbGFzdDsgcG9zICs9IDQpIHsNCgk8Ym9keSBvZiBsb29w
Pg0KfQ0KDQpJIG1lbnRpb25lZCB0aGUgd2h5IG9mIHRoaXMgaW4gbXkgcHJldmlvdXMgcmV2aWV3
IG9mIHRoZSBzYW1lDQp0b3BpYyBwYXRjaHNldCBvdmVyIHRoZSBzYW1lIHdoaWxlIGxvb3AgZmlh
c2NvLg0KDQpSZWdhcmRzLA0KTHViZW4NCg0KPiArDQo+ICsJcmV0dXJuIDA7DQo+ICt9DQo+ICsN
Cj4gIC8qDQo+ICAgKiBNTUlPIHJlZ2lzdGVyIGFjY2VzcyBoZWxwZXIgZnVuY3Rpb25zLg0KPiAg
ICovDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGlz
Y292ZXJ5LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGlzY292ZXJ5LmMN
Cj4gaW5kZXggZGIyZGFiM2E2ZGZmLi4zMjRjMmQ2MDVmNTQgMTAwNjQ0DQo+IC0tLSBhL2RyaXZl
cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kaXNjb3ZlcnkuYw0KPiArKysgYi9kcml2ZXJz
L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGlzY292ZXJ5LmMNCj4gQEAgLTEzNCwyMSArMTM0
LDEwIEBAIHN0YXRpYyBpbnQgaHdfaWRfbWFwW01BWF9IV0lQXSA9IHsNCj4gIA0KPiAgc3RhdGlj
IGludCBhbWRncHVfZGlzY292ZXJ5X3JlYWRfYmluYXJ5KHN0cnVjdCBhbWRncHVfZGV2aWNlICph
ZGV2LCB1aW50OF90ICpiaW5hcnkpDQo+ICB7DQo+IC0JdWludDMyX3QgKnAgPSAodWludDMyX3Qg
KiliaW5hcnk7DQo+ICAJdWludDY0X3QgdnJhbV9zaXplID0gKHVpbnQ2NF90KVJSRUczMihtbVJD
Q19DT05GSUdfTUVNU0laRSkgPDwgMjA7DQo+ICAJdWludDY0X3QgcG9zID0gdnJhbV9zaXplIC0g
QklOQVJZX01BWF9TSVpFOw0KPiAtCXVuc2lnbmVkIGxvbmcgZmxhZ3M7DQo+IC0NCj4gLQl3aGls
ZSAocG9zIDwgdnJhbV9zaXplKSB7DQo+IC0JCXNwaW5fbG9ja19pcnFzYXZlKCZhZGV2LT5tbWlv
X2lkeF9sb2NrLCBmbGFncyk7DQo+IC0JCVdSRUczMl9OT19LSVEobW1NTV9JTkRFWCwgKCh1aW50
MzJfdClwb3MpIHwgMHg4MDAwMDAwMCk7DQo+IC0JCVdSRUczMl9OT19LSVEobW1NTV9JTkRFWF9I
SSwgcG9zID4+IDMxKTsNCj4gLQkJKnArKyA9IFJSRUczMl9OT19LSVEobW1NTV9EQVRBKTsNCj4g
LQkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmYWRldi0+bW1pb19pZHhfbG9jaywgZmxhZ3MpOw0K
PiAtCQlwb3MgKz0gNDsNCj4gLQl9DQo+ICANCj4gLQlyZXR1cm4gMDsNCj4gKwlyZXR1cm4gYW1k
Z3B1X2RldmljZV92cmFtX2FjY2VzcyhhZGV2LCBwb3MsICh1aW50MzJfdCAqKWJpbmFyeSwgQklO
QVJZX01BWF9TSVpFLCBmYWxzZSk7DQo+ICB9DQo+ICANCj4gIHN0YXRpYyB1aW50MTZfdCBhbWRn
cHVfZGlzY292ZXJ5X2NhbGN1bGF0ZV9jaGVja3N1bSh1aW50OF90ICpkYXRhLCB1aW50MzJfdCBz
aXplKQ0KPiANCg0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0
cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4