From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48132C433B4 for ; Wed, 7 Apr 2021 07:50:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CB1961222 for ; Wed, 7 Apr 2021 07:50:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245522AbhDGHuk (ORCPT ); Wed, 7 Apr 2021 03:50:40 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:15938 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234159AbhDGHuh (ORCPT ); Wed, 7 Apr 2021 03:50:37 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FFc2R3p9rzyNSk; Wed, 7 Apr 2021 15:48:15 +0800 (CST) Received: from [10.67.110.73] (10.67.110.73) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Wed, 7 Apr 2021 15:50:19 +0800 Subject: Re: [PATCH -next] drm/bridge: lt8912b: DRM_LONTIUM_LT8912B select GPIOLIB To: Robert Foss CC: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , "Jernej Skrabec" , David Airlie , "Daniel Vetter" , dri-devel , linux-kernel , , References: <20210406090733.169989-1-zhangjianhua18@huawei.com> From: "zhangjianhua (E)" Message-ID: Date: Wed, 7 Apr 2021 15:50:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.73] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robert Yes, you are right, there are many files reference gpiod_set_value_cansleep() and devm_gpiod_get_optional(). How about add config dependencies for all releated configs or only add config dependencies for the top level config? Best regards Zhang Jianhua 在 2021/4/6 18:21, Robert Foss 写道: > Hey Zhang > > On Tue, 6 Apr 2021 at 11:07, Zhang Jianhua wrote: >> If CONFIG_DRM_LONTIUM_LT8912B=y, the following errors will be seen while >> compiling lontium-lt8912b.c >> >> drivers/gpu/drm/bridge/lontium-lt8912b.c: In function >> ‘lt8912_hard_power_on’: >> drivers/gpu/drm/bridge/lontium-lt8912b.c:252:2: error: implicit >> declaration of function ‘gpiod_set_value_cansleep’; did you mean >> ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration] >> gpiod_set_value_cansleep(lt->gp_reset, 0); >> ^~~~~~~~~~~~~~~~~~~~~~~~ >> gpio_set_value_cansleep >> drivers/gpu/drm/bridge/lontium-lt8912b.c: In function ‘lt8912_parse_dt’: >> drivers/gpu/drm/bridge/lontium-lt8912b.c:628:13: error: implicit >> declaration of function ‘devm_gpiod_get_optional’; did you mean >> ‘devm_gpio_request_one’? [-Werror=implicit-function-declaration] >> gp_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); >> ^~~~~~~~~~~~~~~~~~~~~~~ >> devm_gpio_request_one >> drivers/gpu/drm/bridge/lontium-lt8912b.c:628:51: error: ‘GPIOD_OUT_HIGH’ >> undeclared (first use in this function); did you mean ‘GPIOF_INIT_HIGH’? >> gp_reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); >> ^~~~~~~~~~~~~~ >> GPIOF_INIT_HIGH >> >> Signed-off-by: Zhang Jianhua >> --- >> drivers/gpu/drm/bridge/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig >> index dba62f92d051..caa9658ec933 100644 >> --- a/drivers/gpu/drm/bridge/Kconfig >> +++ b/drivers/gpu/drm/bridge/Kconfig >> @@ -67,6 +67,7 @@ config DRM_LONTIUM_LT8912B >> select DRM_PANEL_BRIDGE >> select DRM_KMS_HELPER >> select REGMAP_I2C >> + select GPIOLIB > This appears like the right fix for this problem. However, a number of > drm/bridge drivers seem to call both gpio_set_value_cansleep() and > devm_gpiod_get_optional() without having the GPIOLIB kconfig option > selected so this can't be a new issue. Maybe some more investigation > is in order. > . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28293C433ED for ; Wed, 7 Apr 2021 07:50:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C30A260C40 for ; Wed, 7 Apr 2021 07:50:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C30A260C40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D24889C83; Wed, 7 Apr 2021 07:50:30 +0000 (UTC) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by gabe.freedesktop.org (Postfix) with ESMTPS id E083489C83 for ; Wed, 7 Apr 2021 07:50:28 +0000 (UTC) Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FFc2R3p9rzyNSk; Wed, 7 Apr 2021 15:48:15 +0800 (CST) Received: from [10.67.110.73] (10.67.110.73) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Wed, 7 Apr 2021 15:50:19 +0800 Subject: Re: [PATCH -next] drm/bridge: lt8912b: DRM_LONTIUM_LT8912B select GPIOLIB To: Robert Foss References: <20210406090733.169989-1-zhangjianhua18@huawei.com> From: "zhangjianhua (E)" Message-ID: Date: Wed, 7 Apr 2021 15:50:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.67.110.73] X-CFilter-Loop: Reflected X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Jonas Karlman , David Airlie , Neil Armstrong , linux-kernel , dri-devel , Andrzej Hajda , Laurent Pinchart , johnny.chenyi@huawei.com, heying24@huawei.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgUm9iZXJ0CgpZZXMsIHlvdSBhcmUgcmlnaHQsIHRoZXJlIGFyZSBtYW55IGZpbGVzIHJlZmVy ZW5jZSAKZ3Bpb2Rfc2V0X3ZhbHVlX2NhbnNsZWVwKCkgYW5kCgpkZXZtX2dwaW9kX2dldF9vcHRp b25hbCgpLiBIb3cgYWJvdXQgYWRkIGNvbmZpZyBkZXBlbmRlbmNpZXMgZm9yIGFsbCAKcmVsZWF0 ZWQKCmNvbmZpZ3Mgb3Igb25seSBhZGQgY29uZmlnIGRlcGVuZGVuY2llcyBmb3IgdGhlIHRvcCBs ZXZlbCBjb25maWc/CgoKQmVzdCByZWdhcmRzCgpaaGFuZyBKaWFuaHVhCgrlnKggMjAyMS80LzYg MTg6MjEsIFJvYmVydCBGb3NzIOWGmemBkzoKPiBIZXkgWmhhbmcKPgo+IE9uIFR1ZSwgNiBBcHIg MjAyMSBhdCAxMTowNywgWmhhbmcgSmlhbmh1YSA8emhhbmdqaWFuaHVhMThAaHVhd2VpLmNvbT4g d3JvdGU6Cj4+IElmIENPTkZJR19EUk1fTE9OVElVTV9MVDg5MTJCPXksIHRoZSBmb2xsb3dpbmcg ZXJyb3JzIHdpbGwgYmUgc2VlbiB3aGlsZQo+PiBjb21waWxpbmcgbG9udGl1bS1sdDg5MTJiLmMK Pj4KPj4gZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9sb250aXVtLWx0ODkxMmIuYzogSW4gZnVuY3Rp b24KPj4g4oCYbHQ4OTEyX2hhcmRfcG93ZXJfb27igJk6Cj4+IGRyaXZlcnMvZ3B1L2RybS9icmlk Z2UvbG9udGl1bS1sdDg5MTJiLmM6MjUyOjI6IGVycm9yOiBpbXBsaWNpdAo+PiBkZWNsYXJhdGlv biBvZiBmdW5jdGlvbiDigJhncGlvZF9zZXRfdmFsdWVfY2Fuc2xlZXDigJk7IGRpZCB5b3UgbWVh bgo+PiDigJhncGlvX3NldF92YWx1ZV9jYW5zbGVlcOKAmT8gWy1XZXJyb3I9aW1wbGljaXQtZnVu Y3Rpb24tZGVjbGFyYXRpb25dCj4+ICAgIGdwaW9kX3NldF92YWx1ZV9jYW5zbGVlcChsdC0+Z3Bf cmVzZXQsIDApOwo+PiAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn4KPj4gICAgZ3Bpb19zZXRf dmFsdWVfY2Fuc2xlZXAKPj4gZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9sb250aXVtLWx0ODkxMmIu YzogSW4gZnVuY3Rpb24g4oCYbHQ4OTEyX3BhcnNlX2R04oCZOgo+PiBkcml2ZXJzL2dwdS9kcm0v YnJpZGdlL2xvbnRpdW0tbHQ4OTEyYi5jOjYyODoxMzogZXJyb3I6IGltcGxpY2l0Cj4+IGRlY2xh cmF0aW9uIG9mIGZ1bmN0aW9uIOKAmGRldm1fZ3Bpb2RfZ2V0X29wdGlvbmFs4oCZOyBkaWQgeW91 IG1lYW4KPj4g4oCYZGV2bV9ncGlvX3JlcXVlc3Rfb25l4oCZPyBbLVdlcnJvcj1pbXBsaWNpdC1m dW5jdGlvbi1kZWNsYXJhdGlvbl0KPj4gICAgZ3BfcmVzZXQgPSBkZXZtX2dwaW9kX2dldF9vcHRp b25hbChkZXYsICJyZXNldCIsIEdQSU9EX09VVF9ISUdIKTsKPj4gICAgICAgICAgICAgICBefn5+ fn5+fn5+fn5+fn5+fn5+fn5+fgo+PiAgICAgICAgICAgICAgIGRldm1fZ3Bpb19yZXF1ZXN0X29u ZQo+PiBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2xvbnRpdW0tbHQ4OTEyYi5jOjYyODo1MTogZXJy b3I6IOKAmEdQSU9EX09VVF9ISUdI4oCZCj4+IHVuZGVjbGFyZWQgKGZpcnN0IHVzZSBpbiB0aGlz IGZ1bmN0aW9uKTsgZGlkIHlvdSBtZWFuIOKAmEdQSU9GX0lOSVRfSElHSOKAmT8KPj4gICAgZ3Bf cmVzZXQgPSBkZXZtX2dwaW9kX2dldF9vcHRpb25hbChkZXYsICJyZXNldCIsIEdQSU9EX09VVF9I SUdIKTsKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIF5+fn5+fn5+fn5+fn5+Cj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBHUElPRl9JTklUX0hJR0gKPj4KPj4gU2lnbmVkLW9mZi1ieTogWmhh bmcgSmlhbmh1YSA8emhhbmdqaWFuaHVhMThAaHVhd2VpLmNvbT4KPj4gLS0tCj4+ICAgZHJpdmVy cy9ncHUvZHJtL2JyaWRnZS9LY29uZmlnIHwgMSArCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL0tjb25m aWcgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL0tjb25maWcKPj4gaW5kZXggZGJhNjJmOTJkMDUx Li5jYWE5NjU4ZWM5MzMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvS2Nv bmZpZwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL0tjb25maWcKPj4gQEAgLTY3LDYg KzY3LDcgQEAgY29uZmlnIERSTV9MT05USVVNX0xUODkxMkIKPj4gICAgICAgICAgc2VsZWN0IERS TV9QQU5FTF9CUklER0UKPj4gICAgICAgICAgc2VsZWN0IERSTV9LTVNfSEVMUEVSCj4+ICAgICAg ICAgIHNlbGVjdCBSRUdNQVBfSTJDCj4+ICsgICAgICAgc2VsZWN0IEdQSU9MSUIKPiBUaGlzIGFw cGVhcnMgbGlrZSB0aGUgcmlnaHQgZml4IGZvciB0aGlzIHByb2JsZW0uIEhvd2V2ZXIsIGEgbnVt YmVyIG9mCj4gZHJtL2JyaWRnZSBkcml2ZXJzIHNlZW0gdG8gY2FsbCBib3RoIGdwaW9fc2V0X3Zh bHVlX2NhbnNsZWVwKCkgYW5kCj4gZGV2bV9ncGlvZF9nZXRfb3B0aW9uYWwoKSB3aXRob3V0IGhh dmluZyB0aGUgR1BJT0xJQiBrY29uZmlnIG9wdGlvbgo+IHNlbGVjdGVkIHNvIHRoaXMgY2FuJ3Qg YmUgYSBuZXcgaXNzdWUuIE1heWJlIHNvbWUgbW9yZSBpbnZlc3RpZ2F0aW9uCj4gaXMgaW4gb3Jk ZXIuCj4gLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK