* [PATCH] bus: qcom-ssc-block-bus: Fix resource release in .remove function
@ 2022-05-22 12:31 Christophe JAILLET
2022-12-11 18:52 ` Christophe JAILLET
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2022-05-22 12:31 UTC (permalink / raw)
To: dan.carpenter, Andy Gross, Bjorn Andersson, Jeffrey Hugo, Michael Srba
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-arm-msm
These resources are allocated using devm_ioremap_resource(), so there is no
need to call iounmap() explicitly.
Fixes: 97d485edc1d9 ("bus: add driver for initializing the SSC bus on (some) qcom SoCs")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/bus/qcom-ssc-block-bus.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/bus/qcom-ssc-block-bus.c b/drivers/bus/qcom-ssc-block-bus.c
index eedeb29a5ff3..eaa39e08dd96 100644
--- a/drivers/bus/qcom-ssc-block-bus.c
+++ b/drivers/bus/qcom-ssc-block-bus.c
@@ -356,9 +356,6 @@ static int qcom_ssc_block_bus_remove(struct platform_device *pdev)
qcom_ssc_block_bus_deinit(&pdev->dev);
- iounmap(data->reg_mpm_sscaon_config0);
- iounmap(data->reg_mpm_sscaon_config1);
-
qcom_ssc_block_bus_pds_disable(data->pds, data->num_pds);
qcom_ssc_block_bus_pds_detach(&pdev->dev, data->pds, data->num_pds);
pm_runtime_disable(&pdev->dev);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bus: qcom-ssc-block-bus: Fix resource release in .remove function
2022-05-22 12:31 [PATCH] bus: qcom-ssc-block-bus: Fix resource release in .remove function Christophe JAILLET
@ 2022-12-11 18:52 ` Christophe JAILLET
0 siblings, 0 replies; 2+ messages in thread
From: Christophe JAILLET @ 2022-12-11 18:52 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Philipp Zabel
Cc: linux-kernel, kernel-janitors, linux-arm-msm
Le 22/05/2022 à 14:31, Christophe JAILLET a écrit :
> These resources are allocated using devm_ioremap_resource(), so there is no
> need to call iounmap() explicitly.
>
> Fixes: 97d485edc1d9 ("bus: add driver for initializing the SSC bus on (some) qcom SoCs")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/bus/qcom-ssc-block-bus.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/bus/qcom-ssc-block-bus.c b/drivers/bus/qcom-ssc-block-bus.c
> index eedeb29a5ff3..eaa39e08dd96 100644
> --- a/drivers/bus/qcom-ssc-block-bus.c
> +++ b/drivers/bus/qcom-ssc-block-bus.c
> @@ -356,9 +356,6 @@ static int qcom_ssc_block_bus_remove(struct platform_device *pdev)
>
> qcom_ssc_block_bus_deinit(&pdev->dev);
>
> - iounmap(data->reg_mpm_sscaon_config0);
> - iounmap(data->reg_mpm_sscaon_config1);
> -
> qcom_ssc_block_bus_pds_disable(data->pds, data->num_pds);
> qcom_ssc_block_bus_pds_detach(&pdev->dev, data->pds, data->num_pds);
> pm_runtime_disable(&pdev->dev);
Hi,
polite reminder, with updated list from get_maintainer.pl
CJ
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-11 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-22 12:31 [PATCH] bus: qcom-ssc-block-bus: Fix resource release in .remove function Christophe JAILLET
2022-12-11 18:52 ` Christophe JAILLET
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.