Re: [PATCH] ndctl/dimm: Fix to dump namespace indexs and labels

["Verma, Vishal L" <vishal.l.verma@intel.com>]

On Thu, 2021-07-08 at 09:53 +0800, Liu, Jingqi wrote:
> > 
> > [..]
> > > 
> > > diff --git a/ndctl/lib/libndctl.sym b/ndctl/lib/libndctl.sym
> > > index 0a82616..0ce2bb9 100644
> > > --- a/ndctl/lib/libndctl.sym
> > > +++ b/ndctl/lib/libndctl.sym
> > > @@ -290,6 +290,7 @@ global:
> > >        ndctl_dimm_validate_labels;
> > >        ndctl_dimm_init_labels;
> > >        ndctl_dimm_sizeof_namespace_label;
> > > +     ndctl_dimm_sizeof_namespace_index;
> > 
> > This can't go into an 'old' section of the symbol version script - if
> > you base off the current 'pending' branch, you should see a LIBNDCTL_26
> > section at the bottom. You can add this there.
> 
> It's based on the current 'master' branch.
> I don't see a LIBNDCTL_26 section, just 'LIBNDCTL_25'.
> How about adding 'ndctl_dimm_sizeof_namespace_index' to LIBNDCTL_25 
> section ?
> 
No - so once a release happens, that section is 'closed' forever. The
master branch coincides with the v71 release. That release had added
new symbols in the LIBNDCTL_25 section, and that section is now done.
New symbols after v71 need to go in a new section, LIBNDCTL_26.

The pending branch just happens to have patches that added a new
symbol, so the new section is already created for you - so if you
rebase to pending, you can just reuse that. Alternatively, base off
master, and create a new LIBNDCTL_26 section, and I'll fix up the
trivial conflict when merging.

Hope this clarifies things a bit!

Thanks,
-Vishal